-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](Nereids) fixed the limit offset error #39316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 39866 ms
|
morrySnow
reviewed
Aug 13, 2024
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java
Outdated
Show resolved
Hide resolved
TPC-DS: Total hot run time: 184409 ms
|
ClickBench: Total hot run time: 30.74 s
|
run buildall |
TPC-H: Total hot run time: 39716 ms
|
TPC-DS: Total hot run time: 191240 ms
|
ClickBench: Total hot run time: 30.16 s
|
lide-reed
reviewed
Aug 14, 2024
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java
Outdated
Show resolved
Hide resolved
run buildall |
TPC-H: Total hot run time: 37791 ms
|
run buildall |
TPC-H: Total hot run time: 37663 ms
|
TPC-DS: Total hot run time: 184204 ms
|
ClickBench: Total hot run time: 31.53 s
|
run buildall |
TPC-H: Total hot run time: 37445 ms
|
TPC-DS: Total hot run time: 189937 ms
|
ClickBench: Total hot run time: 31.56 s
|
run compile |
run p0 |
run cloud_p0 |
run cloud_p1 |
1 similar comment
run cloud_p1 |
starocean999
approved these changes
Oct 15, 2024
924060929
approved these changes
Oct 15, 2024
morrySnow
pushed a commit
that referenced
this pull request
Oct 17, 2024
morrySnow
pushed a commit
that referenced
this pull request
Oct 17, 2024
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Oct 28, 2024
intro by apache#39316. it want to fix a problem intro by apache#36699. but forgot to remove all wrong code in apache#36699. after apache#39316, we should not set offset on exchange, when the exchange is on the top of a limit with offset.
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Oct 28, 2024
…apache#42576) pick from master apache#42576 intro by apache#39316. it want to fix a problem intro by apache#36699. but forgot to remove all wrong code in apache#36699. after apache#39316, we should not set offset on exchange, when the exchange is on the top of a limit with offset.
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Oct 28, 2024
intro by apache#39316. it want to fix a problem intro by apache#36699. but forgot to remove all wrong code in apache#36699. after apache#39316, we should not set offset on exchange, when the exchange is on the top of a limit with offset.
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Oct 28, 2024
…apache#42576) pick from master apache#42576 intro by apache#39316. it want to fix a problem intro by apache#36699. but forgot to remove all wrong code in apache#36699. after apache#39316, we should not set offset on exchange, when the exchange is on the top of a limit with offset.
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Oct 28, 2024
…apache#42576) pick from master apache#42576 intro by apache#39316. it want to fix a problem intro by apache#36699. but forgot to remove all wrong code in apache#36699. after apache#39316, we should not set offset on exchange, when the exchange is on the top of a limit with offset.
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Oct 28, 2024
…apache#42576) pick from master apache#42576 intro by apache#39316. it want to fix a problem intro by apache#36699. but forgot to remove all wrong code in apache#36699. after apache#39316, we should not set offset on exchange, when the exchange is on the top of a limit with offset.
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Oct 28, 2024
…apache#42576) pick from master apache#42576 intro by apache#39316. it want to fix a problem intro by apache#36699. but forgot to remove all wrong code in apache#36699. after apache#39316, we should not set offset on exchange, when the exchange is on the top of a limit with offset.
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Oct 29, 2024
…apache#42576) pick from master apache#42576 intro by apache#39316. it want to fix a problem intro by apache#36699. but forgot to remove all wrong code in apache#36699. after apache#39316, we should not set offset on exchange, when the exchange is on the top of a limit with offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.0.16-merged
dev/2.1.7-merged
dev/3.0.3-merged
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #36699