Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](catalog) gen partition id by name #39325

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Aug 13, 2024

Followup #38525
Previously, we use sequence number to generate partition id of table in hive metastore.
for example, there are 2 partitions: dt=2024-10-02 and dt=2024-10-03, the partition id will be 0 and 1.
But if a new partition being added: dt=2024-10-01, the partiton id will be 0, 1, and 2.
You can see, before, the id 0 is for dt=2024-10-02, but now 0 is for dt=2024-10-01.

This PR use catalog/db/table/partition name to generate a id for the partition,
so that each partition will have unique id.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions github-actions bot added the doing label Aug 13, 2024
Copy link
Contributor

@zddr zddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor Author

run buildall

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38023 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 57e8563dcddff3f0aab2bce4fe176edf96bbb86a, data reload: false

------ Round 1 ----------------------------------
q1	17627	4552	4391	4391
q2	2019	179	177	177
q3	10465	1259	1133	1133
q4	10137	756	760	756
q5	7760	2794	2784	2784
q6	224	146	141	141
q7	969	604	603	603
q8	9320	2079	2061	2061
q9	7340	6571	6580	6571
q10	7002	2265	2206	2206
q11	468	248	251	248
q12	403	241	240	240
q13	18966	3001	2968	2968
q14	276	246	232	232
q15	541	496	488	488
q16	520	396	402	396
q17	997	644	762	644
q18	7488	6859	6767	6767
q19	7432	1093	1078	1078
q20	757	338	352	338
q21	4197	3029	2771	2771
q22	1097	1030	1048	1030
Total cold run time: 116005 ms
Total hot run time: 38023 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4552	4307	4348	4307
q2	398	270	287	270
q3	2812	2607	2633	2607
q4	2001	1653	1728	1653
q5	5644	5639	5751	5639
q6	246	148	137	137
q7	2135	1777	1750	1750
q8	3296	3453	3417	3417
q9	8812	8867	8770	8770
q10	3536	3335	3285	3285
q11	605	526	514	514
q12	793	618	640	618
q13	16242	3233	3243	3233
q14	326	276	282	276
q15	534	505	487	487
q16	508	465	473	465
q17	1850	1558	1543	1543
q18	8099	7835	7358	7358
q19	3328	1667	1506	1506
q20	2126	1838	1808	1808
q21	5214	5376	5140	5140
q22	1111	1050	1011	1011
Total cold run time: 74168 ms
Total hot run time: 55794 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185357 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 57e8563dcddff3f0aab2bce4fe176edf96bbb86a, data reload: false

query1	886	389	380	380
query2	6442	2075	2002	2002
query3	6639	212	218	212
query4	33097	23228	23187	23187
query5	4236	496	487	487
query6	257	164	166	164
query7	4581	290	285	285
query8	242	201	198	198
query9	8480	2491	2451	2451
query10	411	271	256	256
query11	17772	15080	15037	15037
query12	152	101	101	101
query13	1626	371	355	355
query14	9168	7196	6929	6929
query15	214	166	172	166
query16	7519	501	499	499
query17	1095	559	553	553
query18	1547	291	290	290
query19	200	147	146	146
query20	116	105	107	105
query21	204	103	98	98
query22	4142	4174	3906	3906
query23	34002	33197	33323	33197
query24	12233	2869	2906	2869
query25	697	388	412	388
query26	1839	161	160	160
query27	2875	275	284	275
query28	7491	2065	2054	2054
query29	1089	432	426	426
query30	308	148	158	148
query31	970	742	771	742
query32	102	54	58	54
query33	758	299	295	295
query34	930	477	475	475
query35	861	725	748	725
query36	1086	924	940	924
query37	281	88	84	84
query38	3907	3914	4019	3914
query39	1439	1390	1389	1389
query40	277	121	120	120
query41	50	46	50	46
query42	120	104	98	98
query43	536	476	482	476
query44	1329	746	735	735
query45	202	169	167	167
query46	1101	710	747	710
query47	1907	1728	1775	1728
query48	363	290	292	290
query49	1163	435	450	435
query50	805	414	416	414
query51	6737	6724	6625	6625
query52	103	94	89	89
query53	354	180	183	180
query54	915	455	448	448
query55	77	75	79	75
query56	289	254	254	254
query57	1182	1049	1071	1049
query58	244	227	245	227
query59	3112	2856	2711	2711
query60	288	260	264	260
query61	107	90	100	90
query62	813	645	649	645
query63	226	180	182	180
query64	6268	2257	1746	1746
query65	3214	3154	3177	3154
query66	1324	336	339	336
query67	15566	14821	14970	14821
query68	6647	548	551	548
query69	648	323	293	293
query70	1135	1157	1093	1093
query71	554	277	282	277
query72	7506	2227	2033	2033
query73	830	323	328	323
query74	9331	8688	8956	8688
query75	4879	2707	2643	2643
query76	4713	971	974	971
query77	766	319	305	305
query78	10119	9234	8966	8966
query79	8641	535	533	533
query80	2424	498	546	498
query81	591	224	223	223
query82	730	137	135	135
query83	280	148	149	148
query84	270	76	75	75
query85	1329	282	268	268
query86	393	299	265	265
query87	4406	4233	4189	4189
query88	5404	2341	2325	2325
query89	533	293	288	288
query90	2061	203	194	194
query91	127	95	95	95
query92	69	52	50	50
query93	6591	538	540	538
query94	924	299	290	290
query95	353	259	258	258
query96	635	273	272	272
query97	3206	3092	3041	3041
query98	247	224	217	217
query99	1551	1303	1280	1280
Total cold run time: 316459 ms
Total hot run time: 185357 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.97 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 57e8563dcddff3f0aab2bce4fe176edf96bbb86a, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.05
query3	0.22	0.05	0.05
query4	1.68	0.09	0.08
query5	0.50	0.48	0.47
query6	1.12	0.74	0.72
query7	0.02	0.02	0.01
query8	0.06	0.04	0.04
query9	0.54	0.49	0.50
query10	0.54	0.54	0.55
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.61	0.59
query14	0.77	0.78	0.78
query15	0.85	0.82	0.80
query16	0.39	0.36	0.37
query17	1.05	1.03	1.00
query18	0.22	0.22	0.21
query19	1.81	1.74	1.70
query20	0.01	0.01	0.03
query21	15.38	0.76	0.67
query22	4.62	6.46	2.07
query23	18.33	1.44	1.29
query24	2.12	0.21	0.23
query25	0.14	0.07	0.08
query26	0.32	0.22	0.22
query27	0.45	0.23	0.22
query28	13.34	1.02	1.01
query29	12.59	3.39	3.37
query30	0.25	0.05	0.05
query31	2.88	0.38	0.39
query32	3.28	0.48	0.48
query33	2.95	2.96	2.94
query34	17.08	4.38	4.41
query35	4.41	4.38	4.40
query36	0.67	0.46	0.48
query37	0.19	0.16	0.16
query38	0.16	0.16	0.16
query39	0.05	0.03	0.03
query40	0.15	0.12	0.12
query41	0.09	0.05	0.05
query42	0.06	0.04	0.06
query43	0.05	0.04	0.04
Total cold run time: 110.37 s
Total hot run time: 30.97 s

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37266 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e878192195dae7871950ac455aab73c13d5e5e84, data reload: false

------ Round 1 ----------------------------------
q1	17609	4448	4374	4374
q2	2015	194	177	177
q3	11922	983	1037	983
q4	10502	834	784	784
q5	7776	2823	2751	2751
q6	222	133	132	132
q7	952	588	589	588
q8	9524	2025	2051	2025
q9	8642	6499	6510	6499
q10	7017	2211	2201	2201
q11	448	239	241	239
q12	383	222	215	215
q13	17858	2953	2972	2953
q14	277	238	236	236
q15	510	493	495	493
q16	494	404	376	376
q17	955	596	635	596
q18	7433	6735	6668	6668
q19	7647	936	1061	936
q20	694	327	328	327
q21	3810	2700	2890	2700
q22	1121	1013	1023	1013
Total cold run time: 117811 ms
Total hot run time: 37266 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4491	4253	4239	4239
q2	372	265	264	264
q3	2847	2637	2609	2609
q4	2015	1672	1724	1672
q5	5665	5732	5615	5615
q6	234	136	131	131
q7	2128	1756	1716	1716
q8	3301	3493	3424	3424
q9	8785	8720	8850	8720
q10	3600	3286	3286	3286
q11	575	518	493	493
q12	826	634	620	620
q13	17061	3136	3237	3136
q14	309	292	305	292
q15	552	500	489	489
q16	500	452	447	447
q17	1839	1547	1498	1498
q18	7952	8061	7789	7789
q19	1714	1557	1609	1557
q20	2115	1868	1908	1868
q21	5563	5284	5337	5284
q22	1135	1072	1039	1039
Total cold run time: 73579 ms
Total hot run time: 56188 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189571 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e878192195dae7871950ac455aab73c13d5e5e84, data reload: false

query1	1253	899	867	867
query2	6459	1936	1847	1847
query3	10688	3966	3734	3734
query4	59415	24417	23147	23147
query5	6022	492	499	492
query6	497	177	166	166
query7	6506	291	295	291
query8	307	202	200	200
query9	9418	2430	2402	2402
query10	549	269	245	245
query11	18787	14983	15175	14983
query12	166	96	102	96
query13	1650	379	385	379
query14	12489	7071	7203	7071
query15	322	184	180	180
query16	7778	547	518	518
query17	1284	588	589	588
query18	2183	314	310	310
query19	278	150	147	147
query20	128	108	114	108
query21	209	146	96	96
query22	4567	4466	4495	4466
query23	34381	33411	33276	33276
query24	5586	2835	2817	2817
query25	530	378	381	378
query26	690	157	154	154
query27	1771	270	273	270
query28	3813	2032	2042	2032
query29	741	401	392	392
query30	343	153	147	147
query31	940	752	744	744
query32	99	52	53	52
query33	480	279	276	276
query34	839	460	469	460
query35	786	718	701	701
query36	1083	887	920	887
query37	138	77	78	77
query38	3915	3877	3908	3877
query39	1450	1381	1380	1380
query40	192	117	114	114
query41	46	46	45	45
query42	119	94	95	94
query43	512	467	468	467
query44	1084	749	731	731
query45	204	167	165	165
query46	1093	751	710	710
query47	1817	1769	1766	1766
query48	357	289	289	289
query49	755	419	421	419
query50	806	395	396	395
query51	6838	6603	6649	6603
query52	106	93	88	88
query53	259	181	177	177
query54	562	449	452	449
query55	76	75	75	75
query56	269	246	263	246
query57	1129	1063	1065	1063
query58	233	231	212	212
query59	2898	2671	2738	2671
query60	294	263	276	263
query61	98	100	93	93
query62	748	635	651	635
query63	215	180	179	179
query64	4347	2216	1681	1681
query65	3228	3161	3143	3143
query66	674	372	338	338
query67	15089	14934	14919	14919
query68	4779	534	540	534
query69	414	269	261	261
query70	1158	1133	1116	1116
query71	389	274	275	274
query72	6572	2278	2013	2013
query73	768	320	316	316
query74	9033	8711	8809	8711
query75	3368	2715	2719	2715
query76	2977	1045	1020	1020
query77	582	305	307	305
query78	10967	9585	9010	9010
query79	4614	520	515	515
query80	1192	492	488	488
query81	538	225	222	222
query82	822	143	137	137
query83	284	148	146	146
query84	264	76	76	76
query85	732	329	271	271
query86	440	300	300	300
query87	4460	4126	4236	4126
query88	4545	2307	2313	2307
query89	415	287	285	285
query90	2030	196	190	190
query91	121	96	94	94
query92	61	48	48	48
query93	4198	538	538	538
query94	797	285	300	285
query95	367	257	258	257
query96	604	271	268	268
query97	3194	3030	3002	3002
query98	218	206	197	197
query99	1631	1274	1261	1261
Total cold run time: 325122 ms
Total hot run time: 189571 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.84 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e878192195dae7871950ac455aab73c13d5e5e84, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.03
query3	0.23	0.05	0.05
query4	1.66	0.08	0.07
query5	0.49	0.50	0.49
query6	1.14	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.49	0.50
query10	0.54	0.54	0.54
query11	0.16	0.13	0.12
query12	0.14	0.12	0.13
query13	0.59	0.60	0.60
query14	0.76	0.78	0.78
query15	0.86	0.82	0.85
query16	0.37	0.37	0.37
query17	1.03	1.04	1.01
query18	0.22	0.21	0.23
query19	1.85	1.75	1.75
query20	0.01	0.01	0.01
query21	15.39	0.74	0.65
query22	4.15	7.52	1.99
query23	18.26	1.42	1.31
query24	2.14	0.22	0.21
query25	0.14	0.07	0.08
query26	0.30	0.22	0.21
query27	0.46	0.22	0.23
query28	13.24	1.02	0.99
query29	12.65	3.29	3.27
query30	0.24	0.05	0.04
query31	2.89	0.39	0.40
query32	3.26	0.48	0.48
query33	2.92	2.99	2.92
query34	16.93	4.36	4.39
query35	4.42	4.40	4.39
query36	0.65	0.48	0.50
query37	0.18	0.16	0.16
query38	0.16	0.14	0.15
query39	0.04	0.04	0.03
query40	0.15	0.13	0.12
query41	0.10	0.04	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.55 s
Total hot run time: 30.84 s

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38462 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e878192195dae7871950ac455aab73c13d5e5e84, data reload: false

------ Round 1 ----------------------------------
q1	17861	4465	4336	4336
q2	2055	214	217	214
q3	11562	1107	1193	1107
q4	10535	681	739	681
q5	7802	2861	2809	2809
q6	263	148	147	147
q7	983	634	626	626
q8	9383	2080	2103	2080
q9	6955	6598	6543	6543
q10	7028	2232	2240	2232
q11	485	268	275	268
q12	414	248	272	248
q13	17779	3056	3030	3030
q14	299	251	248	248
q15	555	518	530	518
q16	522	408	403	403
q17	1003	655	670	655
q18	7530	6855	6860	6855
q19	6942	1187	1125	1125
q20	727	366	363	363
q21	4569	2938	3060	2938
q22	1136	1042	1036	1036
Total cold run time: 116388 ms
Total hot run time: 38462 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4464	4278	4337	4278
q2	405	290	300	290
q3	2889	2687	2667	2667
q4	1981	1673	1702	1673
q5	5728	5771	5690	5690
q6	236	158	146	146
q7	2210	1780	1778	1778
q8	3324	3590	3523	3523
q9	8885	8911	8814	8814
q10	3626	3349	3353	3349
q11	652	549	533	533
q12	852	683	656	656
q13	15885	3181	3214	3181
q14	333	321	308	308
q15	569	513	509	509
q16	497	450	439	439
q17	1857	1567	1576	1567
q18	8644	8021	7688	7688
q19	9617	1708	1590	1590
q20	2143	1924	1910	1910
q21	12968	5428	5484	5428
q22	1178	1117	1084	1084
Total cold run time: 88943 ms
Total hot run time: 57101 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195890 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e878192195dae7871950ac455aab73c13d5e5e84, data reload: false

query1	1328	934	888	888
query2	6574	1971	1889	1889
query3	10656	3891	3812	3812
query4	58887	24376	23426	23426
query5	6075	634	630	630
query6	551	185	208	185
query7	6430	316	309	309
query8	467	358	361	358
query9	9256	2484	2484	2484
query10	547	322	321	321
query11	17898	15091	15400	15091
query12	188	123	127	123
query13	1656	439	475	439
query14	11904	7104	7483	7104
query15	316	210	218	210
query16	7188	515	532	515
query17	1294	621	615	615
query18	1908	337	339	337
query19	301	169	167	167
query20	152	143	136	136
query21	250	139	141	139
query22	4637	4514	4458	4458
query23	34397	33856	33967	33856
query24	5788	3001	3002	3001
query25	582	430	424	424
query26	712	189	183	183
query27	1753	307	303	303
query28	3786	2196	2169	2169
query29	690	452	471	452
query30	234	186	189	186
query31	1021	810	878	810
query32	101	77	76	76
query33	544	338	335	335
query34	906	509	496	496
query35	895	763	760	760
query36	1102	961	938	938
query37	156	103	102	102
query38	4007	3895	3813	3813
query39	1536	1457	1449	1449
query40	235	151	150	150
query41	133	137	132	132
query42	128	113	117	113
query43	544	499	526	499
query44	1129	787	782	782
query45	221	194	193	193
query46	1130	751	775	751
query47	1928	1821	1863	1821
query48	413	335	341	335
query49	911	573	568	568
query50	859	469	464	464
query51	6906	6768	6775	6768
query52	125	110	108	108
query53	294	227	220	220
query54	616	509	514	509
query55	87	89	86	86
query56	334	307	305	305
query57	1244	1147	1144	1144
query58	303	322	301	301
query59	2907	2684	2722	2684
query60	360	354	321	321
query61	153	146	142	142
query62	781	686	684	684
query63	256	225	221	221
query64	3306	1886	1893	1886
query65	3255	3168	3188	3168
query66	1027	653	662	653
query67	15498	15010	15039	15010
query68	5957	594	630	594
query69	566	313	310	310
query70	1191	1087	1177	1087
query71	523	325	312	312
query72	7242	2362	2062	2062
query73	820	355	354	354
query74	9154	8882	8779	8779
query75	3607	2737	2750	2737
query76	3321	1050	1007	1007
query77	683	433	435	433
query78	10295	9117	9095	9095
query79	4484	560	551	551
query80	1758	594	606	594
query81	594	258	255	255
query82	800	164	162	162
query83	368	218	209	209
query84	297	103	104	103
query85	1246	357	355	355
query86	492	312	329	312
query87	4508	4262	4224	4224
query88	4759	2514	2534	2514
query89	434	327	315	315
query90	1965	228	227	227
query91	159	125	126	125
query92	91	73	73	73
query93	4903	547	550	547
query94	953	324	368	324
query95	391	300	311	300
query96	654	294	279	279
query97	3289	3105	3108	3105
query98	249	236	228	228
query99	1632	1330	1311	1311
Total cold run time: 329141 ms
Total hot run time: 195890 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.75 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e878192195dae7871950ac455aab73c13d5e5e84, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.06
query4	1.66	0.09	0.07
query5	0.51	0.49	0.50
query6	1.14	0.72	0.72
query7	0.03	0.02	0.01
query8	0.05	0.05	0.06
query9	0.55	0.51	0.51
query10	0.56	0.56	0.55
query11	0.17	0.13	0.12
query12	0.16	0.14	0.14
query13	0.61	0.62	0.60
query14	0.79	0.79	0.79
query15	0.86	0.83	0.83
query16	0.38	0.38	0.37
query17	1.06	1.02	1.06
query18	0.24	0.23	0.23
query19	1.78	1.87	1.76
query20	0.02	0.01	0.01
query21	15.39	0.85	0.65
query22	4.18	7.52	2.33
query23	18.33	1.36	1.29
query24	2.12	0.23	0.23
query25	0.16	0.09	0.08
query26	0.30	0.21	0.21
query27	0.46	0.24	0.23
query28	13.23	1.03	1.01
query29	12.66	3.35	3.35
query30	0.38	0.20	0.20
query31	2.83	0.40	0.41
query32	3.23	0.48	0.50
query33	2.94	2.94	2.90
query34	17.13	4.37	4.38
query35	4.43	4.44	4.42
query36	0.67	0.50	0.52
query37	0.21	0.18	0.17
query38	0.17	0.16	0.16
query39	0.06	0.05	0.06
query40	0.18	0.15	0.15
query41	0.12	0.07	0.06
query42	0.07	0.06	0.06
query43	0.07	0.06	0.05
Total cold run time: 110.25 s
Total hot run time: 31.75 s

Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 19, 2024
@morningman morningman merged commit 21b3228 into apache:master Aug 19, 2024
28 checks passed
morningman added a commit to morningman/doris that referenced this pull request Aug 20, 2024
Followup apache#38525
Previously, we use sequence number to generate partition id of table in
hive metastore.
for example, there are 2 partitions: `dt=2024-10-02` and
`dt=2024-10-03`, the partition id will be 0 and 1.
But if a new partition being added: `dt=2024-10-01`, the partiton id
will be 0, 1, and 2.
You can see, before, the id `0` is for `dt=2024-10-02`, but now `0` is
for `dt=2024-10-01`.

This PR use catalog/db/table/partition name to generate a id for the
partition,
so that each partition will have unique id.
dataroaring pushed a commit that referenced this pull request Aug 26, 2024
Followup #38525
Previously, we use sequence number to generate partition id of table in
hive metastore.
for example, there are 2 partitions: `dt=2024-10-02` and
`dt=2024-10-03`, the partition id will be 0 and 1.
But if a new partition being added: `dt=2024-10-01`, the partiton id
will be 0, 1, and 2.
You can see, before, the id `0` is for `dt=2024-10-02`, but now `0` is
for `dt=2024-10-01`.

This PR use catalog/db/table/partition name to generate a id for the
partition,
so that each partition will have unique id.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants