Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](load) Fix the incorrect src value printed in the error log when strict mode is true #39447

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

liaoxin01
Copy link
Contributor

@liaoxin01 liaoxin01 commented Aug 15, 2024

When there is a column order mapping, an incorrect src value will be printed because the wrong column was used.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@liaoxin01
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 15, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39412 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 00d200451387ba4cafefccdf686e1fbb1a7e085b, data reload: false

------ Round 1 ----------------------------------
q1	18220	4664	4583	4583
q2	2054	208	216	208
q3	10416	1331	1246	1246
q4	10156	770	767	767
q5	7820	2999	2912	2912
q6	290	159	158	158
q7	1078	652	645	645
q8	9380	2146	2139	2139
q9	7478	6875	6842	6842
q10	7148	2277	2273	2273
q11	522	261	261	261
q12	461	259	248	248
q13	17784	3004	2951	2951
q14	300	249	251	249
q15	564	516	505	505
q16	527	399	403	399
q17	1009	662	736	662
q18	7569	7021	6856	6856
q19	7437	1125	1131	1125
q20	737	369	366	366
q21	4495	3380	3000	3000
q22	1121	1023	1017	1017
Total cold run time: 116566 ms
Total hot run time: 39412 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4740	4451	4516	4451
q2	442	301	299	299
q3	2914	2623	2665	2623
q4	1992	1666	1661	1661
q5	5457	5490	5508	5490
q6	268	152	150	150
q7	2170	1694	1740	1694
q8	3443	3604	3643	3604
q9	8524	8530	8508	8508
q10	3487	3320	3219	3219
q11	635	517	541	517
q12	808	614	649	614
q13	17587	2990	3007	2990
q14	327	290	304	290
q15	580	508	508	508
q16	502	452	432	432
q17	1923	1561	1521	1521
q18	7857	7990	7464	7464
q19	1857	1790	1648	1648
q20	2105	1857	1789	1789
q21	11552	5264	5268	5264
q22	1136	1060	1060	1060
Total cold run time: 80306 ms
Total hot run time: 55796 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190094 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 00d200451387ba4cafefccdf686e1fbb1a7e085b, data reload: false

query1	997	393	393	393
query2	6766	2012	2046	2012
query3	6666	230	243	230
query4	33595	23699	23253	23253
query5	4411	657	642	642
query6	320	189	191	189
query7	4608	316	311	311
query8	401	354	355	354
query9	8575	2496	2461	2461
query10	492	322	329	322
query11	17185	14957	15116	14957
query12	179	122	124	122
query13	1692	416	414	414
query14	9698	6794	6772	6772
query15	241	184	188	184
query16	7949	525	517	517
query17	1594	600	579	579
query18	2095	336	331	331
query19	218	171	166	166
query20	146	133	132	132
query21	261	146	142	142
query22	4275	4045	4052	4045
query23	33982	33252	33306	33252
query24	11591	2995	2892	2892
query25	675	432	415	415
query26	1363	180	182	180
query27	2755	298	305	298
query28	7511	2116	2118	2116
query29	926	452	440	440
query30	343	187	187	187
query31	1053	805	850	805
query32	121	77	80	77
query33	818	357	344	344
query34	925	510	508	508
query35	951	800	780	780
query36	1096	944	941	941
query37	176	105	111	105
query38	3914	3820	3745	3745
query39	1521	1471	1498	1471
query40	304	161	155	155
query41	140	139	137	137
query42	128	114	121	114
query43	560	508	502	502
query44	1315	792	788	788
query45	219	192	202	192
query46	1151	782	757	757
query47	1934	1799	1824	1799
query48	442	353	349	349
query49	1264	583	587	583
query50	875	468	467	467
query51	6870	6748	6712	6712
query52	121	108	114	108
query53	303	225	229	225
query54	1005	543	503	503
query55	88	91	90	90
query56	339	308	322	308
query57	1240	1145	1100	1100
query58	323	323	308	308
query59	3043	2927	2797	2797
query60	378	328	337	328
query61	152	149	148	148
query62	893	690	735	690
query63	270	230	232	230
query64	5420	2429	1899	1899
query65	3236	3140	3154	3140
query66	1281	676	667	667
query67	15543	15057	15216	15057
query68	6519	578	593	578
query69	728	426	342	342
query70	1233	1166	1165	1165
query71	558	319	313	313
query72	7702	2356	2015	2015
query73	879	358	362	358
query74	9226	8686	8835	8686
query75	5031	2763	2749	2749
query76	4751	1072	1114	1072
query77	898	450	439	439
query78	11027	10041	9177	9177
query79	9017	552	550	550
query80	1052	618	629	618
query81	681	256	259	256
query82	479	158	161	158
query83	393	211	207	207
query84	291	94	107	94
query85	798	355	351	351
query86	427	324	318	318
query87	4409	4150	4226	4150
query88	4703	2544	2531	2531
query89	456	328	321	321
query90	2067	228	223	223
query91	151	126	124	124
query92	90	75	75	75
query93	3911	553	553	553
query94	923	313	295	295
query95	396	293	293	293
query96	620	287	287	287
query97	3257	3040	3025	3025
query98	261	230	227	227
query99	1695	1307	1364	1307
Total cold run time: 315551 ms
Total hot run time: 190094 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.4 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 00d200451387ba4cafefccdf686e1fbb1a7e085b, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.05	0.05
query3	0.23	0.05	0.05
query4	1.66	0.08	0.07
query5	0.49	0.48	0.48
query6	1.14	0.73	0.74
query7	0.02	0.02	0.02
query8	0.05	0.05	0.05
query9	0.56	0.49	0.48
query10	0.56	0.55	0.56
query11	0.15	0.12	0.11
query12	0.16	0.12	0.13
query13	0.61	0.61	0.60
query14	0.76	0.77	0.78
query15	0.86	0.83	0.81
query16	0.34	0.38	0.38
query17	0.96	0.97	0.95
query18	0.22	0.22	0.22
query19	1.79	1.74	1.73
query20	0.01	0.01	0.02
query21	15.42	0.86	0.68
query22	4.14	6.53	2.31
query23	18.26	1.37	1.21
query24	2.13	0.23	0.23
query25	0.14	0.08	0.10
query26	0.30	0.21	0.20
query27	0.46	0.23	0.23
query28	13.20	1.03	1.00
query29	12.60	3.33	3.36
query30	0.37	0.18	0.19
query31	2.81	0.39	0.40
query32	3.26	0.51	0.48
query33	2.98	2.98	2.96
query34	17.03	4.33	4.36
query35	4.39	4.38	4.37
query36	0.67	0.49	0.49
query37	0.19	0.17	0.18
query38	0.17	0.16	0.16
query39	0.06	0.06	0.06
query40	0.18	0.15	0.14
query41	0.12	0.07	0.06
query42	0.08	0.07	0.06
query43	0.07	0.06	0.06
Total cold run time: 109.72 s
Total hot run time: 31.4 s

@dataroaring dataroaring merged commit e375fc1 into apache:master Aug 16, 2024
28 of 32 checks passed
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
… strict mode is true (#39447)

When there is a column order mapping, an incorrect src value will be
printed because the wrong column was used.
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Aug 20, 2024
… strict mode is true (apache#39447)

When there is a column order mapping, an incorrect src value will be
printed because the wrong column was used.
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Aug 20, 2024
… strict mode is true (apache#39447)

When there is a column order mapping, an incorrect src value will be
printed because the wrong column was used.
dataroaring pushed a commit that referenced this pull request Aug 20, 2024
dataroaring pushed a commit that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants