[Fix](Variant) variant fallthrough with inverted index #40069

eldenmoon · 2024-08-28T12:32:52Z

When reading from segment, the schema type is variant, if we check type valid in get_inverted_index, the result should always return nullptr(since variant type it self does not support inverted index), but the actual storage could be string or etc.So we should ignore the type check and return the correct inverted index iterators

introduced by #36163

Proposed changes

Issue Number: close #xxx

doris-robot · 2024-08-28T12:32:57Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

eldenmoon · 2024-08-28T12:32:59Z

run buildall

github-actions · 2024-08-28T12:40:00Z

clang-tidy review says "All clean, LGTM! 👍"

airborne12

LGTM

github-actions · 2024-08-28T12:41:12Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-08-28T12:41:15Z

PR approved by anyone and no changes requested.

doris-robot · 2024-08-28T13:11:03Z

TPC-H: Total hot run time: 37653 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9c29378ffad18b9ff1771d05ae7e9a45a2c16473, data reload: false

------ Round 1 ----------------------------------
q1	17614	4415	4284	4284
q2	2015	179	177	177
q3	11683	963	1131	963
q4	10515	686	904	686
q5	7758	2833	2829	2829
q6	226	137	138	137
q7	962	611	594	594
q8	9531	2063	2092	2063
q9	7429	6568	6572	6568
q10	6978	2193	2219	2193
q11	457	242	240	240
q12	396	227	227	227
q13	17782	3047	3086	3047
q14	274	226	230	226
q15	518	474	501	474
q16	583	513	490	490
q17	976	706	639	639
q18	7291	6882	6795	6795
q19	1398	980	934	934
q20	679	349	337	337
q21	3937	3138	2747	2747
q22	1131	1003	1019	1003
Total cold run time: 110133 ms
Total hot run time: 37653 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4365	4319	4264	4264
q2	387	279	272	272
q3	2867	2702	2650	2650
q4	1938	1635	1666	1635
q5	5582	5786	5752	5752
q6	223	136	141	136
q7	2200	1849	1801	1801
q8	3311	3417	3514	3417
q9	8823	8758	8756	8756
q10	3597	3437	3356	3356
q11	606	519	524	519
q12	856	680	663	663
q13	13373	3166	3214	3166
q14	340	292	305	292
q15	533	502	498	498
q16	612	574	565	565
q17	1839	1588	1542	1542
q18	8195	7874	7863	7863
q19	1732	1661	1521	1521
q20	2138	1907	1901	1901
q21	5760	5438	5514	5438
q22	1148	1069	1050	1050
Total cold run time: 70425 ms
Total hot run time: 57057 ms

doris-robot · 2024-08-28T13:23:20Z

TPC-DS: Total hot run time: 193332 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9c29378ffad18b9ff1771d05ae7e9a45a2c16473, data reload: false

query1	1242	900	866	866
query2	6357	1982	1857	1857
query3	10604	3947	3938	3938
query4	59605	26986	23400	23400
query5	5451	498	499	498
query6	416	164	174	164
query7	5786	301	306	301
query8	278	211	196	196
query9	9111	2504	2494	2494
query10	479	277	265	265
query11	18202	14993	15345	14993
query12	157	100	102	100
query13	1552	426	383	383
query14	11145	7033	7515	7033
query15	236	176	184	176
query16	7159	485	491	485
query17	1146	581	556	556
query18	1990	300	300	300
query19	281	147	162	147
query20	118	112	112	112
query21	207	111	107	107
query22	4514	4463	4603	4463
query23	34103	33685	33502	33502
query24	5983	2917	2892	2892
query25	528	380	390	380
query26	695	176	159	159
query27	1773	282	281	281
query28	3779	2120	2098	2098
query29	661	409	407	407
query30	238	153	152	152
query31	915	761	783	761
query32	86	56	58	56
query33	443	289	293	289
query34	860	500	480	480
query35	849	704	710	704
query36	1075	935	963	935
query37	147	101	100	100
query38	4048	3859	3901	3859
query39	1444	1386	1413	1386
query40	189	118	121	118
query41	49	46	47	46
query42	116	102	98	98
query43	506	468	481	468
query44	1086	751	760	751
query45	196	169	173	169
query46	1105	768	769	768
query47	1884	1825	1855	1825
query48	370	295	294	294
query49	779	444	452	444
query50	820	407	423	407
query51	7121	7198	7077	7077
query52	101	91	88	88
query53	257	187	178	178
query54	578	464	470	464
query55	79	85	84	84
query56	305	265	274	265
query57	1189	1073	1064	1064
query58	230	236	231	231
query59	3029	2751	2727	2727
query60	303	289	284	284
query61	125	120	116	116
query62	738	678	659	659
query63	224	188	188	188
query64	2945	762	743	743
query65	3246	3146	3177	3146
query66	698	351	344	344
query67	15474	15263	15230	15230
query68	3003	602	583	583
query69	410	285	291	285
query70	1178	1058	1128	1058
query71	356	286	284	284
query72	6328	4184	4019	4019
query73	752	338	333	333
query74	9192	8954	8862	8862
query75	3334	2696	2691	2691
query76	1452	939	1003	939
query77	513	326	326	326
query78	11482	9424	9069	9069
query79	1243	553	525	525
query80	900	521	515	515
query81	555	233	239	233
query82	257	188	147	147
query83	192	151	153	151
query84	263	74	77	74
query85	713	297	305	297
query86	396	288	298	288
query87	4423	4238	4270	4238
query88	3015	2346	2333	2333
query89	381	281	285	281
query90	1972	195	194	194
query91	124	103	101	101
query92	61	87	57	57
query93	1073	538	545	538
query94	762	300	274	274
query95	360	270	262	262
query96	584	264	275	264
query97	3196	3106	3135	3106
query98	231	203	215	203
query99	1564	1251	1292	1251
Total cold run time: 307670 ms
Total hot run time: 193332 ms

doris-robot · 2024-08-28T13:28:57Z

ClickBench: Total hot run time: 32.28 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9c29378ffad18b9ff1771d05ae7e9a45a2c16473, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.05	0.05
query3	0.22	0.05	0.05
query4	1.67	0.08	0.07
query5	0.51	0.49	0.51
query6	1.13	0.73	0.73
query7	0.01	0.01	0.01
query8	0.06	0.05	0.05
query9	0.54	0.48	0.49
query10	0.54	0.55	0.56
query11	0.15	0.11	0.11
query12	0.16	0.12	0.13
query13	0.61	0.59	0.58
query14	2.01	2.04	2.06
query15	0.84	0.82	0.82
query16	0.37	0.39	0.38
query17	1.07	1.00	1.05
query18	0.20	0.21	0.21
query19	1.88	1.79	1.80
query20	0.01	0.01	0.01
query21	15.39	0.69	0.67
query22	3.92	7.13	2.10
query23	18.26	1.45	1.30
query24	2.06	0.24	0.22
query25	0.16	0.08	0.09
query26	0.26	0.18	0.18
query27	0.07	0.07	0.08
query28	13.19	1.03	1.00
query29	12.66	3.31	3.28
query30	0.24	0.05	0.05
query31	2.89	0.40	0.38
query32	3.26	0.48	0.48
query33	2.95	3.03	3.01
query34	16.92	4.42	4.38
query35	4.46	4.46	4.42
query36	0.66	0.49	0.50
query37	0.19	0.16	0.15
query38	0.16	0.15	0.16
query39	0.05	0.04	0.04
query40	0.16	0.12	0.13
query41	0.09	0.06	0.05
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.23 s
Total hot run time: 32.28 s

csun5285

LGTM

eldenmoon · 2024-08-28T14:10:11Z

run buildall

When reading from segment, the schema type is variant, if we check type valid in `get_inverted_index`, the result should always return nullptr(since variant type it self does not support inverted index), but the actual storage could be `string` or etc.So we should ignore the type check and return the correct inverted index iterators

github-actions · 2024-08-28T14:17:50Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-08-28T14:29:58Z

TPC-H: Total hot run time: 38687 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 56eaf8ac41e6ba67144df153205ab08f11cc8062, data reload: false

------ Round 1 ----------------------------------
q1	17802	4501	4413	4413
q2	2650	201	186	186
q3	12171	1132	1114	1114
q4	10800	717	741	717
q5	7831	2904	2886	2886
q6	230	143	145	143
q7	972	624	601	601
q8	9352	2092	2077	2077
q9	7097	6560	6554	6554
q10	7024	2210	2216	2210
q11	448	249	253	249
q12	403	238	233	233
q13	18425	3058	3094	3058
q14	290	238	239	238
q15	531	502	501	501
q16	584	520	523	520
q17	1006	684	662	662
q18	7450	6907	6866	6866
q19	1391	1058	1012	1012
q20	680	345	341	341
q21	3979	3097	3162	3097
q22	1151	1009	1015	1009
Total cold run time: 112267 ms
Total hot run time: 38687 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4394	4343	4274	4274
q2	387	277	277	277
q3	2881	2683	2664	2664
q4	1964	1694	1685	1685
q5	5407	5410	5443	5410
q6	227	137	137	137
q7	2145	1755	1774	1755
q8	3233	3409	3374	3374
q9	8421	8438	8459	8438
q10	3482	3191	3197	3191
q11	589	488	490	488
q12	783	618	584	584
q13	12788	3055	3063	3055
q14	310	280	284	280
q15	537	487	469	469
q16	605	550	557	550
q17	1783	1524	1481	1481
q18	7685	7428	7461	7428
q19	1688	1654	1563	1563
q20	2052	1827	1792	1792
q21	5523	5236	5296	5236
q22	1114	1031	1042	1031
Total cold run time: 67998 ms
Total hot run time: 55162 ms

doris-robot · 2024-08-28T14:41:40Z

TPC-DS: Total hot run time: 188171 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 56eaf8ac41e6ba67144df153205ab08f11cc8062, data reload: false

query1	915	378	367	367
query2	6470	2032	1942	1942
query3	6647	214	225	214
query4	30727	23300	23188	23188
query5	4135	490	497	490
query6	258	169	164	164
query7	4581	298	289	289
query8	246	207	223	207
query9	8467	2504	2502	2502
query10	455	287	270	270
query11	17909	14971	15165	14971
query12	166	102	98	98
query13	1616	381	379	379
query14	9463	7212	7182	7182
query15	264	168	177	168
query16	7998	469	478	469
query17	1590	560	548	548
query18	2022	289	288	288
query19	254	143	142	142
query20	115	112	109	109
query21	218	108	104	104
query22	4533	4037	4077	4037
query23	34285	33326	33228	33228
query24	11169	2862	2886	2862
query25	626	382	390	382
query26	1111	159	166	159
query27	2324	292	277	277
query28	7317	2135	2113	2113
query29	782	421	419	419
query30	305	158	151	151
query31	988	767	785	767
query32	100	58	59	58
query33	756	283	279	279
query34	991	489	486	486
query35	856	723	711	711
query36	1098	946	944	944
query37	162	97	98	97
query38	3990	3781	3811	3781
query39	1496	1398	1387	1387
query40	208	119	121	119
query41	50	49	47	47
query42	117	100	101	100
query43	508	478	500	478
query44	1232	759	741	741
query45	199	168	165	165
query46	1102	731	741	731
query47	1890	1797	1806	1797
query48	378	299	301	299
query49	1096	428	418	418
query50	801	407	425	407
query51	7215	7134	7055	7055
query52	102	91	89	89
query53	260	187	180	180
query54	987	472	468	468
query55	80	80	77	77
query56	290	258	260	258
query57	1148	1081	1065	1065
query58	254	221	223	221
query59	3022	2827	2832	2827
query60	310	283	280	280
query61	126	124	124	124
query62	832	681	679	679
query63	220	198	187	187
query64	4264	781	768	768
query65	3262	3127	3132	3127
query66	1404	357	370	357
query67	15586	15052	15602	15052
query68	3542	585	581	581
query69	408	290	293	290
query70	1178	1114	1091	1091
query71	338	279	279	279
query72	6516	3925	4104	3925
query73	759	331	342	331
query74	9216	8884	8888	8884
query75	3441	2715	2684	2684
query76	2143	1016	979	979
query77	518	331	326	326
query78	9804	9000	9030	9000
query79	1148	550	543	543
query80	1228	550	545	545
query81	589	241	239	239
query82	1092	156	154	154
query83	224	169	164	164
query84	229	82	82	82
query85	1404	349	286	286
query86	384	303	298	298
query87	4363	4239	4256	4239
query88	2975	2354	2355	2354
query89	389	288	288	288
query90	1810	196	197	196
query91	126	106	133	106
query92	64	53	52	52
query93	1076	555	541	541
query94	958	305	307	305
query95	365	258	268	258
query96	587	276	274	274
query97	3226	3068	3063	3063
query98	215	214	204	204
query99	1505	1307	1265	1265
Total cold run time: 286168 ms
Total hot run time: 188171 ms

doris-robot · 2024-08-28T14:47:14Z

ClickBench: Total hot run time: 32.21 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 56eaf8ac41e6ba67144df153205ab08f11cc8062, data reload: false

query1	0.05	0.04	0.05
query2	0.08	0.04	0.04
query3	0.22	0.06	0.06
query4	1.65	0.11	0.10
query5	0.50	0.49	0.50
query6	1.13	0.74	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.55	0.50	0.49
query10	0.54	0.55	0.53
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.59	0.59
query14	2.04	2.07	2.06
query15	0.89	0.82	0.82
query16	0.38	0.38	0.39
query17	1.03	1.05	1.01
query18	0.22	0.21	0.21
query19	1.97	1.80	1.74
query20	0.01	0.01	0.02
query21	15.42	0.67	0.66
query22	4.33	7.44	1.94
query23	18.33	1.43	1.32
query24	2.14	0.24	0.23
query25	0.15	0.08	0.08
query26	0.26	0.18	0.17
query27	0.09	0.08	0.07
query28	13.23	1.03	0.99
query29	12.60	3.34	3.33
query30	0.25	0.06	0.06
query31	2.88	0.40	0.40
query32	3.25	0.50	0.47
query33	3.00	2.99	3.04
query34	17.01	4.39	4.37
query35	4.46	4.47	4.50
query36	0.66	0.46	0.49
query37	0.19	0.18	0.17
query38	0.17	0.16	0.16
query39	0.05	0.04	0.04
query40	0.16	0.12	0.12
query41	0.09	0.05	0.05
query42	0.05	0.04	0.05
query43	0.05	0.05	0.04
Total cold run time: 111.06 s
Total hot run time: 32.21 s

eldenmoon · 2024-08-28T15:06:38Z

run buildall

github-actions · 2024-08-28T15:13:12Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-08-28T15:46:01Z

TPC-H: Total hot run time: 37978 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d27d928608d17ab95238b4b04aa57ffd5b56636c, data reload: false

------ Round 1 ----------------------------------
q1	17637	4408	4315	4315
q2	2017	183	173	173
q3	11923	957	1012	957
q4	10520	698	781	698
q5	7742	2838	2845	2838
q6	224	137	140	137
q7	958	606	588	588
q8	9335	2061	2054	2054
q9	7174	6593	6579	6579
q10	7004	2232	2243	2232
q11	451	241	240	240
q12	393	221	222	221
q13	18874	3044	3035	3035
q14	275	238	229	229
q15	521	487	480	480
q16	580	511	513	511
q17	981	698	684	684
q18	7396	6768	6881	6768
q19	1381	1140	1061	1061
q20	671	348	324	324
q21	4119	2815	2884	2815
q22	1134	1043	1039	1039
Total cold run time: 111310 ms
Total hot run time: 37978 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4322	4245	4244	4244
q2	376	268	282	268
q3	2843	2678	2613	2613
q4	1943	1700	1683	1683
q5	5630	5691	5722	5691
q6	229	131	133	131
q7	2230	1818	1819	1818
q8	3270	3414	3419	3414
q9	8868	8853	8815	8815
q10	3590	3342	3370	3342
q11	621	508	533	508
q12	813	659	663	659
q13	14309	3226	3178	3178
q14	313	281	291	281
q15	534	484	485	484
q16	655	566	579	566
q17	1823	1532	1533	1532
q18	8102	7828	7965	7828
q19	1734	1649	1625	1625
q20	2183	1907	1957	1907
q21	5771	5528	5545	5528
q22	1163	1075	1036	1036
Total cold run time: 71322 ms
Total hot run time: 57151 ms

doris-robot · 2024-08-28T15:58:18Z

TPC-DS: Total hot run time: 193961 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d27d928608d17ab95238b4b04aa57ffd5b56636c, data reload: false

query1	1326	880	863	863
query2	6308	1955	1912	1912
query3	10741	4231	3896	3896
query4	59788	24181	23590	23590
query5	5319	502	514	502
query6	400	163	173	163
query7	5748	305	300	300
query8	279	208	204	204
query9	8861	2508	2485	2485
query10	483	293	264	264
query11	18047	15204	15269	15204
query12	150	106	107	106
query13	1571	405	385	385
query14	10820	7414	7564	7414
query15	231	177	184	177
query16	7580	474	469	469
query17	1139	597	559	559
query18	2033	295	305	295
query19	286	153	145	145
query20	119	113	120	113
query21	212	112	104	104
query22	4603	4474	4319	4319
query23	34421	33682	33426	33426
query24	5990	2829	2846	2829
query25	528	375	377	375
query26	675	173	166	166
query27	1741	282	285	282
query28	3919	2121	2114	2114
query29	714	405	403	403
query30	240	153	154	153
query31	940	792	784	784
query32	80	55	59	55
query33	464	288	307	288
query34	890	483	485	483
query35	856	783	754	754
query36	1087	948	924	924
query37	155	96	95	95
query38	4006	3986	3934	3934
query39	1425	1420	1390	1390
query40	202	117	114	114
query41	46	47	45	45
query42	115	97	96	96
query43	511	477	473	473
query44	1116	744	752	744
query45	203	173	169	169
query46	1120	784	762	762
query47	1886	1791	1835	1791
query48	377	305	311	305
query49	772	456	454	454
query50	826	436	428	428
query51	7163	7084	6984	6984
query52	100	94	94	94
query53	269	187	188	187
query54	592	468	468	468
query55	83	79	80	79
query56	295	264	277	264
query57	1187	1083	1094	1083
query58	236	240	229	229
query59	2931	2871	2840	2840
query60	312	287	286	286
query61	126	121	119	119
query62	775	639	679	639
query63	217	194	193	193
query64	2856	788	719	719
query65	3259	3196	3169	3169
query66	702	360	356	356
query67	15550	15272	15056	15056
query68	3027	601	596	596
query69	410	290	291	290
query70	1203	1168	1075	1075
query71	359	286	290	286
query72	6407	4235	4174	4174
query73	769	342	346	342
query74	9361	8844	8789	8789
query75	3483	2668	2691	2668
query76	1419	997	999	997
query77	537	375	329	329
query78	9821	8960	9037	8960
query79	1386	556	548	548
query80	971	530	527	527
query81	561	237	239	237
query82	247	143	144	143
query83	188	148	148	148
query84	261	72	79	72
query85	888	287	304	287
query86	421	282	268	268
query87	4507	4319	4271	4271
query88	3333	2343	2346	2343
query89	393	287	287	287
query90	1869	195	196	195
query91	123	101	100	100
query92	60	54	50	50
query93	2035	544	546	544
query94	874	313	294	294
query95	359	276	267	267
query96	604	271	272	271
query97	3202	3100	3077	3077
query98	220	205	200	200
query99	1823	1310	1256	1256
Total cold run time: 309123 ms
Total hot run time: 193961 ms

doris-robot · 2024-08-28T16:03:57Z

ClickBench: Total hot run time: 31.56 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d27d928608d17ab95238b4b04aa57ffd5b56636c, data reload: false

query1	0.05	0.05	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.49	0.49	0.50
query6	1.14	0.74	0.73
query7	0.02	0.01	0.02
query8	0.05	0.05	0.05
query9	0.55	0.49	0.48
query10	0.56	0.54	0.55
query11	0.16	0.12	0.12
query12	0.16	0.13	0.13
query13	0.62	0.59	0.59
query14	2.03	2.04	2.07
query15	0.85	0.82	0.82
query16	0.37	0.37	0.38
query17	1.07	1.03	1.04
query18	0.22	0.20	0.20
query19	1.95	1.77	1.85
query20	0.02	0.01	0.01
query21	15.98	0.68	0.67
query22	5.03	7.79	1.29
query23	18.19	1.48	1.33
query24	2.09	0.23	0.23
query25	0.16	0.08	0.08
query26	0.27	0.18	0.17
query27	0.08	0.08	0.07
query28	13.28	1.03	1.01
query29	12.60	3.36	3.32
query30	0.25	0.05	0.06
query31	2.86	0.40	0.39
query32	3.27	0.48	0.48
query33	2.97	2.95	3.03
query34	17.20	4.43	4.42
query35	4.49	4.52	4.46
query36	0.66	0.48	0.47
query37	0.18	0.16	0.15
query38	0.16	0.15	0.14
query39	0.04	0.04	0.04
query40	0.16	0.12	0.12
query41	0.11	0.05	0.04
query42	0.05	0.05	0.05
query43	0.04	0.04	0.05
Total cold run time: 112.41 s
Total hot run time: 31.56 s

backport #40069

github-actions · 2024-08-29T02:37:17Z

PR approved by at least one committer and no changes requested.

When reading from segment, the schema type is variant, if we check type valid in `get_inverted_index`, the result should always return nullptr(since variant type it self does not support inverted index), but the actual storage could be `string` or etc.So we should ignore the type check and return the correct inverted index iterators introduced by apache#36163

#40069

eldenmoon added dev/2.1.x dev/3.0.x labels Aug 28, 2024

airborne12 previously approved these changes Aug 28, 2024

View reviewed changes

github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 28, 2024

eldenmoon mentioned this pull request Aug 28, 2024

[pick](Variant) variant fallthrough with inverted index #40070

Merged

csun5285 approved these changes Aug 28, 2024

View reviewed changes

fix

d27d928

eldenmoon dismissed airborne12’s stale review via d27d928 August 28, 2024 15:06

eldenmoon force-pushed the fix-var-inv branch from 56eaf8a to d27d928 Compare August 28, 2024 15:06

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 28, 2024

yiguolei pushed a commit that referenced this pull request Aug 28, 2024

[pick](Variant) variant fallthrough with inverted index (#40070)

c3c6a4f

backport #40069

yiguolei added dev/2.1.6-merged and removed dev/2.1.x labels Aug 28, 2024

qidaye approved these changes Aug 29, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 29, 2024

eldenmoon merged commit 964c33d into apache:master Aug 29, 2024
27 of 29 checks passed

dataroaring added the dev/3.0.x-conflict label Sep 3, 2024

eldenmoon mentioned this pull request Sep 3, 2024

[Fix](Variant) variant fallthrough with inverted index (#40069) #40327

Merged

eldenmoon added a commit that referenced this pull request Sep 3, 2024

[Fix](Variant) variant fallthrough with inverted index (#40069) (#40327)

f2adb18

#40069

eldenmoon added dev/3.0.2-merged and removed dev/3.0.x dev/3.0.x-conflict labels Sep 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix](Variant) variant fallthrough with inverted index #40069

[Fix](Variant) variant fallthrough with inverted index #40069

eldenmoon commented Aug 28, 2024

doris-robot commented Aug 28, 2024

eldenmoon commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

airborne12 left a comment

github-actions bot commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

csun5285 left a comment

eldenmoon commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

eldenmoon commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

github-actions bot commented Aug 29, 2024

[Fix](Variant) variant fallthrough with inverted index #40069

[Fix](Variant) variant fallthrough with inverted index #40069

Conversation

eldenmoon commented Aug 28, 2024

Proposed changes

doris-robot commented Aug 28, 2024

eldenmoon commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

airborne12 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

csun5285 left a comment

Choose a reason for hiding this comment

eldenmoon commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

eldenmoon commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

doris-robot commented Aug 28, 2024

github-actions bot commented Aug 29, 2024