Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore](recycler) Change tablet_rowset_stale_sweep_time_sec=600 to reduce possibility failed to find rowset #40076

Merged
merged 2 commits into from
Sep 3, 2024
Merged

[chore](recycler) Change tablet_rowset_stale_sweep_time_sec=600 to reduce possibility failed to find rowset #40076

merged 2 commits into from
Sep 3, 2024

Conversation

gavinchou
Copy link
Collaborator

When there is a large query, the stale rowsets may be recycled before the query referencing them, which may cause -230, or import of MoW table failed to find rowset.

@gavinchou
[chore] Change tablet_rowset_stale_sweep_time_sec=600 to reduce possi…
9bb06c2 
…bility failed to find rowset

When there is a large query, the stale rowsets may be recycled before the query referencing them,
which may cause -230, or import of MoW table failed to find rowset.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@gavinchou gavinchou changed the title [chore] Change tablet_rowset_stale_sweep_time_sec=600 to reduce possibility failed to find rowset [chore](recycler) Change tablet_rowset_stale_sweep_time_sec=600 to reduce possibility failed to find rowset Aug 28, 2024
@gavinchou
Copy link
Collaborator Author

run buidlall

@gavinchou
Copy link
Collaborator Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou
Copy link
Collaborator Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

liaoxin01
liaoxin01 approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 38379 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4d0d206877736afee39790119c580231df6f89f8, data reload: false

------ Round 1 ----------------------------------
q1	17893	5455	4410	4410
q2	2995	182	170	170
q3	11863	1119	1055	1055
q4	10289	727	794	727
q5	7928	2866	2831	2831
q6	231	155	142	142
q7	959	615	601	601
q8	9327	2074	2010	2010
q9	7081	6574	6545	6545
q10	6990	2218	2219	2218
q11	455	242	243	242
q12	393	235	223	223
q13	18097	3041	3010	3010
q14	283	255	245	245
q15	532	496	500	496
q16	585	497	504	497
q17	953	663	746	663
q18	7311	6950	6890	6890
q19	1397	1107	1071	1071
q20	689	330	333	330
q21	3930	2977	2983	2977
q22	1129	1053	1026	1026
Total cold run time: 111310 ms
Total hot run time: 38379 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4354	4348	4292	4292
q2	394	275	281	275
q3	2860	2660	2646	2646
q4	1932	1632	1632	1632
q5	5381	5378	5402	5378
q6	224	131	130	130
q7	2095	1733	1793	1733
q8	3185	3324	3343	3324
q9	8434	8440	8375	8375
q10	3495	3220	3199	3199
q11	600	497	501	497
q12	804	623	624	623
q13	10328	3025	3041	3025
q14	311	277	277	277
q15	541	494	499	494
q16	632	574	543	543
q17	1782	1488	1476	1476
q18	7792	7458	7412	7412
q19	1644	1571	1582	1571
q20	2076	1850	1829	1829
q21	5538	5362	5137	5137
q22	1131	1045	1022	1022
Total cold run time: 65533 ms
Total hot run time: 54890 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188123 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4d0d206877736afee39790119c580231df6f89f8, data reload: false

query1	916	378	360	360
query2	6467	2055	1950	1950
query3	6645	209	247	209
query4	34190	23150	23113	23113
query5	4203	504	492	492
query6	249	166	163	163
query7	4576	299	290	290
query8	253	206	209	206
query9	8605	2500	2503	2500
query10	447	265	269	265
query11	17837	14995	14985	14985
query12	147	99	97	97
query13	1638	410	365	365
query14	9817	7447	7291	7291
query15	272	172	178	172
query16	7985	462	506	462
query17	1596	581	560	560
query18	1936	294	288	288
query19	279	150	150	150
query20	115	114	113	113
query21	211	107	105	105
query22	4465	4433	4171	4171
query23	34045	33283	33426	33283
query24	11187	2878	2825	2825
query25	645	406	403	403
query26	1139	158	159	158
query27	2748	284	279	279
query28	7433	2163	2132	2132
query29	829	431	422	422
query30	290	154	155	154
query31	987	764	816	764
query32	94	60	73	60
query33	765	294	295	294
query34	947	466	496	466
query35	872	776	693	693
query36	1099	911	950	911
query37	166	103	97	97
query38	3977	3803	3891	3803
query39	1531	1417	1388	1388
query40	209	120	119	119
query41	51	49	48	48
query42	120	97	99	97
query43	525	484	477	477
query44	1208	769	747	747
query45	203	174	172	172
query46	1085	766	736	736
query47	1887	1822	1791	1791
query48	393	302	299	299
query49	1173	434	425	425
query50	807	404	409	404
query51	7277	7040	7020	7020
query52	95	89	88	88
query53	252	189	185	185
query54	910	468	453	453
query55	77	78	79	78
query56	274	250	257	250
query57	1185	1081	1056	1056
query58	247	222	231	222
query59	3086	2883	2833	2833
query60	289	267	262	262
query61	100	100	98	98
query62	844	674	657	657
query63	214	184	182	182
query64	4199	673	671	671
query65	3209	3151	3157	3151
query66	966	333	340	333
query67	15717	15544	15197	15197
query68	4627	564	557	557
query69	428	280	272	272
query70	1203	1094	1082	1082
query71	339	282	267	267
query72	6655	4095	4095	4095
query73	741	331	330	330
query74	9183	8931	8834	8834
query75	3403	2615	2700	2615
query76	2705	987	966	966
query77	497	316	312	312
query78	10552	9115	9587	9115
query79	1501	536	547	536
query80	1048	510	501	501
query81	562	234	241	234
query82	1131	139	146	139
query83	225	150	151	150
query84	223	82	77	77
query85	1213	336	275	275
query86	376	289	294	289
query87	4419	4221	4262	4221
query88	2959	2307	2275	2275
query89	385	290	293	290
query90	1810	197	195	195
query91	124	101	101	101
query92	65	49	53	49
query93	1059	552	534	534
query94	928	279	295	279
query95	351	261	254	254
query96	579	273	271	271
query97	3236	3080	3065	3065
query98	214	208	198	198
query99	1476	1288	1255	1255
Total cold run time: 292422 ms
Total hot run time: 188123 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.37 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4d0d206877736afee39790119c580231df6f89f8, data reload: false

query1	0.05	0.04	0.03
query2	0.07	0.03	0.04
query3	0.22	0.05	0.05
query4	1.67	0.07	0.07
query5	0.49	0.48	0.50
query6	1.13	0.74	0.73
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.56	0.49	0.48
query10	0.52	0.53	0.54
query11	0.15	0.12	0.12
query12	0.16	0.12	0.12
query13	0.61	0.59	0.58
query14	2.05	2.07	2.06
query15	0.86	0.82	0.81
query16	0.36	0.37	0.36
query17	1.01	0.96	0.97
query18	0.21	0.21	0.20
query19	1.83	1.86	1.76
query20	0.01	0.01	0.01
query21	15.42	0.66	0.65
query22	4.09	7.18	2.39
query23	18.29	1.36	1.22
query24	1.87	0.26	0.22
query25	0.16	0.09	0.08
query26	0.27	0.18	0.18
query27	0.08	0.08	0.07
query28	13.26	1.02	1.00
query29	12.89	3.34	3.33
query30	0.25	0.06	0.05
query31	2.89	0.41	0.40
query32	3.22	0.48	0.48
query33	2.99	2.98	3.05
query34	16.93	4.41	4.38
query35	4.46	4.46	4.50
query36	0.66	0.47	0.47
query37	0.18	0.17	0.15
query38	0.15	0.14	0.15
query39	0.06	0.04	0.04
query40	0.16	0.13	0.12
query41	0.10	0.04	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.05
Total cold run time: 110.52 s
Total hot run time: 32.37 s

gavinchou
gavinchou commented Sep 1, 2024
View reviewed changes
be/src/common/config.cpp
@@ -296,7 +296,7 @@ DEFINE_mInt32(default_num_rows_per_column_file_block, "1024");
// pending data policy
DEFINE_mInt32(pending_data_expire_time_sec, "1800");
// inc_rowset snapshot rs sweep time interval
DEFINE_mInt32(tablet_rowset_stale_sweep_time_sec, "300");
DEFINE_mInt32(tablet_rowset_stale_sweep_time_sec, "600");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou merged commit b9331b5 into apache:master Sep 3, 2024
28 of 30 checks passed
gavinchou added a commit that referenced this pull request Sep 5, 2024
@gavinchou
[chore](recycler) Change tablet_rowset_stale_sweep_time_sec=600 to re…
a64eaca 
…duce possibility failed to find rowset (#40076)

When there is a large query, the stale rowsets may be recycled before
the query referencing them, which may cause -230, or import of MoW table
failed to find rowset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes

@bobhan1 bobhan1 bobhan1 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gavinchou @doris-robot @liaoxin01 @bobhan1