Add delayed deletion of rowsets function, fix -230 error. #4039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuyunfeng
requested changes
Jul 7, 2020
be/src/olap/tablet.cpp
Outdated
| _rs_graph.construct_rowset_graph(_tablet_meta->all_rs_metas()); | ||
| // change _rs_graph to _versioned_rs_tracker | ||
| // _rs_graph.construct_rowset_graph(_tablet_meta->all_rs_metas()); | ||
| _versioned_rs_tracker.construct_versioned_tracker(_tablet_meta->all_rs_metas(), |
Member
There was a problem hiding this comment.
66 - 67 has nonstandard format
xy720
reviewed
Jul 7, 2020
ZhangYu0123
force-pushed
the
merged_rowset_delay_unused
branch
from
0f8d14d to
5eb43d3
Compare
morningman
added
area/storage
morningman
reviewed
Jul 7, 2020
| RETURN_NOT_OK(gc_unused_rowsets()); | ||
| TRACE("unused rowsets have been moved to GC queue"); | ||
| // RETURN_NOT_OK(gc_unused_rowsets()); | ||
| // TRACE("unused rowsets have been moved to GC queue"); |
be/src/olap/rowset_graph.cpp
Outdated
| } | ||
|
|
||
| void RowsetGraph::construct_rowset_graph(const std::vector<RowsetMetaSharedPtr>& rs_metas, | ||
| int64_t& max_version) { |
Contributor
There was a problem hiding this comment.
Suggested change
| int64_t& max_version) { | |
| int64_t* max_version) { |
Better to use point to indicate it is a output parameter.
be/src/olap/rowset_graph.h
Outdated
|
|
||
| /// RowsetGraph class which is implemented to build and maintain total versions of rowsets. | ||
| /// This class use adjacency-matrix represent rowsets version and links. A vertex is a version | ||
| /// and a link is the _version object of a rowset (from start version to end version). |
Contributor
There was a problem hiding this comment.
Suggested change
| /// and a link is the _version object of a rowset (from start version to end version). | |
| /// and a link is the _version object of a rowset (from start version to end version + 1). |
be/src/olap/rowset_graph.h
Outdated
| }; | ||
|
|
||
| } // namespace doris | ||
| /// VersionTracker class which is implemented to maintain compacted version path of rowsets. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// VersionTracker class which is implemented to maintain compacted version path of rowsets. | |
| /// VersionTracker class which is implemented to maintain multi-version path of rowsets. |
be/src/olap/rowset_graph.h
Outdated
| /// VersionedRowsetTracker class is responsible to track all rowsets version links of a tablet. | ||
| /// This class not only records the graph of all versions, but also records the paths which will be removed | ||
| /// after the path is expired. | ||
| class VersionedRowsetTracker { |
Contributor
There was a problem hiding this comment.
Suggested change
| class VersionedRowsetTracker { | |
| class TimestampedVersionTracker { |
be/src/olap/rowset_graph.cpp
Outdated
| // 2 remove this path from other_path | ||
| auto path_iter = path_version_ptr->begin(); | ||
| for (; path_iter != path_version_ptr->end(); path_iter++) { | ||
| Version version = (*path_iter)->version(); |
Contributor
There was a problem hiding this comment.
Suggested change
| Version version = (*path_iter)->version(); | |
| const Version& version = (*path_iter)->version(); |
be/src/olap/rowset_graph.cpp
Outdated
| _construct_versioned_tracker(rs_metas, expired_snapshot_rs_metas); | ||
| } | ||
|
|
||
| void VersionedRowsetTracker::reconstruct_versioned_tracker( |
Contributor
There was a problem hiding this comment.
Looks same as construct_versioned_tracker()
be/src/olap/rowset_graph.cpp
Outdated
|
|
||
| while (iter != _expired_snapshot_rs_path_map.end()) { | ||
| std::vector<VersionTrackerSharedPtr>::iterator version_path_iter = iter->second->begin(); | ||
| int64_t max_create_time = -1; |
Contributor
There was a problem hiding this comment.
I think we can save the max_create_time of a version path in _expired_snapshot_rs_path_map
be/src/olap/rowset_graph.cpp
Outdated
| } | ||
| } | ||
|
|
||
| void VersionedRowsetTracker::_print_current_state() { |
Contributor
There was a problem hiding this comment.
Better to return a string, and let the caller decide how to print it.
wutiangan
reviewed
Jul 14, 2020
morningman
reviewed
Jul 14, 2020
morningman
reviewed
Jul 15, 2020
ZhangYu0123
force-pushed
the
merged_rowset_delay_unused
branch
from
3ed0620 to
64713d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #4017, main changes as follows: