Skip to content

Conversation

@acelyc111
Copy link
Member

cpp-mustache is a C++ implementation of a Mustache template engine
with support for RapidJSON, and in order to simplify RapidJSON object
building, we introduce class EasyJson from Apache Kudu.

cpp-mustache is a C++ implementation of a Mustache template engine
with support for RapidJSON, and in order to simplify RapidJSON object
building, we introduce class EasyJson from Apache Kudu.
@acelyc111
Copy link
Member Author

acelyc111 commented Jul 9, 2020

Ref: #3911
easy_json.{h,.cc} and easy_json-test.cpp are copied from Kudu repository, mustache.{h, cc} are copied from cpp-mustache repository.
Now BE's web site looks like:
image

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help to comment out the logs/ entry? which is not implemented yet.

@acelyc111
Copy link
Member Author

Could you help to comment out the logs/ entry? which is not implemented yet.

@morningman I've updated to disable to show it on navigate bar.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. kind/improvement labels Jul 15, 2020
@morningman morningman self-assigned this Jul 15, 2020
@morningman morningman added the area/be/frontpage Issues or PRs related to the BE's frontpage label Jul 15, 2020
@morningman morningman merged commit d07a23e into apache:master Jul 16, 2020
@EmmyMiao87 EmmyMiao87 mentioned this pull request Aug 17, 2020
acelyc111 added a commit to acelyc111/incubator-doris that referenced this pull request Jan 20, 2021
…e#4062)

cpp-mustache is a C++ implementation of a Mustache template engine
with support for RapidJSON, and in order to simplify RapidJSON object
building, we introduce class EasyJson from Apache Kudu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/be/frontpage Issues or PRs related to the BE's frontpage kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants