Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement](err-msg) Clarify error msg for forward queries #40802

Merged
merged 1 commit into from
Sep 14, 2024
Merged

[enhancement](err-msg) Clarify error msg for forward queries #40802

merged 1 commit into from
Sep 14, 2024

Conversation

TangSiyang2001
Copy link
Collaborator

Proposed changes

As title.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@TangSiyang2001
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 43046 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d02957807f2ffe1b702a8c173b622ef8d797b478, data reload: false

------ Round 1 ----------------------------------
q1	18030	8195	7298	7298
q2	2950	220	256	220
q3	10615	1389	1403	1389
q4	11066	977	1004	977
q5	8174	3259	3189	3189
q6	246	154	153	153
q7	1054	644	622	622
q8	9452	2017	1994	1994
q9	6790	6295	6310	6295
q10	7033	2503	2530	2503
q11	432	263	252	252
q12	407	225	219	219
q13	17761	3008	3021	3008
q14	280	259	268	259
q15	585	527	530	527
q16	517	430	425	425
q17	976	941	959	941
q18	7395	6770	6808	6770
q19	1380	1227	1221	1221
q20	598	344	328	328
q21	3884	3509	3488	3488
q22	1067	968	968	968
Total cold run time: 110692 ms
Total hot run time: 43046 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7158	7146	7163	7146
q2	340	237	227	227
q3	2926	2895	2888	2888
q4	1969	1925	1944	1925
q5	5435	5370	5396	5370
q6	233	142	142	142
q7	2034	1706	1680	1680
q8	3242	3285	3292	3285
q9	8374	8354	8383	8354
q10	3367	3441	3425	3425
q11	580	470	465	465
q12	749	567	557	557
q13	4738	3031	3039	3031
q14	301	286	272	272
q15	575	523	514	514
q16	488	435	455	435
q17	1756	1720	1710	1710
q18	8002	7622	7687	7622
q19	1711	1686	1687	1686
q20	2025	1780	1810	1780
q21	5592	5286	5295	5286
q22	1077	974	984	974
Total cold run time: 62672 ms
Total hot run time: 58774 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194987 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d02957807f2ffe1b702a8c173b622ef8d797b478, data reload: false

query1	910	391	394	391
query2	6514	1746	1765	1746
query3	6663	208	215	208
query4	25746	24140	23817	23817
query5	5283	551	526	526
query6	271	180	168	168
query7	4586	306	309	306
query8	297	231	219	219
query9	8479	2555	2566	2555
query10	479	294	307	294
query11	16035	15850	15762	15762
query12	156	104	101	101
query13	1695	401	381	381
query14	11576	6759	6708	6708
query15	214	171	181	171
query16	7589	459	465	459
query17	1543	583	576	576
query18	1941	297	293	293
query19	197	157	153	153
query20	121	113	110	110
query21	265	103	100	100
query22	4523	4513	4349	4349
query23	34714	33740	33913	33740
query24	9413	3140	3134	3134
query25	672	403	404	403
query26	1398	157	156	156
query27	2830	276	286	276
query28	6827	2109	2084	2084
query29	949	409	422	409
query30	301	154	152	152
query31	990	792	803	792
query32	96	55	53	53
query33	740	308	300	300
query34	888	483	482	482
query35	901	723	777	723
query36	1050	908	897	897
query37	176	81	94	81
query38	4011	3855	3876	3855
query39	1459	1395	1415	1395
query40	284	115	112	112
query41	47	46	45	45
query42	122	103	104	103
query43	479	451	443	443
query44	1232	798	775	775
query45	199	169	168	168
query46	1104	838	819	819
query47	1899	1804	1805	1804
query48	364	288	291	288
query49	1133	449	440	440
query50	897	430	439	430
query51	6963	6930	6890	6890
query52	101	87	92	87
query53	268	183	187	183
query54	748	464	479	464
query55	79	83	77	77
query56	293	273	277	273
query57	1195	1075	1069	1069
query58	252	241	247	241
query59	3001	2640	2476	2476
query60	316	276	285	276
query61	104	102	104	102
query62	928	682	663	663
query63	214	198	189	189
query64	5404	676	693	676
query65	3256	3200	3157	3157
query66	1385	300	298	298
query67	15905	15544	15525	15525
query68	3172	865	855	855
query69	436	323	326	323
query70	1181	1177	1149	1149
query71	344	351	345	345
query72	5913	3569	3316	3316
query73	592	632	583	583
query74	9136	9122	9084	9084
query75	3125	3010	3019	3010
query76	1884	828	835	828
query77	434	410	392	392
query78	9425	9331	9268	9268
query79	911	889	869	869
query80	835	821	814	814
query81	447	262	270	262
query82	263	267	262	262
query83	187	188	193	188
query84	232	113	105	105
query85	653	419	400	400
query86	333	307	298	298
query87	4349	4336	4467	4336
query88	4121	4065	4048	4048
query89	390	365	380	365
query90	1288	319	315	315
query91	127	128	130	128
query92	78	80	77	77
query93	1038	1040	1031	1031
query94	618	391	351	351
query95	468	416	432	416
query96	468	470	469	469
query97	3153	3162	3156	3156
query98	229	228	255	228
query99	1521	1318	1319	1318
Total cold run time: 278021 ms
Total hot run time: 194987 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.07 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d02957807f2ffe1b702a8c173b622ef8d797b478, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.22	0.04	0.04
query4	1.69	0.08	0.07
query5	0.50	0.50	0.50
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.56	0.53	0.52
query10	0.56	0.57	0.59
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.62	0.61	0.61
query14	1.47	1.43	1.46
query15	0.90	0.89	0.88
query16	0.36	0.37	0.37
query17	1.03	1.03	1.03
query18	0.22	0.20	0.21
query19	1.94	1.83	1.83
query20	0.01	0.01	0.01
query21	15.40	0.69	0.69
query22	4.24	7.51	1.17
query23	18.00	1.40	1.37
query24	2.27	0.23	0.22
query25	0.18	0.08	0.08
query26	0.29	0.19	0.19
query27	0.08	0.08	0.07
query28	13.18	1.12	1.09
query29	12.53	3.38	3.30
query30	0.24	0.05	0.06
query31	2.87	0.44	0.41
query32	3.22	0.50	0.49
query33	3.04	3.06	3.09
query34	15.46	4.28	4.31
query35	4.33	4.35	4.33
query36	0.68	0.49	0.49
query37	0.18	0.16	0.17
query38	0.17	0.15	0.15
query39	0.04	0.04	0.04
query40	0.16	0.13	0.15
query41	0.10	0.05	0.05
query42	0.06	0.06	0.05
query43	0.06	0.05	0.04
Total cold run time: 108.48 s
Total hot run time: 31.07 s

@TangSiyang2001
Copy link
Collaborator Author

run feut

@TangSiyang2001
Copy link
Collaborator Author

run p0

dataroaring
dataroaring approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 2a891a7 into apache:master Sep 14, 2024
27 of 30 checks passed
TangSiyang2001 added a commit to TangSiyang2001/doris that referenced this pull request Sep 29, 2024
@TangSiyang2001
[enhancement](err-msg) Clarify error msg for forward queries (apache#…
dfbe3c6 
…40802)
@TangSiyang2001 TangSiyang2001 mentioned this pull request Sep 29, 2024
Merged
dataroaring pushed a commit that referenced this pull request Sep 29, 2024
@TangSiyang2001
[enhancement](err-msg) Clarify error msg for forward queries (#40802) (…
9864324 
…#41474)

## Proposed changes

pick: #40802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luwei16 luwei16 luwei16 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TangSiyang2001 @doris-robot @luwei16 @dataroaring