Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix](cache) the cache capacity is wrong when memusage > soft memlimit #40961

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[bugfix](cache) the cache capacity is wrong when memusage > soft memlimit #40961

merged 1 commit into from
Sep 19, 2024

Conversation

yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Sep 19, 2024 •
edited
Loading

Proposed changes

bug is introduced by #40542

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yiguolei
Copy link
Contributor Author

run buildall

xinyiZzz
xinyiZzz approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 41738 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c244b61303c99053e65ec38f63b69f528db8de36, data reload: false

------ Round 1 ----------------------------------
q1	18211	7437	7318	7318
q2	2448	165	166	165
q3	11092	1162	1203	1162
q4	10426	777	744	744
q5	7772	3152	3071	3071
q6	240	152	157	152
q7	1033	639	624	624
q8	9728	2070	2073	2070
q9	6920	6460	6393	6393
q10	7009	2266	2277	2266
q11	439	252	258	252
q12	437	225	223	223
q13	17795	2973	2987	2973
q14	238	215	214	214
q15	574	537	526	526
q16	686	617	622	617
q17	979	788	793	788
q18	7389	6787	6762	6762
q19	1404	1031	1018	1018
q20	587	294	288	288
q21	4288	3415	3122	3122
q22	1149	1003	990	990
Total cold run time: 110844 ms
Total hot run time: 41738 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7239	7214	7201	7201
q2	331	231	230	230
q3	2873	2799	2759	2759
q4	1968	1763	1675	1675
q5	5335	5430	5409	5409
q6	232	145	146	145
q7	2091	1699	1682	1682
q8	3173	3303	3365	3303
q9	8354	8381	8379	8379
q10	3353	3289	3325	3289
q11	566	475	463	463
q12	786	556	566	556
q13	6711	2989	2982	2982
q14	292	262	259	259
q15	560	511	521	511
q16	706	661	664	661
q17	1753	1555	1518	1518
q18	7737	7385	7500	7385
q19	1685	1416	1567	1416
q20	2037	1797	1804	1797
q21	5357	5147	5126	5126
q22	1103	1031	981	981
Total cold run time: 64242 ms
Total hot run time: 57727 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.32% (9581/25675)
Line Coverage: 28.70% (79193/275956)
Region Coverage: 28.17% (41002/145528)
Branch Coverage: 24.79% (20891/84256)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c244b61303c99053e65ec38f63b69f528db8de36_c244b61303c99053e65ec38f63b69f528db8de36/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 189758 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c244b61303c99053e65ec38f63b69f528db8de36, data reload: false

query1	954	372	374	372
query2	6536	2179	1996	1996
query3	6703	211	225	211
query4	34224	23392	23396	23392
query5	4338	483	470	470
query6	268	177	167	167
query7	4630	292	300	292
query8	277	225	228	225
query9	9897	2676	2675	2675
query10	465	281	288	281
query11	18221	15212	15206	15206
query12	157	99	99	99
query13	1630	428	397	397
query14	10418	6845	7800	6845
query15	255	169	189	169
query16	8094	456	492	456
query17	1683	591	571	571
query18	2151	302	309	302
query19	377	151	149	149
query20	115	108	112	108
query21	214	103	104	103
query22	4509	4332	4313	4313
query23	34464	33423	34734	33423
query24	11641	2909	2845	2845
query25	704	412	414	412
query26	1813	161	162	161
query27	2814	281	285	281
query28	8350	2460	2456	2456
query29	1069	433	423	423
query30	332	159	156	156
query31	1029	787	817	787
query32	100	59	58	58
query33	784	308	302	302
query34	937	513	507	507
query35	842	732	715	715
query36	1074	952	940	940
query37	223	89	90	89
query38	4064	3893	3911	3893
query39	1452	1453	1390	1390
query40	286	99	96	96
query41	51	49	50	49
query42	117	97	100	97
query43	539	505	495	495
query44	1277	815	785	785
query45	196	165	171	165
query46	1142	769	747	747
query47	1894	1797	1811	1797
query48	482	360	378	360
query49	1228	419	419	419
query50	830	410	413	410
query51	7133	6940	6908	6908
query52	102	88	89	88
query53	254	184	181	181
query54	1109	483	468	468
query55	78	80	77	77
query56	289	270	273	270
query57	1235	1084	1101	1084
query58	245	268	231	231
query59	3237	3153	2909	2909
query60	302	269	267	267
query61	108	101	112	101
query62	849	667	646	646
query63	212	190	189	189
query64	5150	653	623	623
query65	3309	3142	3180	3142
query66	1188	298	301	298
query67	15737	15614	15431	15431
query68	4839	569	572	569
query69	433	295	298	295
query70	1232	1166	1112	1112
query71	333	277	275	275
query72	6342	3915	4035	3915
query73	769	326	343	326
query74	9502	9187	8944	8944
query75	3397	2758	2602	2602
query76	2903	919	962	919
query77	404	282	291	282
query78	9788	9410	9140	9140
query79	1345	546	532	532
query80	1142	455	433	433
query81	590	242	242	242
query82	839	142	142	142
query83	208	135	134	134
query84	245	77	87	77
query85	1148	299	276	276
query86	352	294	312	294
query87	4485	4354	4392	4354
query88	3203	2334	2351	2334
query89	392	286	279	279
query90	1828	191	190	190
query91	183	145	149	145
query92	60	49	46	46
query93	1089	543	543	543
query94	743	295	288	288
query95	348	263	249	249
query96	602	282	274	274
query97	3313	3104	3101	3101
query98	215	197	191	191
query99	1511	1293	1285	1285
Total cold run time: 300170 ms
Total hot run time: 189758 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.53 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c244b61303c99053e65ec38f63b69f528db8de36, data reload: false

query1	0.05	0.05	0.04
query2	0.06	0.03	0.02
query3	0.24	0.06	0.06
query4	1.65	0.10	0.10
query5	0.52	0.52	0.49
query6	1.15	0.73	0.71
query7	0.02	0.01	0.02
query8	0.03	0.03	0.03
query9	0.56	0.49	0.49
query10	0.54	0.58	0.54
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.58	0.58
query14	3.08	2.99	2.96
query15	0.88	0.82	0.82
query16	0.39	0.39	0.37
query17	1.01	1.06	0.95
query18	0.22	0.21	0.22
query19	1.95	1.76	1.98
query20	0.01	0.01	0.01
query21	15.40	0.57	0.58
query22	2.84	1.60	1.36
query23	17.54	0.93	0.78
query24	2.81	1.60	0.58
query25	0.32	0.05	0.11
query26	0.37	0.14	0.14
query27	0.05	0.05	0.03
query28	10.65	1.10	1.06
query29	12.54	3.20	3.26
query30	0.24	0.06	0.06
query31	2.89	0.39	0.38
query32	3.26	0.45	0.46
query33	2.97	2.99	3.05
query34	17.09	4.38	4.35
query35	4.42	4.43	4.41
query36	0.71	0.48	0.47
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.03	0.02
query40	0.15	0.12	0.12
query41	0.07	0.02	0.03
query42	0.03	0.02	0.01
query43	0.03	0.03	0.03
Total cold run time: 107.79 s
Total hot run time: 31.53 s

kaijchen
kaijchen approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 087f23a into apache:master Sep 19, 2024
25 of 30 checks passed
yiguolei added a commit that referenced this pull request Sep 19, 2024
@yiguolei @Doris-Extras
[bugfix](cache) the cache capacity is wrong when memusage > soft meml…
330e0d3 
…imit (#40961)

## Proposed changes

bug is introduced by #40542

Co-authored-by: yiguolei <yiguolei@gmail.com>
feifeifeimoon pushed a commit to feifeifeimoon/doris that referenced this pull request Sep 24, 2024
@yiguolei @Doris-Extras @feifeifeimoon
[bugfix](cache) the cache capacity is wrong when memusage > soft meml…
afdcdad 
…imit (apache#40961)

## Proposed changes

bug is introduced by apache#40542

Co-authored-by: yiguolei <yiguolei@gmail.com>
@feifeifeimoon feifeifeimoon mentioned this pull request Sep 24, 2024
Closed
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@yiguolei @Doris-Extras @dataroaring
[bugfix](cache) the cache capacity is wrong when memusage > soft meml…
cc30015 
…imit (#40961)

## Proposed changes

bug is introduced by #40542

Co-authored-by: yiguolei <yiguolei@gmail.com>
zzzxl1993 pushed a commit to zzzxl1993/doris that referenced this pull request Oct 24, 2024
@yiguolei @Doris-Extras @zzzxl1993
[bugfix](cache) the cache capacity is wrong when memusage > soft meml…
a97f6c8 
…imit (apache#40961)

bug is introduced by apache#40542

Co-authored-by: yiguolei <yiguolei@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinyiZzz xinyiZzz xinyiZzz approved these changes

@kaijchen kaijchen kaijchen approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yiguolei @doris-robot @kaijchen @xinyiZzz @dataroaring @Doris-Extras