Skip to content

[case](mtmv)Failed to fix the case of concurrent insert overwrite execution #41125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 3 commits into from
Sep 23, 2024
Merged

[case](mtmv)Failed to fix the case of concurrent insert overwrite execution #41125

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ea359f
1
zddr Sep 23, 2024
8f5c92d
1
zddr Sep 23, 2024
0ca223f
1
zddr Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions regression-test/suites/insert_overwrite_p1/test_iot_auto_detect_concurrent.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ suite("test_iot_auto_detect_concurrent") {
sql new File("""${context.file.parent}/ddl/test_iot_auto_detect_concurrent.sql""").text

def success_status = true
def err_msg = ""
def load_data = { range, offset, expect_success ->
try {
sql " use test_iot_auto_detect_concurrent; "
Expand All @@ -37,6 +38,7 @@ suite("test_iot_auto_detect_concurrent") {
success_status = false
log.info("fails one")
}
err_msg = e.getMessage()
log.info("successfully catch the failed insert")
return
}
Expand Down Expand Up @@ -98,10 +100,14 @@ suite("test_iot_auto_detect_concurrent") {
thread6.join()
thread7.join()
// suppose result: Success to overwrite with a multiple of ten values
assertTrue(success_status)
qt_sql3 " select count(k0) from test_concurrent_write; "
qt_sql4 " select count(distinct k0) from test_concurrent_write; "

if (!success_status) {
// Not allowed running Insert Overwrite on same table
assertTrue(err_msg.contains('same table'))
Copy link
Contributor

@zclllyybb zclllyybb Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if hit this branch, the output will miss sql3 and sql4?

} else {
// The execution was fast, resulting in no concurrent execution
qt_sql3 " select count(k0) from test_concurrent_write; "
qt_sql4 " select count(distinct k0) from test_concurrent_write; "
}

/// with drop partition concurrently
success_status = true
Expand Down