Skip to content

fix boolean support #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Jul 22, 2020
Merged

fix boolean support #4123

morningman merged 1 commit into from
Jul 22, 2020

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Jul 21, 2020 •
edited by morningman
Loading

Proposed changes

Fixes #4122

  • add type check when add bloom filter index
  • support add boolean column

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Doris's issues, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related issues ID, like "Add pull request template to doris project #4071 Add pull request template to doris project"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

@EmmyMiao87 EmmyMiao87 added the kind/fix Categorizes issue or PR as related to a bug. label Jul 21, 2020
EmmyMiao87
EmmyMiao87 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87 EmmyMiao87 added the area/bloom-filter-index Issues or PRS related to bloom filter index label Jul 21, 2020
@EmmyMiao87 EmmyMiao87 linked an issue Jul 21, 2020 that may be closed by this pull request
[BUG] Boolean support not incomplete #4122
Closed
@yangzhg yangzhg added the approved Indicates a PR has been approved by one committer. label Jul 22, 2020
@morningman morningman merged commit 31a6c43 into apache:master Jul 22, 2020
wutiangan pushed a commit to wutiangan/incubator-doris that referenced this pull request Jul 23, 2020
@yangzhg @wutiangan
[Bug][Alter] Fix boolean support (apache#4123)
635f1b2 
Fixes apache#4122
 *  add type check when add bloom filter index on boolean column.
 *  support add boolean column.
morningman pushed a commit to morningman/doris that referenced this pull request Jul 30, 2020
@yangzhg @morningman-cmy
[Bug][Alter] Fix boolean support (apache#4123)
d6bc105 
Fixes apache#4122
 *  add type check when add bloom filter index on boolean column.
 *  support add boolean column.
@yangzhg yangzhg deleted the fix_bool branch September 14, 2020 01:47
csun5285 pushed a commit to csun5285/doris that referenced this pull request Sep 23, 2025
@deardeng
[fix](cloud) Periodically cleaning secondary be in cloud used by redu… (
6c40ce6 
apache#4123)

…… (apache#4055)

…ndant tablets (apache#50200)

secondary BE in cloud mode, temporarily stores the be tablet mapping
relationship of the be abnormal rehash. If it is not cleaned up, report
the redundant tablet cleaning diff logic, which does not work as
expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmmyMiao87 EmmyMiao87 EmmyMiao87 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/bloom-filter-index Issues or PRS related to bloom filter index kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Boolean support not incomplete

3 participants

@yangzhg @EmmyMiao87 @morningman