Skip to content

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Jul 21, 2020

Proposed changes

generate generated-java files using maven instead of by build.sh

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Doris's issues, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related issues ID, like "Add pull request template to doris project #4071 Add pull request template to doris project"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

@yangzhg yangzhg self-assigned this Jul 27, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. branch-0.13 PR which need to merge to branch 0.13 labels Aug 4, 2020
@EmmyMiao87 EmmyMiao87 merged commit 1b34160 into apache:master Aug 5, 2020
@EmmyMiao87 EmmyMiao87 mentioned this pull request Sep 2, 2020
@yangzhg yangzhg deleted the gen_thrift branch September 14, 2020 01:47
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. branch-0.13 PR which need to merge to branch 0.13 kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants