-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](bloom filter)Fix drop column with bloom filter #41369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
xiaokang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 40697 ms |
TPC-DS: Total hot run time: 192543 ms |
ClickBench: Total hot run time: 32.72 s |
96977a4 to
c80fe25
Compare
|
run buildall |
TPC-H: Total hot run time: 40724 ms |
TPC-DS: Total hot run time: 192771 ms |
ClickBench: Total hot run time: 32.31 s |
zzzxl1993
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue Number: close apache#41368
Issue Number: close apache#41368
| } | ||
| } | ||
| olapTable.setBloomFilterInfo(newBfCols, olapTable.getBfFpp()); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be this can be better
Set<String> bfCols = olapTable.getCopiedBfColumns();
if (bfCols != null) {
Set<String> newBfCols = bfCols.stream()
.filter(bfCol -> !bfCol.equalsIgnoreCase(dropColName))
.collect(Collectors.toSet());
olapTable.setBloomFilterInfo(newBfCols, olapTable.getBfFpp());
}
Issue Number: close apache#41368
Problem Summary: 1. When drop column with bloom filter, we modify the bloom filter column info 2. When replay editLog, we rebuild bloom filter info by table schema. Related PR: #41369 ### Release note Fix drop column with bloom filter index
) Problem Summary: 1. When drop column with bloom filter, we modify the bloom filter column info 2. When replay editLog, we rebuild bloom filter info by table schema. Related PR: apache#41369 Fix drop column with bloom filter index
) Problem Summary: 1. When drop column with bloom filter, we modify the bloom filter column info 2. When replay editLog, we rebuild bloom filter info by table schema. Related PR: apache#41369 Fix drop column with bloom filter index
) Problem Summary: 1. When drop column with bloom filter, we modify the bloom filter column info 2. When replay editLog, we rebuild bloom filter info by table schema. Related PR: apache#41369 Fix drop column with bloom filter index
Proposed changes
Issue Number: close #41368