[CodeRefactor] Modify FE modules #4146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
added
kind/refactor
xy720
reviewed
Jul 23, 2020
build.sh
Outdated
| cp -r -p ${DORIS_HOME}/webroot/* ${DORIS_OUTPUT}/fe/webroot/ | ||
| # Copy Frontend and Backend | ||
| if [ ${BUILD_FE} -eq 1 -o ${BUILD_SPARK_DPP} -eq 1 ]; then | ||
| if [ ${BUILD_FE} -eq 1]; then |
Member
There was a problem hiding this comment.
Suggested change
| if [ ${BUILD_FE} -eq 1]; then | |
| if [ ${BUILD_FE} -eq 1 ]; then |
xy720
reviewed
Jul 23, 2020
| </dependencies> | ||
|
|
||
| <build> | ||
| <finalName>spark-dpp-${version}</finalName> |
Member
There was a problem hiding this comment.
I think better named it without version, just like "palo-fe.jar", may be "spark-dpp.jar". Because we will have a DppVersion in FeConstant.
Contributor
Author
There was a problem hiding this comment.
If without version, it is difficult to found out which version it is when we saw this file.
kangkaisen
reviewed
Jul 23, 2020
kangkaisen
reviewed
Jul 23, 2020
|
|
||
| This module is used to store some common classes of other modules. | ||
|
|
||
| # spark-dpp |
Contributor
There was a problem hiding this comment.
Would better add a explain for dpp.
5 tasks
morningman
pushed a commit
that referenced
this pull request
Jul 27, 2020
…4163) ### Resume When users use spark load, they have to upload the dependent jars to hdfs every time. This cl will add a self-generated repository under working_dir folder in hdfs for saving dependecies of spark dpp programe and spark platform. Note that, the dependcies we upload to repository include: 1、`spark-dpp.jar` 2、`spark2x.zip` 1 is the dpp library which built with spark-dpp submodule. See details about spark-dpp submodule in pr #4146 . 2 is the spark2.x.x platform library which contains all jars in $SPARK_HOME/jars **The repository structure** will be like this: ``` __spark_repository__/ |-__archive_1_0_0/ | |-__lib_990325d2c0d1d5e45bf675e54e44fb16_spark-dpp.jar | |-__lib_7670c29daf535efe3c9b923f778f61fc_spark-2x.zip |-__archive_2_2_0/ | |-__lib_64d5696f99c379af2bee28c1c84271d5_spark-dpp.jar | |-__lib_1bbb74bb6b264a270bc7fca3e964160f_spark-2x.zip |-__archive_3_2_0/ | |-... ``` The followinng conditions will force fe to upload dependencies: 1、When fe find its dppVersion is absent in repository. 2、The MD5 value of remote file does not match the local file. Before Fe uploads the dependencies, it will create an archive directory with name `__archive_{dppVersion}` under the repository.
morningman
force-pushed
the
spark-dpp-module
branch
from
0d53821 to
883b261
Compare
morningman
force-pushed
the
spark-dpp-module
branch
from
883b261 to
0e78695
Compare
morningman
force-pushed
the
spark-dpp-module
branch
from
0e78695 to
f289137
Compare
Member
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This CL mainly changes:
Add 2 new FE modules
fe-common
save all common classes for other modules, currently only
jmockitspark-dpp
The Spark DPP application for Spark Load. And I removed all dpp related classes to this module, including unit tests.
Change the
build.shAdd a new param
--spark-dppto compile thespark-dppalone. And--fewill compile all FE modules.the output of
spark-dppmodule isspark-dpp-1.0.0-jar-with-dependencies.jar, and it will be installed tooutput/fe/spark-dpp/.Types of changes
Checklist
Further comments
After this PR merged, the Spark Load feature will NOT working, it need to wait another PR to modify the way to deploy the new
spark-dpp.jar.