Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](Nereids) fix date and date time arithmatic (#40745) #41533

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

LiBinfeng-01
Copy link
Collaborator

cherry-pick:#40745
fix date and time arithmatic of: hours_add, minutes_add, seconds_add, to_days

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

2 similar comments
@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@morrySnow
Copy link
Contributor

run buildall

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49706 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b41a13457139b0e4531ba446f28a33db7e2227a6, data reload: false

------ Round 1 ----------------------------------
q1	17773	4438	4416	4416
q2	2086	159	150	150
q3	10287	1942	1981	1942
q4	10108	1297	1328	1297
q5	8546	4003	4009	4003
q6	238	123	122	122
q7	2081	1625	1574	1574
q8	9308	2786	2756	2756
q9	10326	9963	9926	9926
q10	8700	3536	3538	3536
q11	417	241	251	241
q12	478	303	300	300
q13	18377	4050	4103	4050
q14	353	318	335	318
q15	512	474	464	464
q16	541	462	455	455
q17	1155	995	953	953
q18	7407	6816	6958	6816
q19	1698	1586	1539	1539
q20	550	329	312	312
q21	4509	4213	4142	4142
q22	510	394	400	394
Total cold run time: 115960 ms
Total hot run time: 49706 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4349	4324	4340	4324
q2	321	223	229	223
q3	4209	4188	4168	4168
q4	2787	2757	2746	2746
q5	7303	7227	7171	7171
q6	236	120	118	118
q7	3248	2834	2827	2827
q8	4432	4511	4523	4511
q9	13809	13806	13595	13595
q10	4231	4273	4270	4270
q11	769	693	704	693
q12	1046	856	868	856
q13	6137	3775	3729	3729
q14	471	437	427	427
q15	505	458	458	458
q16	621	577	598	577
q17	3840	3828	3833	3828
q18	8825	8802	8790	8790
q19	1745	1688	1653	1653
q20	2384	2107	2106	2106
q21	8581	8449	8650	8449
q22	1032	948	927	927
Total cold run time: 80881 ms
Total hot run time: 76446 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 212413 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b41a13457139b0e4531ba446f28a33db7e2227a6, data reload: false

query1	933	391	418	391
query2	6572	2399	2007	2007
query3	6922	205	203	203
query4	22888	21736	22167	21736
query5	19726	6509	6525	6509
query6	282	213	230	213
query7	4323	299	313	299
query8	258	252	260	252
query9	3043	2638	2563	2563
query10	474	312	284	284
query11	15717	15136	14932	14932
query12	120	78	73	73
query13	1031	434	435	434
query14	16898	13195	13098	13098
query15	366	222	223	222
query16	6496	281	263	263
query17	1775	936	902	902
query18	893	310	321	310
query19	214	153	149	149
query20	103	110	111	110
query21	191	105	92	92
query22	5319	5160	5101	5101
query23	34337	33553	33705	33553
query24	7883	6463	6329	6329
query25	531	431	420	420
query26	1267	164	160	160
query27	2431	298	292	292
query28	6082	2243	2210	2210
query29	2916	2664	2671	2664
query30	249	170	163	163
query31	954	740	769	740
query32	65	57	60	57
query33	456	260	267	260
query34	855	483	460	460
query35	1113	921	909	909
query36	1573	1325	1094	1094
query37	165	59	60	59
query38	3087	2927	2913	2913
query39	1376	1312	1314	1312
query40	309	98	97	97
query41	39	37	37	37
query42	92	85	84	84
query43	727	597	596	596
query44	1132	711	716	711
query45	248	231	239	231
query46	1222	969	955	955
query47	1824	1838	1823	1823
query48	499	429	406	406
query49	654	370	371	370
query50	855	603	598	598
query51	4795	4611	4674	4611
query52	87	92	88	88
query53	238	179	187	179
query54	2668	2487	2492	2487
query55	82	89	90	89
query56	232	205	211	205
query57	1192	1335	1105	1105
query58	226	208	206	206
query59	3530	3200	3449	3200
query60	221	211	200	200
query61	97	93	95	93
query62	833	506	462	462
query63	198	178	175	175
query64	3565	1566	1480	1480
query65	3617	3546	3585	3546
query66	775	415	413	413
query67	16102	15527	17429	15527
query68	9146	650	648	648
query69	505	273	269	269
query70	1572	1507	1568	1507
query71	397	305	313	305
query72	6741	4823	4783	4783
query73	760	320	336	320
query74	6307	5809	5872	5809
query75	4513	3703	3719	3703
query76	4703	1131	1202	1131
query77	616	250	255	250
query78	12599	11447	12705	11447
query79	7813	619	635	619
query80	2197	371	399	371
query81	514	242	237	237
query82	588	94	94	94
query83	180	129	129	129
query84	263	69	70	69
query85	1304	317	320	317
query86	358	329	289	289
query87	3258	3022	3055	3022
query88	4105	2265	2280	2265
query89	354	300	286	286
query90	1796	210	218	210
query91	164	138	126	126
query92	63	55	51	51
query93	3775	555	575	555
query94	877	204	212	204
query95	2038	1931	1990	1931
query96	645	331	325	325
query97	6459	6458	6356	6356
query98	233	213	207	207
query99	2966	916	866	866
Total cold run time: 313752 ms
Total hot run time: 212413 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.58 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b41a13457139b0e4531ba446f28a33db7e2227a6, data reload: false

query1	0.02	0.02	0.02
query2	0.06	0.03	0.03
query3	0.25	0.05	0.04
query4	1.79	0.06	0.07
query5	0.53	0.53	0.53
query6	1.22	0.62	0.62
query7	0.02	0.01	0.00
query8	0.04	0.03	0.02
query9	0.51	0.48	0.49
query10	0.52	0.53	0.54
query11	0.13	0.09	0.08
query12	0.12	0.09	0.09
query13	0.63	0.62	0.61
query14	0.79	0.78	0.79
query15	0.79	0.77	0.76
query16	0.36	0.38	0.36
query17	1.01	0.96	1.01
query18	0.24	0.24	0.24
query19	1.85	1.86	1.83
query20	0.01	0.02	0.02
query21	15.47	0.54	0.55
query22	2.06	2.23	1.45
query23	16.84	0.97	0.85
query24	6.81	2.32	1.10
query25	0.40	0.09	0.06
query26	0.80	0.16	0.15
query27	0.05	0.03	0.04
query28	5.42	0.72	0.77
query29	12.64	2.39	2.28
query30	0.56	0.53	0.52
query31	2.80	0.38	0.37
query32	3.39	0.50	0.49
query33	3.09	3.08	3.09
query34	15.26	4.80	4.79
query35	4.86	4.85	4.82
query36	1.04	1.01	1.01
query37	0.05	0.05	0.05
query38	0.04	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.15	0.14
query41	0.06	0.02	0.01
query42	0.03	0.01	0.02
query43	0.02	0.02	0.02
Total cold run time: 102.76 s
Total hot run time: 30.58 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit b41a13457139b0e4531ba446f28a33db7e2227a6 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       20.9 seconds inserted 10000000 Rows, about 478K ops/s

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 48584 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9f70d0d9790d7169cb5bfcb243d8214f125ce1e3, data reload: false

------ Round 1 ----------------------------------
q1	17717	4336	4341	4336
q2	2051	153	145	145
q3	10291	1892	1908	1892
q4	10305	1250	1300	1250
q5	8648	3816	3886	3816
q6	235	122	126	122
q7	2023	1600	1580	1580
q8	9253	2695	2677	2677
q9	10310	9776	9645	9645
q10	8647	3516	3486	3486
q11	429	243	251	243
q12	484	302	300	300
q13	18325	3961	4006	3961
q14	354	333	318	318
q15	509	457	454	454
q16	543	463	455	455
q17	1113	950	896	896
q18	7289	6736	6867	6736
q19	1686	1589	1481	1481
q20	524	319	308	308
q21	4428	4099	4085	4085
q22	483	398	407	398
Total cold run time: 115647 ms
Total hot run time: 48584 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4345	4314	4272	4272
q2	321	224	225	224
q3	4162	4134	4140	4134
q4	2750	2734	2735	2734
q5	7129	7109	7076	7076
q6	235	122	122	122
q7	3258	2842	2865	2842
q8	4365	4468	4473	4468
q9	13574	13473	13506	13473
q10	4275	4227	4271	4227
q11	775	702	662	662
q12	1002	855	875	855
q13	6603	3748	3735	3735
q14	437	428	430	428
q15	497	457	452	452
q16	632	575	602	575
q17	3863	3828	3853	3828
q18	8776	8748	8809	8748
q19	1720	1645	1668	1645
q20	2411	2110	2088	2088
q21	8439	8392	8490	8392
q22	1027	930	935	930
Total cold run time: 80596 ms
Total hot run time: 75910 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 212090 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9f70d0d9790d7169cb5bfcb243d8214f125ce1e3, data reload: false

query1	923	429	377	377
query2	6693	2119	2047	2047
query3	6923	203	209	203
query4	23073	21687	21944	21687
query5	20164	6606	6565	6565
query6	1308	214	248	214
query7	7789	307	318	307
query8	285	291	258	258
query9	4329	2615	2574	2574
query10	892	312	298	298
query11	15966	15070	15100	15070
query12	128	79	75	75
query13	1044	443	428	428
query14	18985	13040	13575	13040
query15	392	222	234	222
query16	6451	279	263	263
query17	1541	948	927	927
query18	886	323	324	323
query19	215	155	149	149
query20	102	91	95	91
query21	190	91	99	91
query22	5315	5031	4956	4956
query23	34268	33577	33451	33451
query24	6575	6355	6342	6342
query25	530	435	425	425
query26	800	159	160	159
query27	2262	295	289	289
query28	6118	2253	2225	2225
query29	2872	2930	2862	2862
query30	246	167	163	163
query31	982	723	718	718
query32	72	63	59	59
query33	441	256	257	256
query34	865	491	469	469
query35	1129	932	949	932
query36	1355	1190	1163	1163
query37	94	61	63	61
query38	3046	2917	2945	2917
query39	1386	1330	1321	1321
query40	201	92	91	91
query41	41	38	38	38
query42	80	83	81	81
query43	633	640	606	606
query44	1153	726	718	718
query45	240	228	234	228
query46	1231	998	940	940
query47	1872	1695	1877	1695
query48	503	408	403	403
query49	624	372	389	372
query50	849	660	627	627
query51	4722	4686	4699	4686
query52	96	81	84	81
query53	220	188	201	188
query54	2660	2461	2465	2461
query55	98	76	85	76
query56	227	195	208	195
query57	1282	1129	1150	1129
query58	213	211	203	203
query59	3485	3264	3155	3155
query60	219	198	195	195
query61	94	90	91	90
query62	715	513	443	443
query63	201	178	172	172
query64	3324	1480	1363	1363
query65	3642	3544	3565	3544
query66	752	413	398	398
query67	16795	15039	15603	15039
query68	9769	628	634	628
query69	519	291	269	269
query70	1546	1429	1422	1422
query71	424	319	323	319
query72	6772	4806	4694	4694
query73	762	326	317	317
query74	6290	5927	5747	5747
query75	5413	3706	3641	3641
query76	5560	1127	1187	1127
query77	934	257	261	257
query78	12589	11878	12109	11878
query79	6061	653	616	616
query80	1102	395	399	395
query81	496	244	233	233
query82	1619	99	103	99
query83	166	133	136	133
query84	259	69	72	69
query85	873	310	315	310
query86	330	297	271	271
query87	3271	3020	3033	3020
query88	4599	2282	2307	2282
query89	399	278	283	278
query90	1937	213	217	213
query91	158	129	125	125
query92	61	52	53	52
query93	4852	548	585	548
query94	707	213	211	211
query95	1970	1965	1991	1965
query96	666	328	323	323
query97	6504	6383	6423	6383
query98	221	199	204	199
query99	2891	872	1009	872
Total cold run time: 322527 ms
Total hot run time: 212090 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9f70d0d9790d7169cb5bfcb243d8214f125ce1e3, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.02	0.02
query3	0.24	0.04	0.04
query4	1.79	0.08	0.07
query5	0.54	0.53	0.52
query6	1.24	0.62	0.61
query7	0.02	0.01	0.00
query8	0.03	0.02	0.02
query9	0.53	0.52	0.47
query10	0.53	0.54	0.54
query11	0.12	0.09	0.08
query12	0.12	0.09	0.10
query13	0.63	0.62	0.62
query14	0.79	0.79	0.79
query15	0.78	0.78	0.75
query16	0.36	0.39	0.37
query17	1.01	1.00	1.01
query18	0.25	0.25	0.24
query19	1.91	1.84	1.88
query20	0.01	0.01	0.01
query21	15.46	0.57	0.56
query22	1.91	2.03	1.56
query23	17.09	1.12	0.81
query24	4.29	4.03	0.92
query25	0.38	0.09	0.06
query26	0.77	0.17	0.15
query27	0.05	0.04	0.05
query28	6.09	0.78	0.77
query29	12.66	2.34	2.10
query30	0.65	0.52	0.50
query31	2.82	0.40	0.37
query32	3.39	0.49	0.49
query33	3.09	3.07	3.06
query34	15.26	4.81	4.82
query35	4.87	4.84	4.82
query36	1.07	1.02	1.02
query37	0.06	0.05	0.04
query38	0.04	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.15	0.14
query41	0.06	0.01	0.02
query42	0.02	0.02	0.01
query43	0.03	0.02	0.01
Total cold run time: 101.24 s
Total hot run time: 30.39 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 9f70d0d9790d7169cb5bfcb243d8214f125ce1e3 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.7 seconds inserted 10000000 Rows, about 460K ops/s

@LiBinfeng-01
Copy link
Collaborator Author

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 21, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit d7032d1 into apache:branch-2.0 Oct 21, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/nereids kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants