Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](inverted index) Fix incorrect usage of regexp compile_err #41944

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[fix](inverted index) Fix incorrect usage of regexp compile_err #41944

merged 1 commit into from
Oct 17, 2024

Conversation

zzzxl1993
Copy link
Contributor

Proposed changes

  1. This may cause invalid memory read.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zzzxl1993
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9709/25914)
Line Coverage: 28.73% (80606/280607)
Region Coverage: 28.17% (41712/148071)
Branch Coverage: 24.75% (21209/85698)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7b2ef2220c13b7fcd4169207eb46aeea6e88a24d_7b2ef2220c13b7fcd4169207eb46aeea6e88a24d/report/index.html

@zzzxl1993 zzzxl1993 changed the title [fix](inverted index) Fix incorrect usage of hyperscan compile_err [fix](inverted index) Fix incorrect usage of regexp compile_err Oct 16, 2024
csun5285
csun5285 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

qidaye
qidaye approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 17, 2024
@qidaye qidaye merged commit 6a7f02c into apache:master Oct 17, 2024
27 of 29 checks passed
zzzxl1993 added a commit to zzzxl1993/doris that referenced this pull request Oct 18, 2024
@zzzxl1993
[fix](inverted index) Fix incorrect usage of regexp compile_err (apac…
496968e 
…he#41944)
@zzzxl1993 zzzxl1993 mentioned this pull request Oct 18, 2024
Merged
yiguolei pushed a commit that referenced this pull request Oct 18, 2024
@zzzxl1993
[fix](inverted index) Fix incorrect usage of regexp compile_err (#41944…
dde0bf9 
…) (#42085)

#41944
@zzzxl1993 zzzxl1993 mentioned this pull request Nov 7, 2024
Merged
zzzxl1993 added a commit to zzzxl1993/doris that referenced this pull request Nov 7, 2024
@zzzxl1993
[fix](inverted index) Fix incorrect usage of regexp compile_err (apac…
e254502 
…he#41944)
airborne12 pushed a commit that referenced this pull request Nov 8, 2024
@zzzxl1993
[fix](inverted index) Fix incorrect usage of regexp compile_err (#41944…
35071eb 
…) (#43394)

pick #41944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csun5285 csun5285 csun5285 approved these changes

@qidaye qidaye qidaye approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zzzxl1993 @doris-robot @qidaye @csun5285 @airborne12 @yiguolei @eldenmoon