Skip to content

[chore](scan) remove useless enable_scan_node_run_serial #41559 #42013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 3 commits into from
Jan 3, 2025
Merged

[chore](scan) remove useless enable_scan_node_run_serial #41559 #42013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c26ee4
[chore](scan) remove useless enable_scan_node_run_serial (#41559)
zhiqiang-hhhh Oct 9, 2024
9e4fc9d
END
Nov 11, 2024
d820b82
Merge branch 'branch-3.0' into pick_41559_to_upstream_branch-3.0
zhiqiang-hhhh Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions be/src/runtime/runtime_state.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,11 +472,6 @@ class RuntimeState {
return _query_options.__isset.enable_profile && _query_options.enable_profile;
}

bool enable_scan_node_run_serial() const {
return _query_options.__isset.enable_scan_node_run_serial &&
_query_options.enable_scan_node_run_serial;
}

bool enable_share_hash_table_for_broadcast_join() const {
return _query_options.__isset.enable_share_hash_table_for_broadcast_join &&
_query_options.enable_share_hash_table_for_broadcast_join;
Expand Down
1 change: 0 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,6 @@ private void initQueryOptions(ConnectContext context) {
if (this.queryOptions.getExecutionTimeout() < 1) {
LOG.info("try set timeout less than 1", new RuntimeException(""));
}
this.queryOptions.setEnableScanNodeRunSerial(context.getSessionVariable().isEnableScanRunSerial());
this.queryOptions.setFeProcessUuid(ExecuteEnv.getInstance().getProcessUUID());
this.queryOptions.setWaitFullBlockScheduleTimes(context.getSessionVariable().getWaitFullBlockScheduleTimes());
this.queryOptions.setMysqlRowBinaryFormat(
Expand Down
12 changes: 0 additions & 12 deletions fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,8 +485,6 @@ public class SessionVariable implements Serializable, Writable {

public static final String ENABLE_CTE_MATERIALIZE = "enable_cte_materialize";

public static final String ENABLE_SCAN_RUN_SERIAL = "enable_scan_node_run_serial";

public static final String ENABLE_ANALYZE_COMPLEX_TYPE_COLUMN = "enable_analyze_complex_type_column";

public static final String EXTERNAL_TABLE_ANALYZE_PART_NUM = "external_table_analyze_part_num";
Expand Down Expand Up @@ -1021,12 +1019,6 @@ public enum IgnoreSplitType {
@VariableMgr.VarAttr(name = ENABLE_ODBC_TRANSCATION)
public boolean enableOdbcTransaction = false;

@VariableMgr.VarAttr(name = ENABLE_SCAN_RUN_SERIAL, description = {
"是否开启ScanNode串行读，以避免limit较小的情况下的读放大，可以提高查询的并发能力",
"Whether to enable ScanNode serial reading to avoid read amplification in cases of small limits"
+ "which can improve query concurrency. default is false."})
public boolean enableScanRunSerial = false;

@VariableMgr.VarAttr(name = ENABLE_SQL_CACHE, fuzzy = true)
public boolean enableSqlCache = false;

Expand Down Expand Up @@ -3169,10 +3161,6 @@ public void setShowHiddenColumns(boolean showHiddenColumns) {
this.showHiddenColumns = showHiddenColumns;
}

public boolean isEnableScanRunSerial() {
return enableScanRunSerial;
}

public boolean skipStorageEngineMerge() {
return skipStorageEngineMerge;
}
Expand Down
4 changes: 2 additions & 2 deletions gensrc/thrift/PaloInternalService.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,8 @@ struct TQueryOptions {
72: optional bool enable_orc_lazy_mat = true

73: optional i64 scan_queue_mem_limit

74: optional bool enable_scan_node_run_serial = false;
// deprecated
74: optional bool enable_scan_node_run_serial = false;

75: optional bool enable_insert_strict = false;

Expand Down
Loading