Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature](function)support count_substrings functions #42055

Merged
merged 5 commits into from
Oct 24, 2024
Merged

[feature](function)support count_substrings functions #42055

merged 5 commits into from
Oct 24, 2024

Conversation

zhangstar333
Copy link
Contributor

Proposed changes

support count_substrings functions
doc: apache/doris-website#1211

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41051 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 47a5499c1fe030116aef7cd3d9599f38619158ab, data reload: false

------ Round 1 ----------------------------------
q1	17613	7387	7253	7253
q2	2020	293	277	277
q3	11967	1056	1213	1056
q4	10581	840	869	840
q5	7779	3090	3056	3056
q6	236	155	152	152
q7	999	619	599	599
q8	9352	1917	1932	1917
q9	6580	6449	6405	6405
q10	7038	2409	2461	2409
q11	438	248	251	248
q12	407	226	219	219
q13	17763	3011	3010	3010
q14	261	212	209	209
q15	581	533	523	523
q16	630	568	586	568
q17	975	563	572	563
q18	7356	6645	6608	6608
q19	1341	958	1010	958
q20	497	189	182	182
q21	3947	3086	3002	3002
q22	1103	997	1007	997
Total cold run time: 109464 ms
Total hot run time: 41051 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7278	7224	7298	7224
q2	341	241	234	234
q3	3153	3114	3023	3023
q4	2196	1851	1777	1777
q5	5758	5757	5780	5757
q6	233	145	144	144
q7	2276	1827	1800	1800
q8	3410	3516	3434	3434
q9	8942	8924	8859	8859
q10	3601	3570	3577	3570
q11	597	484	494	484
q12	852	638	631	631
q13	10625	3207	3217	3207
q14	313	273	265	265
q15	580	532	532	532
q16	689	625	636	625
q17	1843	1647	1596	1596
q18	8335	7746	7597	7597
q19	1703	1497	1539	1497
q20	2068	1913	1854	1854
q21	5543	5501	5510	5501
q22	1141	1082	1063	1063
Total cold run time: 71477 ms
Total hot run time: 60674 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.45% (9712/25930)
Line Coverage: 28.72% (80607/280701)
Region Coverage: 28.16% (41716/148134)
Branch Coverage: 24.75% (21214/85724)
Coverage Report: http://coverage.selectdb-in.cc/coverage/47a5499c1fe030116aef7cd3d9599f38619158ab_47a5499c1fe030116aef7cd3d9599f38619158ab/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 192004 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 47a5499c1fe030116aef7cd3d9599f38619158ab, data reload: false

query1	867	382	396	382
query2	6221	2054	2016	2016
query3	8685	192	195	192
query4	34332	23645	23766	23645
query5	3591	483	448	448
query6	287	164	159	159
query7	4194	300	293	293
query8	277	222	235	222
query9	9435	2728	2730	2728
query10	479	280	280	280
query11	17896	15296	15437	15296
query12	157	101	107	101
query13	1564	435	417	417
query14	9556	7059	7756	7059
query15	292	176	178	176
query16	7384	446	486	446
query17	1689	639	592	592
query18	1342	309	314	309
query19	390	162	157	157
query20	123	114	116	114
query21	217	106	104	104
query22	4787	4533	4377	4377
query23	35475	34267	34218	34218
query24	10969	2793	2786	2786
query25	633	411	410	410
query26	1154	160	159	159
query27	2220	290	294	290
query28	7413	2418	2437	2418
query29	708	424	432	424
query30	256	154	153	153
query31	1052	827	807	807
query32	98	55	57	55
query33	756	292	296	292
query34	947	531	542	531
query35	894	742	760	742
query36	1107	937	983	937
query37	153	90	94	90
query38	4020	3980	4014	3980
query39	1502	1435	1417	1417
query40	215	102	101	101
query41	49	46	46	46
query42	124	102	108	102
query43	533	493	497	493
query44	1286	821	807	807
query45	197	166	169	166
query46	1152	720	736	720
query47	1941	1822	1833	1822
query48	433	332	326	326
query49	891	443	431	431
query50	834	394	404	394
query51	7101	7001	6850	6850
query52	101	91	89	89
query53	265	194	186	186
query54	1248	435	444	435
query55	89	82	77	77
query56	282	298	253	253
query57	1262	1187	1160	1160
query58	226	228	237	228
query59	3141	2947	2961	2947
query60	287	271	282	271
query61	103	99	101	99
query62	838	679	675	675
query63	220	192	189	189
query64	3967	641	597	597
query65	3269	3184	3167	3167
query66	740	297	304	297
query67	15954	15627	15630	15627
query68	4412	564	559	559
query69	535	303	302	302
query70	1207	1114	1148	1114
query71	348	287	296	287
query72	7370	3957	3915	3915
query73	797	363	366	363
query74	10222	8991	8958	8958
query75	3490	2648	2703	2648
query76	3049	941	944	941
query77	609	306	308	306
query78	10535	9592	9590	9590
query79	2045	606	605	605
query80	1119	441	457	441
query81	590	248	243	243
query82	700	148	136	136
query83	304	139	135	135
query84	281	66	73	66
query85	1327	304	275	275
query86	438	300	288	288
query87	4423	4330	4309	4309
query88	3286	2237	2164	2164
query89	413	294	290	290
query90	1843	190	190	190
query91	136	102	98	98
query92	68	47	50	47
query93	2537	539	546	539
query94	799	284	284	284
query95	345	247	251	247
query96	636	283	290	283
query97	3292	3134	3135	3134
query98	227	206	198	198
query99	1580	1308	1272	1272
Total cold run time: 298833 ms
Total hot run time: 192004 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.52 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 47a5499c1fe030116aef7cd3d9599f38619158ab, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.65	0.10	0.10
query5	0.52	0.51	0.51
query6	1.14	0.73	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.56	0.50	0.50
query10	0.54	0.55	0.54
query11	0.14	0.11	0.11
query12	0.13	0.11	0.11
query13	0.61	0.59	0.59
query14	2.85	2.86	2.79
query15	0.91	0.83	0.82
query16	0.39	0.39	0.39
query17	1.06	1.07	1.06
query18	0.20	0.20	0.20
query19	1.80	1.88	2.01
query20	0.01	0.01	0.01
query21	15.37	0.59	0.57
query22	2.77	2.29	1.77
query23	17.09	0.96	0.82
query24	2.90	0.74	1.95
query25	0.28	0.12	0.14
query26	0.53	0.13	0.14
query27	0.05	0.04	0.04
query28	10.15	1.09	1.07
query29	12.55	3.28	3.20
query30	0.24	0.06	0.07
query31	2.86	0.39	0.38
query32	3.26	0.47	0.46
query33	3.02	3.01	3.05
query34	16.95	4.47	4.43
query35	4.54	4.54	4.48
query36	0.67	0.46	0.50
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 106.61 s
Total hot run time: 32.52 s

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41097 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ff0eea3257115d64524b701fe8b91e9cf8d86dba, data reload: false

------ Round 1 ----------------------------------
q1	17576	7417	7319	7319
q2	2048	279	270	270
q3	12083	1031	1152	1031
q4	10578	818	845	818
q5	7757	3082	3040	3040
q6	239	159	150	150
q7	998	620	608	608
q8	9371	1945	1925	1925
q9	7249	6460	6418	6418
q10	7030	2448	2364	2364
q11	449	242	246	242
q12	412	227	221	221
q13	17774	2986	2976	2976
q14	241	226	210	210
q15	564	526	525	525
q16	673	578	576	576
q17	965	518	471	471
q18	7215	6752	6755	6752
q19	1347	939	1001	939
q20	482	181	179	179
q21	3984	3154	3069	3069
q22	1118	994	1022	994
Total cold run time: 110153 ms
Total hot run time: 41097 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7290	7266	7308	7266
q2	323	228	225	225
q3	3099	2993	2988	2988
q4	2086	1877	1800	1800
q5	5750	5798	5806	5798
q6	238	144	148	144
q7	2311	1888	1800	1800
q8	3401	3536	3467	3467
q9	8947	8904	8867	8867
q10	3564	3588	3589	3588
q11	601	488	489	488
q12	846	642	610	610
q13	9758	3265	3155	3155
q14	311	276	281	276
q15	599	526	513	513
q16	700	675	635	635
q17	1856	1606	1616	1606
q18	8216	7785	7593	7593
q19	1711	1405	1551	1405
q20	2132	1880	1878	1878
q21	5522	5374	5359	5359
q22	1139	1039	1068	1039
Total cold run time: 70400 ms
Total hot run time: 60500 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.45% (9712/25930)
Line Coverage: 28.72% (80616/280706)
Region Coverage: 28.16% (41723/148140)
Branch Coverage: 24.74% (21207/85724)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ff0eea3257115d64524b701fe8b91e9cf8d86dba_ff0eea3257115d64524b701fe8b91e9cf8d86dba/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 191609 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ff0eea3257115d64524b701fe8b91e9cf8d86dba, data reload: false

query1	925	403	411	403
query2	6257	2023	2040	2023
query3	8684	188	201	188
query4	34208	23677	23754	23677
query5	3519	470	443	443
query6	268	165	172	165
query7	4202	292	300	292
query8	296	235	228	228
query9	9679	2714	2695	2695
query10	475	273	271	271
query11	17981	15314	15309	15309
query12	166	103	101	101
query13	1574	452	413	413
query14	8565	7643	7183	7183
query15	281	176	175	175
query16	7980	440	447	440
query17	1647	620	594	594
query18	2148	311	311	311
query19	378	158	159	158
query20	125	113	114	113
query21	217	108	110	108
query22	4788	4746	4429	4429
query23	35617	34264	34022	34022
query24	10892	2757	2751	2751
query25	633	409	388	388
query26	1346	156	157	156
query27	2603	281	288	281
query28	7805	2414	2430	2414
query29	879	429	418	418
query30	254	155	155	155
query31	1061	793	806	793
query32	96	54	60	54
query33	780	285	287	285
query34	945	506	537	506
query35	899	778	766	766
query36	1102	926	957	926
query37	156	89	89	89
query38	4094	3948	3940	3940
query39	1511	1455	1435	1435
query40	253	100	109	100
query41	55	47	46	46
query42	120	98	97	97
query43	524	487	466	466
query44	1249	803	803	803
query45	193	165	168	165
query46	1140	690	721	690
query47	1935	1843	1866	1843
query48	417	324	319	319
query49	917	455	418	418
query50	806	392	387	387
query51	7014	7065	6896	6896
query52	102	87	92	87
query53	263	206	178	178
query54	1109	420	427	420
query55	82	75	75	75
query56	298	249	252	249
query57	1301	1158	1179	1158
query58	227	246	234	234
query59	3233	2823	2954	2823
query60	294	260	261	260
query61	105	98	102	98
query62	836	698	664	664
query63	219	181	181	181
query64	3918	629	600	600
query65	3295	3218	3221	3218
query66	809	305	307	305
query67	15746	15462	15755	15462
query68	4819	552	561	552
query69	506	296	291	291
query70	1200	1154	1062	1062
query71	341	270	279	270
query72	7261	3981	3960	3960
query73	780	360	368	360
query74	10198	9137	9018	9018
query75	3472	2714	2672	2672
query76	2866	891	986	891
query77	597	291	295	291
query78	10548	9683	9614	9614
query79	2545	593	613	593
query80	1158	447	448	447
query81	586	245	247	245
query82	688	136	138	136
query83	300	151	132	132
query84	277	71	71	71
query85	1369	296	278	278
query86	443	305	305	305
query87	4481	4431	4357	4357
query88	3872	2223	2183	2183
query89	411	296	283	283
query90	1839	187	181	181
query91	135	98	103	98
query92	61	45	47	45
query93	2404	534	531	531
query94	782	306	297	297
query95	349	245	247	245
query96	621	275	282	275
query97	3306	3095	3179	3095
query98	221	202	191	191
query99	1662	1300	1301	1300
Total cold run time: 301594 ms
Total hot run time: 191609 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.03 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ff0eea3257115d64524b701fe8b91e9cf8d86dba, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.02	0.03
query3	0.23	0.06	0.07
query4	1.65	0.10	0.10
query5	0.50	0.50	0.50
query6	1.14	0.73	0.72
query7	0.04	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.56	0.54	0.54
query11	0.15	0.11	0.11
query12	0.14	0.12	0.11
query13	0.61	0.60	0.60
query14	2.80	2.90	2.74
query15	0.91	0.83	0.83
query16	0.39	0.38	0.39
query17	1.10	1.07	1.06
query18	0.20	0.20	0.21
query19	1.97	1.82	2.05
query20	0.02	0.01	0.01
query21	15.36	0.59	0.59
query22	2.92	3.20	2.37
query23	17.16	0.84	0.89
query24	2.97	1.66	0.76
query25	0.30	0.04	0.06
query26	0.48	0.15	0.13
query27	0.04	0.03	0.06
query28	10.37	1.09	1.09
query29	12.58	3.19	3.17
query30	0.24	0.06	0.06
query31	2.88	0.39	0.39
query32	3.26	0.47	0.45
query33	3.01	3.00	3.05
query34	16.91	4.47	4.49
query35	4.51	4.49	4.50
query36	0.68	0.48	0.48
query37	0.08	0.05	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.16	0.12	0.12
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 107.25 s
Total hot run time: 33.03 s

HappenLee
HappenLee previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Add chinese TEST case

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 21, 2024
@zhangstar333
Copy link
Contributor Author

Please Add chinese TEST case

done

@zhangstar333
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/functions/function_bit_test.cpp Outdated Show resolved Hide resolved
@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41440 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e3aba0650e500d62f63b0a779e55e20d72406e90, data reload: false

------ Round 1 ----------------------------------
q1	17696	7680	7291	7291
q2	2056	279	282	279
q3	12149	1076	1193	1076
q4	10554	859	834	834
q5	7738	3147	3091	3091
q6	235	155	147	147
q7	1029	604	596	596
q8	9358	1955	1961	1955
q9	6604	6465	6454	6454
q10	7040	2441	2436	2436
q11	454	242	241	241
q12	412	225	212	212
q13	17784	3006	3018	3006
q14	240	206	209	206
q15	581	523	507	507
q16	646	608	605	605
q17	982	500	531	500
q18	7438	6765	6736	6736
q19	1342	1007	991	991
q20	480	184	181	181
q21	3955	3086	3099	3086
q22	1108	1010	1022	1010
Total cold run time: 109881 ms
Total hot run time: 41440 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7412	7236	7285	7236
q2	321	228	225	225
q3	3067	2956	2962	2956
q4	2136	1892	1821	1821
q5	5755	5807	5779	5779
q6	244	148	142	142
q7	2308	1841	1815	1815
q8	3413	3484	3492	3484
q9	8978	8922	8957	8922
q10	3598	3563	3605	3563
q11	590	487	500	487
q12	873	597	623	597
q13	9318	3253	3201	3201
q14	304	281	266	266
q15	603	534	541	534
q16	697	649	653	649
q17	1838	1626	1596	1596
q18	8307	7856	7563	7563
q19	1752	1641	1494	1494
q20	2147	1882	1877	1877
q21	5492	5542	5380	5380
q22	1126	1068	1084	1068
Total cold run time: 70279 ms
Total hot run time: 60655 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.46% (9710/25923)
Line Coverage: 28.74% (80645/280608)
Region Coverage: 28.17% (41714/148094)
Branch Coverage: 24.75% (21205/85682)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e3aba0650e500d62f63b0a779e55e20d72406e90_e3aba0650e500d62f63b0a779e55e20d72406e90/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 192332 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e3aba0650e500d62f63b0a779e55e20d72406e90, data reload: false

query1	918	390	405	390
query2	6272	2085	2006	2006
query3	8677	192	209	192
query4	34059	23590	23621	23590
query5	3633	474	442	442
query6	281	171	166	166
query7	4189	824	286	286
query8	301	246	234	234
query9	9459	2743	2742	2742
query10	459	275	287	275
query11	17887	15216	15339	15216
query12	152	105	100	100
query13	1588	419	408	408
query14	9795	7179	7275	7179
query15	263	171	183	171
query16	7868	453	510	453
query17	1612	607	562	562
query18	2046	311	318	311
query19	265	156	153	153
query20	121	114	115	114
query21	210	107	114	107
query22	5067	4967	4737	4737
query23	35156	34232	34407	34232
query24	10861	2744	2776	2744
query25	591	400	416	400
query26	716	156	157	156
query27	2087	283	289	283
query28	6483	2475	2448	2448
query29	736	428	421	421
query30	281	159	163	159
query31	1051	764	795	764
query32	97	55	55	55
query33	733	299	303	299
query34	917	507	512	507
query35	926	757	745	745
query36	1112	939	974	939
query37	149	92	91	91
query38	3969	3877	3906	3877
query39	1496	1418	1418	1418
query40	199	100	98	98
query41	50	46	49	46
query42	123	102	111	102
query43	523	487	495	487
query44	1228	806	799	799
query45	199	164	178	164
query46	1143	703	701	701
query47	1926	1851	1862	1851
query48	430	322	317	317
query49	976	426	421	421
query50	814	398	407	398
query51	7170	6885	6855	6855
query52	97	83	89	83
query53	249	176	180	176
query54	1213	429	414	414
query55	78	73	75	73
query56	267	256	252	252
query57	1257	1216	1167	1167
query58	230	234	241	234
query59	3194	3252	3207	3207
query60	292	268	260	260
query61	102	101	101	101
query62	852	675	689	675
query63	220	185	187	185
query64	3798	634	644	634
query65	3289	3175	3204	3175
query66	854	300	294	294
query67	16279	15799	15731	15731
query68	4500	577	551	551
query69	518	290	281	281
query70	1196	1122	1113	1113
query71	345	278	286	278
query72	7226	4024	3929	3929
query73	776	366	363	363
query74	10240	9014	8896	8896
query75	3454	2659	2674	2659
query76	2840	939	880	880
query77	623	288	288	288
query78	10595	9657	9782	9657
query79	1762	592	590	590
query80	2457	446	462	446
query81	588	239	236	236
query82	678	137	133	133
query83	298	131	128	128
query84	283	72	70	70
query85	1520	301	276	276
query86	424	295	303	295
query87	4522	4298	4287	4287
query88	3165	2222	2177	2177
query89	409	290	283	283
query90	2046	187	181	181
query91	135	97	98	97
query92	60	48	48	48
query93	1432	542	541	541
query94	1118	263	291	263
query95	354	243	242	242
query96	614	279	292	279
query97	3263	3139	3103	3103
query98	223	204	200	200
query99	1587	1290	1324	1290
Total cold run time: 298786 ms
Total hot run time: 192332 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.74 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e3aba0650e500d62f63b0a779e55e20d72406e90, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.64	0.10	0.11
query5	0.52	0.51	0.51
query6	1.14	0.72	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.54	0.55	0.56
query11	0.15	0.13	0.10
query12	0.13	0.10	0.10
query13	0.60	0.60	0.59
query14	2.83	2.71	2.74
query15	0.89	0.82	0.83
query16	0.38	0.38	0.37
query17	1.06	0.99	0.96
query18	0.20	0.19	0.21
query19	1.82	1.73	1.86
query20	0.01	0.01	0.02
query21	15.36	0.59	0.59
query22	3.12	2.34	1.71
query23	16.96	1.16	0.79
query24	2.82	1.84	1.39
query25	0.29	0.16	0.05
query26	0.60	0.13	0.14
query27	0.04	0.04	0.06
query28	9.82	1.10	1.07
query29	12.57	3.22	3.20
query30	0.23	0.06	0.06
query31	2.89	0.38	0.40
query32	3.25	0.46	0.45
query33	2.94	2.99	3.05
query34	17.34	4.51	4.57
query35	4.46	4.49	4.55
query36	0.66	0.51	0.48
query37	0.08	0.05	0.06
query38	0.04	0.03	0.03
query39	0.03	0.03	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.65 s
Total hot run time: 32.74 s

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9709/25912)
Line Coverage: 28.73% (80534/280275)
Region Coverage: 28.16% (41636/147880)
Branch Coverage: 24.71% (21149/85588)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9377c2b017c1abe431f34bb685c4a73547473948_9377c2b017c1abe431f34bb685c4a73547473948/report/index.html

HappenLee
HappenLee approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 41715 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9377c2b017c1abe431f34bb685c4a73547473948, data reload: false

------ Round 1 ----------------------------------
q1	17579	7499	7915	7499
q2	2026	299	297	297
q3	12060	1104	1255	1104
q4	10570	905	914	905
q5	7773	3087	3090	3087
q6	240	154	151	151
q7	1034	615	602	602
q8	9385	1961	1942	1942
q9	6661	6476	6447	6447
q10	7097	2434	2468	2434
q11	442	235	247	235
q12	416	219	216	216
q13	17809	3019	3018	3018
q14	249	223	221	221
q15	570	512	503	503
q16	654	597	586	586
q17	984	505	545	505
q18	7492	6677	6694	6677
q19	1354	949	994	949
q20	497	188	186	186
q21	3987	3153	3189	3153
q22	1127	998	999	998
Total cold run time: 110006 ms
Total hot run time: 41715 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7299	7237	7290	7237
q2	340	241	239	239
q3	3059	2994	2944	2944
q4	2139	1839	1833	1833
q5	5808	5778	5825	5778
q6	228	148	144	144
q7	2271	1847	1772	1772
q8	3435	3538	3536	3536
q9	8952	8964	8905	8905
q10	3619	3580	3599	3580
q11	599	499	506	499
q12	877	631	628	628
q13	10494	3183	3207	3183
q14	314	297	293	293
q15	572	535	527	527
q16	681	656	644	644
q17	1907	1662	1628	1628
q18	8362	7820	7613	7613
q19	1735	1484	1552	1484
q20	2149	1913	1868	1868
q21	5757	5419	5470	5419
q22	1179	1062	1051	1051
Total cold run time: 71776 ms
Total hot run time: 60805 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192534 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9377c2b017c1abe431f34bb685c4a73547473948, data reload: false

query1	875	409	435	409
query2	6265	2110	2060	2060
query3	8686	206	209	206
query4	34301	23617	23593	23593
query5	3512	488	470	470
query6	277	174	174	174
query7	4195	305	294	294
query8	301	247	247	247
query9	9606	2653	2650	2650
query10	436	280	293	280
query11	18080	15194	15311	15194
query12	151	107	98	98
query13	1561	436	413	413
query14	9632	7318	7517	7318
query15	236	170	183	170
query16	7990	476	447	447
query17	1684	607	585	585
query18	2066	331	308	308
query19	255	159	154	154
query20	121	114	119	114
query21	216	105	107	105
query22	4738	4559	4517	4517
query23	35295	35385	34593	34593
query24	10970	2777	2784	2777
query25	528	424	397	397
query26	717	164	169	164
query27	2066	284	295	284
query28	6406	2419	2413	2413
query29	677	437	428	428
query30	265	155	162	155
query31	1054	793	802	793
query32	100	56	58	56
query33	779	308	310	308
query34	939	521	535	521
query35	878	761	749	749
query36	1138	961	942	942
query37	153	91	91	91
query38	4015	3917	3977	3917
query39	1460	1418	1420	1418
query40	213	100	100	100
query41	50	47	46	46
query42	129	101	103	101
query43	561	508	506	506
query44	1261	817	814	814
query45	201	169	165	165
query46	1127	715	735	715
query47	1935	1806	1827	1806
query48	429	328	328	328
query49	928	431	416	416
query50	805	400	409	400
query51	7104	7022	7054	7022
query52	101	87	89	87
query53	259	177	177	177
query54	1172	417	413	413
query55	79	76	77	76
query56	282	252	266	252
query57	1285	1142	1125	1125
query58	238	241	236	236
query59	3274	3069	3198	3069
query60	294	264	271	264
query61	102	98	98	98
query62	811	677	676	676
query63	217	189	181	181
query64	3726	643	633	633
query65	3297	3370	3239	3239
query66	736	298	298	298
query67	16244	15745	15546	15546
query68	4530	567	573	567
query69	541	283	289	283
query70	1108	1157	1147	1147
query71	369	274	278	274
query72	7269	3661	3976	3661
query73	775	367	361	361
query74	10317	9115	9038	9038
query75	3597	2616	2705	2616
query76	3268	879	878	878
query77	690	298	297	297
query78	10502	9673	9587	9587
query79	2403	588	611	588
query80	2892	436	465	436
query81	595	242	239	239
query82	696	138	136	136
query83	321	155	137	137
query84	279	69	71	69
query85	1597	298	284	284
query86	459	310	310	310
query87	4507	4371	4289	4289
query88	3508	2205	2171	2171
query89	398	288	284	284
query90	2121	185	186	185
query91	136	105	100	100
query92	63	50	49	49
query93	2507	537	546	537
query94	1167	291	296	291
query95	351	241	245	241
query96	608	272	279	272
query97	3278	3122	3109	3109
query98	224	198	189	189
query99	1569	1317	1308	1308
Total cold run time: 302129 ms
Total hot run time: 192534 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.74 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9377c2b017c1abe431f34bb685c4a73547473948, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.02	0.03
query3	0.23	0.06	0.06
query4	1.65	0.10	0.10
query5	0.52	0.51	0.51
query6	1.14	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.56	0.50	0.50
query10	0.55	0.55	0.56
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.62	0.59	0.59
query14	2.68	2.73	2.84
query15	0.90	0.81	0.83
query16	0.41	0.42	0.41
query17	1.04	1.00	1.04
query18	0.20	0.20	0.19
query19	1.98	1.88	2.03
query20	0.01	0.01	0.01
query21	15.36	0.59	0.58
query22	2.95	2.40	1.57
query23	17.30	0.81	0.84
query24	2.57	1.26	1.19
query25	0.22	0.11	0.18
query26	0.28	0.14	0.14
query27	0.04	0.03	0.06
query28	10.59	1.11	1.06
query29	12.53	3.25	3.22
query30	0.25	0.06	0.05
query31	2.87	0.38	0.38
query32	3.29	0.46	0.45
query33	2.97	3.04	3.05
query34	17.03	4.49	4.53
query35	4.58	4.54	4.48
query36	0.67	0.48	0.51
query37	0.08	0.05	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.9 s
Total hot run time: 32.74 s

@zhangstar333 zhangstar333 merged commit 5155919 into apache:master Oct 24, 2024
24 of 27 checks passed
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Oct 30, 2024
@zhangstar333
[feature](function)support count_substrings functions (apache#42055)
527a475 
support count_substrings functions
doc: apache/doris-website#1211

<!--Describe your changes.-->
yiguolei pushed a commit that referenced this pull request Oct 31, 2024
@zhangstar333
[cherry-pick](branch-21) cherry-pick pr about (#42488) (#42099) (#42055…
6c3d42e 
…) (#42916)

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
@yiguolei yiguolei mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@HappenLee HappenLee HappenLee approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangstar333 @doris-robot @BiteTheDDDDt @HappenLee @yiguolei