[refactor](agg) Refactor agg-related metrics #42898
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| Status AggLocalState::_serialize_with_serialized_key_result(RuntimeState* state, | ||
| vectorized::Block* block, bool* eos) { | ||
| SCOPED_TIMER(_serialize_result_timer); | ||
| Status AggLocalState::_get_results_with_serialized_key(RuntimeState* state, |
There was a problem hiding this comment.
warning: function '_get_results_with_serialized_key' exceeds recommended size/complexity thresholds [readability-function-size]
Status AggLocalState::_get_results_with_serialized_key(RuntimeState* state,
^Additional context
be/src/pipeline/exec/aggregation_source_operator.cpp:94: 115 lines including whitespace and comments (threshold 80)
Status AggLocalState::_get_results_with_serialized_key(RuntimeState* state,
^| @@ -848,12 +841,12 @@ Status StreamingAggLocalState::_get_with_serialized_key_result(RuntimeState* sta | |||
| return Status::OK(); | |||
| } | |||
|
|
|||
| Status StreamingAggLocalState::_serialize_without_key(RuntimeState* state, vectorized::Block* block, | |||
| Status StreamingAggLocalState::_get_results_without_key(RuntimeState* state, vectorized::Block* block, | |||
There was a problem hiding this comment.
warning: method '_get_results_without_key' can be made const [readability-make-member-function-const]
be/src/pipeline/exec/streaming_aggregation_operator.cpp:844:
- bool* eos) {
+ bool* eos) const {be/src/pipeline/exec/streaming_aggregation_operator.h:67:
- Status _get_results_without_key(RuntimeState* state, vectorized::Block* block, bool* eos);
+ Status _get_results_without_key(RuntimeState* state, vectorized::Block* block, bool* eos) const;
Gabriel39
force-pushed
the
refactor_agg
branch
from
711814e to
8d2484b
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
|
PR approved by anyone and no changes requested. |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
### What problem does this PR solve? <!-- You need to clearly describe your PR in this part: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why this function was added. 4. Which codes were refactored and why this part of the code was refactored. 5. Which functions were optimized and what is the difference before and after the optimization. The description of the PR needs to enable reviewers to quickly and clearly understand the logic of the code modification. --> <!-- If there are related issues, please fill in the issue number. - If you want the issue to be closed after the PR is merged, please use "close #12345". Otherwise, use "ref #12345" --> Issue Number: close #xxx <!-- If this PR is followup a preivous PR, for example, fix the bug that introduced by a related PR, link the PR here --> Related PR: #xxx Problem Summary: ### Check List (For Committer) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No colde files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - Release note <!-- bugfix, feat, behavior changed need a release note --> <!-- Add one line release note for this PR. --> None ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Proposed changes
Issue Number: close #xxx