branch-3.0: [fix](heartbeat) fix heartbeat editlog no persist hbTime #42986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backend persist lastUpdateMs, it will be modified by heartbeat editlog. But heartbeat editlog not persist hbTime, and hbTime always equal 0, it will make backend's lastUpdateMs = 0 in bdb image. fix details: 1. heartbeat response persist hbTime; 2. only be state change will write an editlog. but we make a change: even a backend is healthy, still write a healthy response editlog every 5 min. Inorder to make backend's lastUpdateMs periodly updated in bdb image. But notice that this change wouldn't increase real editlog num. Because heartbeat mgr will patch all fe/be's heartbeat into one editlog. Even no fe/be state change, it still write an editlog which not contains any node's response. 3. for a dead heartbeat response, set hbTime to last succ hbTime, then replayer can set correct lastUpdateMs;
Contributor
Author
|
run buildall |
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
run buildall |
16 tasks
gavinchou
pushed a commit
that referenced
this pull request
Nov 21, 2025
…er versions (#58135) Prior to this #42986 PR, the `getLastUpdateMs` field of the backend was not written to the fe image. This caused the tablet mapping on the cloud to lose the PrimaryBackend information after the upgrade, resulting in the regeneration of an incorrect PrimaryBackend and uneven tablet distribution. detail: <img width="930" height="859" alt="image" src="https://github.com/user-attachments/assets/23d62adc-0bbb-49cb-b5b0-d1768f6422c7" />
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
…er versions (#58135) Prior to this #42986 PR, the `getLastUpdateMs` field of the backend was not written to the fe image. This caused the tablet mapping on the cloud to lose the PrimaryBackend information after the upgrade, resulting in the regeneration of an incorrect PrimaryBackend and uneven tablet distribution. detail: <img width="930" height="859" alt="image" src="https://github.com/user-attachments/assets/23d62adc-0bbb-49cb-b5b0-d1768f6422c7" />
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
…er versions (#58135) Prior to this #42986 PR, the `getLastUpdateMs` field of the backend was not written to the fe image. This caused the tablet mapping on the cloud to lose the PrimaryBackend information after the upgrade, resulting in the regeneration of an incorrect PrimaryBackend and uneven tablet distribution. detail: <img width="930" height="859" alt="image" src="https://github.com/user-attachments/assets/23d62adc-0bbb-49cb-b5b0-d1768f6422c7" />
yiguolei
pushed a commit
that referenced
this pull request
Nov 26, 2025
…er versions (#58135) Prior to this #42986 PR, the `getLastUpdateMs` field of the backend was not written to the fe image. This caused the tablet mapping on the cloud to lose the PrimaryBackend information after the upgrade, resulting in the regeneration of an incorrect PrimaryBackend and uneven tablet distribution. detail: <img width="930" height="859" alt="image" src="https://github.com/user-attachments/assets/23d62adc-0bbb-49cb-b5b0-d1768f6422c7" />
nagisa-kunhah
pushed a commit
to nagisa-kunhah/doris
that referenced
this pull request
Dec 14, 2025
…er versions (apache#58135) Prior to this apache#42986 PR, the `getLastUpdateMs` field of the backend was not written to the fe image. This caused the tablet mapping on the cloud to lose the PrimaryBackend information after the upgrade, resulting in the regeneration of an incorrect PrimaryBackend and uneven tablet distribution. detail: <img width="930" height="859" alt="image" src="https://github.com/user-attachments/assets/23d62adc-0bbb-49cb-b5b0-d1768f6422c7" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Body: Backend persist lastUpdateMs, it will be modified by heartbeat editlog. But heartbeat editlog not persist hbTime, and hbTime always equal 0, it will make backend's lastUpdateMs = 0 in bdb image.
fix details:
Cherry-picked from [fix](heartbeat) fix heartbeat editlog no persist hbTime #42653