[Doris On ES][Bug-Fix] Resolve NullPointerException when multi fields with text type
#4300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuyunfeng
added
area/doris-on-es
wuyunfeng
reviewed
Aug 10, 2020
|
|
||
| package org.apache.doris.external.elasticsearch; | ||
|
|
||
| import org.apache.commons.lang3.StringUtils; |
| } | ||
|
|
||
| @Test | ||
| public void testFieldMultAnalyzer() throws Exception { |
Member
There was a problem hiding this comment.
Suggested change
| public void testFieldMultAnalyzer() throws Exception { | |
| public void testMultTextFields() throws Exception { |
fe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/MappingPhase.java
Show resolved
Hide resolved
| mappingPhase.resolveFields(searchContext, loadJsonFromFile("data/es/test_index_mapping_field_mult_analyzer.json")); | ||
| assertFalse(searchContext.docValueFieldsContext().containsKey("k3")); | ||
| } | ||
| } |
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
wuyunfeng
changed the title
text type
wuyunfeng
reviewed
Aug 10, 2020
wuyunfeng
previously approved these changes
Aug 10, 2020
Member
wuyunfeng
left a comment
wuyunfeng
left a comment
There was a problem hiding this comment.
This looks good to me, but i left some minor comments
Member
|
Thanks @hexian55 |
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Aug 11, 2020
… with `text` type (apache#4300)
Closed
acelyc111
pushed a commit
to acelyc111/incubator-doris
that referenced
this pull request
Aug 21, 2020
… with `text` type (apache#4300)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
issues:#4295
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.texttype, query ES table would fails #4295, and have described the bug/feature there in detailFurther comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...