Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[env](compile) add check of compile_check_begin.h and compile_check_end.h #43073

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Nov 1, 2024

What problem does this PR solve?

if compile_check_begin.h and compile_check_end.h are not correctly included,
the following code between them will cause compilation errors.

Problem Summary:

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange
Copy link
Contributor Author

Mryange commented Nov 1, 2024

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

#error The handling of compile_check_begin.h and compile_check_end.h is not done correctly.
#endif

#define COMPILE_CHECK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: macro is not used [clang-diagnostic-unused-macros]

#define COMPILE_CHECK
        ^

@doris-robot
Copy link

TPC-H: Total hot run time: 41468 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 452129dbcc6d57fd7cdc5f5a1c27d819ce3e02b3, data reload: false

------ Round 1 ----------------------------------
q1	17578	7506	7266	7266
q2	2051	154	158	154
q3	10682	1181	1194	1181
q4	10318	831	868	831
q5	7732	3060	3076	3060
q6	238	149	148	148
q7	1027	605	612	605
q8	9354	1955	2002	1955
q9	6604	6458	6408	6408
q10	7076	2387	2430	2387
q11	463	257	258	257
q12	410	225	215	215
q13	17805	2998	3057	2998
q14	256	210	211	210
q15	566	533	519	519
q16	626	584	578	578
q17	981	519	599	519
q18	7247	6724	6805	6724
q19	1353	1022	1058	1022
q20	491	179	180	179
q21	4029	3251	3243	3243
q22	1104	1009	1041	1009
Total cold run time: 107991 ms
Total hot run time: 41468 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7285	7246	7246	7246
q2	343	231	225	225
q3	2936	2847	2770	2770
q4	1933	1713	1789	1713
q5	5469	5497	5528	5497
q6	216	140	144	140
q7	2114	1743	1727	1727
q8	3258	3396	3415	3396
q9	8585	8577	8578	8577
q10	3529	3456	3483	3456
q11	596	500	498	498
q12	816	631	613	613
q13	9587	2979	3046	2979
q14	307	279	277	277
q15	574	507	517	507
q16	678	651	622	622
q17	1826	1595	1600	1595
q18	7929	7441	7462	7441
q19	1682	1530	1582	1530
q20	2059	1805	1782	1782
q21	5458	5231	5186	5186
q22	1125	1068	1000	1000
Total cold run time: 68305 ms
Total hot run time: 58777 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192578 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 452129dbcc6d57fd7cdc5f5a1c27d819ce3e02b3, data reload: false

query1	974	381	392	381
query2	6542	2144	2077	2077
query3	6787	207	213	207
query4	34614	23887	24233	23887
query5	4370	465	434	434
query6	271	182	182	182
query7	4598	295	288	288
query8	297	236	228	228
query9	9814	2774	2741	2741
query10	484	252	266	252
query11	18332	15362	15418	15362
query12	157	103	104	103
query13	1656	425	402	402
query14	10525	7676	7190	7190
query15	311	187	182	182
query16	8051	399	448	399
query17	1786	568	560	560
query18	2144	297	292	292
query19	374	151	152	151
query20	116	109	110	109
query21	207	99	100	99
query22	4388	4319	4233	4233
query23	35027	34106	34384	34106
query24	11026	2785	2807	2785
query25	661	399	397	397
query26	1519	161	160	160
query27	2764	284	288	284
query28	8006	2491	2452	2452
query29	929	425	423	423
query30	321	165	164	164
query31	1018	813	835	813
query32	93	55	59	55
query33	779	280	280	280
query34	966	526	532	526
query35	903	749	727	727
query36	1109	957	964	957
query37	139	79	72	72
query38	4425	4198	4216	4198
query39	1489	1429	1448	1429
query40	282	106	106	106
query41	50	50	46	46
query42	117	103	101	101
query43	568	498	505	498
query44	1255	828	825	825
query45	195	170	166	166
query46	1128	723	695	695
query47	1934	1834	1831	1831
query48	434	315	342	315
query49	1242	408	409	408
query50	811	393	406	393
query51	7288	7148	7016	7016
query52	100	88	91	88
query53	263	186	186	186
query54	1247	416	421	416
query55	82	81	84	81
query56	272	263	249	249
query57	1310	1202	1182	1182
query58	219	199	197	197
query59	3224	3117	3029	3029
query60	277	245	245	245
query61	103	108	99	99
query62	847	683	683	683
query63	217	191	190	190
query64	5027	626	589	589
query65	3275	3200	3203	3200
query66	1096	304	306	304
query67	16090	15890	15834	15834
query68	4554	568	560	560
query69	407	256	252	252
query70	1205	1140	1118	1118
query71	343	253	252	252
query72	6368	3961	3982	3961
query73	783	357	372	357
query74	10451	9304	9057	9057
query75	3459	2683	2659	2659
query76	2728	1098	1077	1077
query77	455	274	271	271
query78	10438	9454	9382	9382
query79	1649	609	614	609
query80	1126	421	418	418
query81	567	247	238	238
query82	931	118	118	118
query83	228	139	135	135
query84	231	66	68	66
query85	1248	307	286	286
query86	374	265	310	265
query87	4839	4580	4777	4580
query88	3358	2227	2199	2199
query89	394	298	294	294
query90	1976	189	190	189
query91	138	98	98	98
query92	58	51	52	51
query93	1100	544	548	544
query94	974	290	277	277
query95	348	254	253	253
query96	620	278	286	278
query97	2858	2676	2835	2676
query98	204	194	209	194
query99	1722	1328	1305	1305
Total cold run time: 303059 ms
Total hot run time: 192578 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.69 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 452129dbcc6d57fd7cdc5f5a1c27d819ce3e02b3, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.65	0.11	0.10
query5	0.43	0.42	0.40
query6	1.16	0.66	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.58	0.51	0.50
query10	0.54	0.54	0.55
query11	0.14	0.10	0.10
query12	0.13	0.11	0.11
query13	0.62	0.60	0.60
query14	2.72	2.77	2.72
query15	0.91	0.82	0.84
query16	0.40	0.42	0.39
query17	1.08	1.04	1.07
query18	0.24	0.24	0.22
query19	1.87	1.84	1.99
query20	0.01	0.00	0.01
query21	15.35	0.60	0.59
query22	2.91	3.48	1.43
query23	17.04	0.91	0.78
query24	3.24	1.48	1.47
query25	0.28	0.10	0.10
query26	0.55	0.13	0.13
query27	0.04	0.04	0.04
query28	9.71	1.10	1.07
query29	12.54	3.24	3.27
query30	0.26	0.06	0.06
query31	2.86	0.39	0.38
query32	3.27	0.46	0.46
query33	3.00	3.07	3.03
query34	16.73	4.45	4.45
query35	4.47	4.59	4.48
query36	0.68	0.49	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.04	0.02	0.02
query40	0.16	0.12	0.12
query41	0.07	0.02	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.28 s
Total hot run time: 32.69 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.82% (9821/25971)
Line Coverage: 28.98% (81590/281540)
Region Coverage: 28.26% (42142/149121)
Branch Coverage: 24.84% (21381/86074)
Coverage Report: http://coverage.selectdb-in.cc/coverage/452129dbcc6d57fd7cdc5f5a1c27d819ce3e02b3_452129dbcc6d57fd7cdc5f5a1c27d819ce3e02b3/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

PR approved by anyone and no changes requested.

@zhangstar333 zhangstar333 merged commit 7cfeebe into apache:master Nov 4, 2024
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants