-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[env](compile) add check of compile_check_begin.h and compile_check_end.h #43073
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
#error The handling of compile_check_begin.h and compile_check_end.h is not done correctly. | ||
#endif | ||
|
||
#define COMPILE_CHECK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: macro is not used [clang-diagnostic-unused-macros]
#define COMPILE_CHECK
^
TPC-H: Total hot run time: 41468 ms
|
TPC-DS: Total hot run time: 192578 ms
|
ClickBench: Total hot run time: 32.69 s
|
TeamCity be ut coverage result: |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
What problem does this PR solve?
if compile_check_begin.h and compile_check_end.h are not correctly included,
the following code between them will cause compilation errors.
Problem Summary:
Check List (For Committer)
Test
Behavior changed:
Does this need documentation?
Release note
None
Check List (For Reviewer who merge this PR)