Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](exit) stop storage engine in exec_env before exit (#42015) #43141

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

dataroaring
Copy link
Contributor

@dataroaring dataroaring commented Nov 2, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@dataroaring
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40371 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f56d747d41c9418617b9e6250667d2e8d9850e3a, data reload: false

------ Round 1 ----------------------------------
q1	17570	7384	7308	7308
q2	2061	154	148	148
q3	10724	1066	1113	1066
q4	10554	719	710	710
q5	7720	2778	2815	2778
q6	235	149	144	144
q7	978	633	590	590
q8	9559	1924	1965	1924
q9	6946	6437	6404	6404
q10	6988	2271	2309	2271
q11	468	252	255	252
q12	414	217	201	201
q13	17777	2959	2991	2959
q14	246	220	207	207
q15	567	498	504	498
q16	662	623	611	611
q17	975	519	573	519
q18	7160	6542	6485	6485
q19	1921	1084	1101	1084
q20	493	197	191	191
q21	3907	3259	3066	3066
q22	1091	978	955	955
Total cold run time: 109016 ms
Total hot run time: 40371 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7356	7240	7223	7223
q2	321	231	231	231
q3	2839	2888	2835	2835
q4	1985	1740	1816	1740
q5	5690	5668	5695	5668
q6	221	139	141	139
q7	2160	1736	1752	1736
q8	3305	3513	3503	3503
q9	8703	8838	8875	8838
q10	3547	3494	3471	3471
q11	603	530	501	501
q12	767	575	629	575
q13	16435	3150	3180	3150
q14	314	272	266	266
q15	567	510	524	510
q16	722	660	682	660
q17	1840	1628	1628	1628
q18	8079	7818	7634	7634
q19	5813	1588	1506	1506
q20	2114	1838	1860	1838
q21	5479	5239	5249	5239
q22	1115	1069	1011	1011
Total cold run time: 79975 ms
Total hot run time: 59902 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193026 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f56d747d41c9418617b9e6250667d2e8d9850e3a, data reload: false

query1	1257	927	914	914
query2	6240	2045	2059	2045
query3	10780	3655	3743	3655
query4	66525	27044	23459	23459
query5	5531	458	430	430
query6	457	169	162	162
query7	6242	305	297	297
query8	341	234	229	229
query9	9369	2638	2620	2620
query10	506	265	245	245
query11	17965	15181	15856	15181
query12	154	109	102	102
query13	1594	428	404	404
query14	12183	7104	6875	6875
query15	210	183	189	183
query16	7242	498	467	467
query17	1055	556	550	550
query18	1855	303	289	289
query19	199	150	152	150
query20	113	105	108	105
query21	206	98	101	98
query22	4562	4160	4121	4121
query23	34218	33523	33728	33523
query24	5680	2866	2842	2842
query25	542	403	398	398
query26	670	159	162	159
query27	1703	290	292	290
query28	4084	2511	2470	2470
query29	682	429	424	424
query30	240	157	151	151
query31	975	792	811	792
query32	66	54	55	54
query33	455	277	273	273
query34	940	481	486	481
query35	845	712	720	712
query36	1069	927	929	927
query37	120	74	74	74
query38	3894	3825	3852	3825
query39	1490	1456	1420	1420
query40	192	99	98	98
query41	50	49	49	49
query42	110	93	95	93
query43	502	454	475	454
query44	1113	777	758	758
query45	181	165	161	161
query46	1104	699	697	697
query47	1929	1794	1811	1794
query48	456	363	369	363
query49	752	394	386	386
query50	803	403	418	403
query51	7273	6980	7144	6980
query52	99	95	92	92
query53	257	185	181	181
query54	555	442	467	442
query55	74	75	73	73
query56	240	266	231	231
query57	1186	1113	1065	1065
query58	206	223	202	202
query59	3276	2920	3016	2920
query60	270	246	241	241
query61	103	122	94	94
query62	780	670	645	645
query63	214	185	185	185
query64	1685	607	629	607
query65	3256	3152	3181	3152
query66	736	324	293	293
query67	15783	15317	15465	15317
query68	4484	526	537	526
query69	424	262	247	247
query70	1118	1120	1105	1105
query71	403	249	257	249
query72	6388	3818	3893	3818
query73	763	334	338	334
query74	10085	9022	8808	8808
query75	3368	2647	2638	2638
query76	1980	988	932	932
query77	536	262	260	260
query78	10607	9659	9447	9447
query79	11888	593	587	587
query80	2266	412	417	412
query81	542	247	253	247
query82	1072	121	113	113
query83	309	144	136	136
query84	284	83	85	83
query85	1764	295	275	275
query86	452	301	305	301
query87	4468	4244	4129	4129
query88	5919	2403	2419	2403
query89	541	290	294	290
query90	2175	178	183	178
query91	171	138	142	138
query92	63	47	48	47
query93	7431	529	525	525
query94	938	289	279	279
query95	343	257	247	247
query96	619	281	290	281
query97	3386	3164	3130	3130
query98	228	196	194	194
query99	1670	1295	1296	1295
Total cold run time: 342129 ms
Total hot run time: 193026 ms

@dataroaring dataroaring merged commit 502d9e5 into apache:branch-3.0 Nov 2, 2024
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants