Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](drop sql) add force in the tosql for drop table and drop database #43227

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[fix](drop sql) add force in the tosql for drop table and drop database #43227

merged 1 commit into from
Nov 22, 2024

Conversation

Vallishp
Copy link
Contributor

@Vallishp Vallishp commented Nov 4, 2024

What problem does this PR solve?

FORCE was missed in toSQL

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Vallishp
Copy link
Contributor Author

Vallishp commented Nov 4, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41068 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 24c367e22ca9d7d12d530cc4354bafa36f24cf87, data reload: false

------ Round 1 ----------------------------------
q1	17585	7383	7358	7358
q2	2036	165	158	158
q3	10640	1080	1186	1080
q4	10565	764	911	764
q5	7743	3076	3090	3076
q6	237	143	142	142
q7	1015	599	593	593
q8	9345	1903	2026	1903
q9	6535	6419	6441	6419
q10	7029	2433	2458	2433
q11	454	257	266	257
q12	406	212	207	207
q13	17788	2987	3009	2987
q14	247	229	203	203
q15	581	512	515	512
q16	629	593	565	565
q17	983	561	513	513
q18	7209	6669	6756	6669
q19	1330	922	1089	922
q20	479	180	184	180
q21	3988	3304	3121	3121
q22	1116	1006	1012	1006
Total cold run time: 107940 ms
Total hot run time: 41068 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7267	7203	7277	7203
q2	329	228	230	228
q3	2943	2976	3039	2976
q4	2023	1857	1815	1815
q5	5724	5742	5784	5742
q6	227	142	143	142
q7	2229	1828	1790	1790
q8	3362	3555	3426	3426
q9	8873	8934	8884	8884
q10	3598	3575	3545	3545
q11	606	498	496	496
q12	840	633	655	633
q13	9834	3264	3228	3228
q14	316	287	270	270
q15	568	515	531	515
q16	695	620	659	620
q17	1849	1617	1629	1617
q18	8355	7800	7436	7436
q19	1705	1534	1490	1490
q20	2122	1870	1836	1836
q21	5626	5423	5307	5307
q22	1143	1050	1024	1024
Total cold run time: 70234 ms
Total hot run time: 60223 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196970 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 24c367e22ca9d7d12d530cc4354bafa36f24cf87, data reload: false

query1	1205	912	897	897
query2	6262	2093	2066	2066
query3	10818	4084	3938	3938
query4	68140	28629	23635	23635
query5	5021	447	435	435
query6	384	172	164	164
query7	5489	297	295	295
query8	309	224	214	214
query9	8553	2650	2639	2639
query10	442	254	264	254
query11	17175	15248	15858	15248
query12	163	103	101	101
query13	1439	439	407	407
query14	9819	7716	7612	7612
query15	205	186	174	174
query16	7264	483	475	475
query17	1035	554	576	554
query18	1794	308	292	292
query19	204	150	149	149
query20	119	113	108	108
query21	202	99	100	99
query22	4533	4593	4562	4562
query23	34369	33861	34167	33861
query24	5984	2813	2750	2750
query25	505	405	404	404
query26	645	158	155	155
query27	1650	293	286	286
query28	3779	2456	2428	2428
query29	682	423	430	423
query30	236	150	152	150
query31	986	794	815	794
query32	68	54	56	54
query33	409	272	264	264
query34	890	510	512	510
query35	856	738	717	717
query36	1084	953	917	917
query37	118	68	74	68
query38	4371	4332	4229	4229
query39	1457	1460	1428	1428
query40	199	97	100	97
query41	48	44	49	44
query42	107	99	95	95
query43	525	494	480	480
query44	1146	811	813	811
query45	181	164	165	164
query46	1127	704	708	704
query47	1977	1881	1893	1881
query48	409	322	321	321
query49	737	396	391	391
query50	826	413	400	400
query51	7262	7172	7204	7172
query52	104	89	87	87
query53	254	176	180	176
query54	521	409	428	409
query55	74	74	71	71
query56	234	242	242	242
query57	1304	1180	1145	1145
query58	208	196	195	195
query59	3234	3230	3116	3116
query60	269	247	243	243
query61	108	102	98	98
query62	796	693	689	689
query63	216	185	181	181
query64	1340	623	608	608
query65	3336	3206	3218	3206
query66	719	302	297	297
query67	16168	15661	15688	15661
query68	3717	570	570	570
query69	418	253	252	252
query70	1167	1078	1113	1078
query71	348	254	253	253
query72	6388	4076	4009	4009
query73	762	364	346	346
query74	10294	9028	9095	9028
query75	3394	2680	2650	2650
query76	2198	1126	1130	1126
query77	468	285	268	268
query78	10453	9504	9410	9410
query79	1125	592	586	586
query80	813	420	435	420
query81	517	238	241	238
query82	1355	115	120	115
query83	231	134	138	134
query84	279	73	71	71
query85	872	294	288	288
query86	316	305	293	293
query87	4786	4704	4881	4704
query88	3235	2221	2213	2213
query89	426	290	295	290
query90	2042	203	185	185
query91	141	102	101	101
query92	61	48	47	47
query93	1303	558	550	550
query94	761	298	295	295
query95	334	244	235	235
query96	604	278	287	278
query97	2852	2697	2726	2697
query98	214	201	200	200
query99	1621	1300	1306	1300
Total cold run time: 315588 ms
Total hot run time: 196970 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.46 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 24c367e22ca9d7d12d530cc4354bafa36f24cf87, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.04	0.03
query3	0.23	0.06	0.06
query4	1.64	0.10	0.10
query5	0.43	0.40	0.42
query6	1.17	0.66	0.65
query7	0.02	0.01	0.02
query8	0.04	0.03	0.04
query9	0.57	0.48	0.50
query10	0.54	0.56	0.54
query11	0.13	0.11	0.10
query12	0.14	0.12	0.10
query13	0.61	0.60	0.58
query14	2.72	2.81	2.76
query15	0.91	0.83	0.83
query16	0.39	0.37	0.38
query17	1.06	1.07	1.08
query18	0.20	0.20	0.20
query19	1.94	1.84	2.01
query20	0.02	0.01	0.01
query21	15.37	0.58	0.54
query22	2.65	3.07	2.13
query23	16.78	0.90	0.93
query24	2.72	1.61	1.84
query25	0.19	0.14	0.23
query26	0.45	0.15	0.14
query27	0.05	0.04	0.04
query28	10.06	1.08	1.06
query29	12.51	3.19	3.22
query30	0.24	0.06	0.06
query31	2.89	0.38	0.38
query32	3.25	0.46	0.46
query33	3.00	2.99	3.09
query34	16.75	4.40	4.54
query35	4.51	4.48	4.50
query36	0.69	0.48	0.46
query37	0.09	0.06	0.05
query38	0.04	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.12	0.13
query41	0.09	0.03	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.48 s
Total hot run time: 33.46 s

dataroaring
dataroaring previously approved these changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

PR approved by anyone and no changes requested.

@dataroaring dataroaring changed the title [fix] add force in the tosql for drop table and drop database [fix](drop sql) add force in the tosql for drop table and drop database Nov 9, 2024
@Vallishp
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 15, 2024
dataroaring
dataroaring approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit db02ca1 into apache:master Nov 22, 2024
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 22, 2024
@Vallishp
[fix](drop sql) add force in the tosql for drop table and drop databa…
4afee40 
…se (#43227)



1. What problem was fixed (it's best to include specific error reporting
information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what
is it now, why was it modified, and what possible impacts might there
be.
3. What features were added. Why this function was added.
4. Which codes were refactored and why this part of the code was
refactored.
5. Which functions were optimized and what is the difference before and
after the optimization.
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.x kind/behavior-changed reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vallishp @doris-robot @Yukang-Lian @dataroaring