-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] (inverted index) Refactor Inverted index file writer (#41625) #43528
[Refactor] (inverted index) Refactor Inverted index file writer (#41625) #43528
Conversation
…he#41625) ## Proposed changes 1. After the normal segment is flushed, the `close_inverted_index` is directly called to write the final composite file. 2. During compaction, in the first step, the `segment writer `writes the `bkd index` while writing normal data. In the second step, the` index compaction` writes the `string index`. In the third step, `close_inverted_index` is uniformly called for all indexes to write the final files. 3. The rowset writer uses `InvertedIndexFileCollection` to store all inverted index file writers, ensuring their lifecycle exists throughout the entire writing or compaction process. 4. When the rowset writer generates the final rowset through `build(rowset)`, it can retrieve the index file sizes from the `InvertedIndexFileCollection` and record them in the rowset meta.
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
be/test/olap/rowset/segment_v2/inverted_index/compaction/index_compaction_test.cpp
Show resolved
Hide resolved
be/test/olap/rowset/segment_v2/inverted_index/compaction/index_compaction_test.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run buildall |
pick from mater #41625