[fix](hive) support query hive view created by spark #43530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
hubgeter
approved these changes
Nov 9, 2024
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
### What problem does this PR solve? Problem Summary: 1. When using Spark to create hive view, the `inputFormat` saved in hive view is `SequenceFileInputFormat`. I think this is a bug of Spark. Actually, we don't need to check input format for view, so we skip the format check for hive view. 2. Fix a bug that when analyzing hive view, we should set both catalog and db in temporary connection context, otherwise, the parse of hive view sql may fail, and will also reset the default db of current connection context, causing following statement executed in this session failed because no default db is found. Co-authored-by: morningman <yunyou@selectdb.com>
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
### What problem does this PR solve? Problem Summary: 1. When using Spark to create hive view, the `inputFormat` saved in hive view is `SequenceFileInputFormat`. I think this is a bug of Spark. Actually, we don't need to check input format for view, so we skip the format check for hive view. 2. Fix a bug that when analyzing hive view, we should set both catalog and db in temporary connection context, otherwise, the parse of hive view sql may fail, and will also reset the default db of current connection context, causing following statement executed in this session failed because no default db is found. Co-authored-by: morningman <yunyou@selectdb.com>
yiguolei
pushed a commit
that referenced
this pull request
Nov 11, 2024
) Cherry-picked from #43530 Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com> Co-authored-by: morningman <yunyou@selectdb.com>
morningman
added a commit
that referenced
this pull request
Nov 12, 2024
) Cherry-picked from #43530 Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com> Co-authored-by: morningman <yunyou@selectdb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When using Spark to create hive view, the
inputFormatsaved in hive view isSequenceFileInputFormat.I think this is a bug of Spark.
Actually, we don't need to check input format for view, so we skip the format check for hive view.
Fix a bug that when analyzing hive view, we should set both catalog and db in temporary connection context,
otherwise, the parse of hive view sql may fail, and will also reset the default db of current connection context,
causing following statement executed in this session failed because no default db is found.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)