Skip to content

[JsonLoad] Fix bug that row num stat is not correct when loading json #4379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Aug 20, 2020
Merged

[JsonLoad] Fix bug that row num stat is not correct when loading json #4379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions be/src/exec/json_scanner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,7 @@ bool JsonReader::_write_values_by_jsonpath(rapidjson::Value& objectValue, MemPoo
if (nullcount == column_num) {
_state->append_error_msg_to_file(_print_json_value(objectValue), "All fields is null or not matched, this is a invalid row.");
_counter->num_rows_filtered++;
valid = false;
}
return valid;
}
Expand All @@ -550,11 +551,15 @@ Status JsonReader::_handle_nested_complex_json(Tuple* tuple, const std::vector<S
}
RETURN_IF_ERROR(st);
if (*eof) {
return Status::OK();// read over,then return
return Status::OK(); // read over,then return
}
break; // read a valid row
}
_write_values_by_jsonpath(*_json_doc, tuple_pool, tuple, slot_descs);
if (!_write_values_by_jsonpath(*_json_doc, tuple_pool, tuple, slot_descs)) {
// there is only one line in this case, so if it return false, just set eof = true
// so that the caller will continue reading next line.
*eof = true;
}
return Status::OK();
}

Expand Down