Skip to content

[opt](nereids) enhance PUSH_DOWN_AGG_THROUGH_JOIN_ONE_SIDE #43856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
englefly merged 5 commits into from
Nov 28, 2024
Merged

[opt](nereids) enhance PUSH_DOWN_AGG_THROUGH_JOIN_ONE_SIDE #43856

englefly merged 5 commits into from
Nov 28, 2024
+212 −44

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Nov 13, 2024 •
edited
Loading

What problem does this PR solve?

PUSH_DOWN_AGG_THROUGH_JOIN_ONE_SIDE has some restrictions

do not support count(*)
do not support join with other join conditions
do not support the project between agg and join that contains non-slot expressions
this pr removes above restrictions for pattern: agg-project-join
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Nov 13, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
Copy link
Contributor Author

englefly commented Nov 13, 2024

run buildall

1 similar comment
@englefly
Copy link
Contributor Author

englefly commented Nov 15, 2024

run buildall

starocean999
starocean999 previously approved these changes Nov 15, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

PR approved by anyone and no changes requested.

@englefly
Copy link
Contributor Author

englefly commented Nov 18, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 18, 2024
@englefly
Copy link
Contributor Author

englefly commented Nov 18, 2024

run buildall

@englefly
Copy link
Contributor Author

englefly commented Nov 26, 2024

run feut

@englefly
Copy link
Contributor Author

englefly commented Nov 27, 2024

run buildall

@englefly
Copy link
Contributor Author

englefly commented Nov 27, 2024

run cloud_p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024

PR approved by at least one committer and no changes requested.

@englefly englefly merged commit fa3bdbc into apache:master Nov 28, 2024
17 of 18 checks passed
@englefly englefly deleted the push-agg-join branch November 28, 2024 03:19
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
@englefly
[opt](nereids) enhance PUSH_DOWN_AGG_THROUGH_JOIN_ONE_SIDE (#43856)
97af1ff 
### What problem does this PR solve?
PUSH_DOWN_AGG_THROUGH_JOIN_ONE_SIDE has some restrictions

do not support count(*)
do not support join with other join conditions
do not support the project between agg and join that contains non-slot
expressions
this pr removes above restrictions for pattern: agg-project-join
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Merged
morrySnow pushed a commit that referenced this pull request Dec 6, 2024
@github-actions @englefly
branch-3.0: [opt](nereids) enhance PUSH_DOWN_AGG_THROUGH_JOIN_ONE_SIDE …
0f00f11 
…#43856 (#45066)

Cherry-picked from #43856

Co-authored-by: minghong <zhouminghong@selectdb.com>
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

+1 more reviewer

@LiBinfeng-01 LiBinfeng-01 LiBinfeng-01 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@englefly @doris-robot @starocean999 @LiBinfeng-01 @morrySnow