Skip to content

[improve][ms] Bvars add the FDB get_count_normalized indicator #44036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Nov 20, 2024
Merged

[improve][ms] Bvars add the FDB get_count_normalized indicator #44036

dataroaring merged 2 commits into from
Nov 20, 2024

Conversation

@Sjwhello
Copy link
Contributor

@Sjwhello Sjwhello commented Nov 15, 2024 •
edited
Loading

What problem does this PR solve?

Bvars add the FDB get_count_normalized indicator

  • g_bvar_txn_kv_ get_count_normalized

@doris-robot
Copy link

doris-robot commented Nov 15, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Sjwhello
Copy link
Contributor Author

Sjwhello commented Nov 15, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

clang-tidy review says "All clean, LGTM! 👍"

gavinchou
gavinchou reviewed Nov 15, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Sjwhello Sjwhello changed the title [improve][ms] Bvars add the FDB get count total indicator [improve][ms] Bvars add the FDB get_count_normalized indicator Nov 18, 2024
@Sjwhello
Copy link
Contributor Author

Sjwhello commented Nov 18, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Sjwhello
Copy link
Contributor Author

Sjwhello commented Nov 18, 2024

run buildall

@Sjwhello Sjwhello requested a review from gavinchou November 18, 2024 03:23
@Sjwhello
Copy link
Contributor Author

Sjwhello commented Nov 19, 2024

run cloud_p0

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 6898b77 into apache:master Nov 20, 2024
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
@Sjwhello
[improve][ms] Bvars add the FDB get_count_normalized indicator (#44036)
9b71e32 
### What problem does this PR solve?
Bvars add the FDB get_count_normalized indicator
- g_bvar_txn_kv_ get_count_normalized

Co-authored-by: sunjiangwei <sunjiangwei@meituan.com>
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 26, 2024
@github-actions @Sjwhello
branch-3.0: [improve][ms] Bvars add the FDB get_count_normalized indi…
1b34ae3 
…cator #44036 (#44350)

Cherry-picked from #44036

Co-authored-by: jw-sun <55874234+Sjwhello@users.noreply.github.com>
Co-authored-by: sunjiangwei <sunjiangwei@meituan.com>
@Sjwhello Sjwhello deleted the add_indicator branch January 15, 2025 08:36
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sjwhello @doris-robot @gavinchou @dataroaring