Skip to content

[UT][Bug-Fix] Resolve UT memory leak problem #4406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 3 commits into from
Aug 21, 2020
Merged

[UT][Bug-Fix] Resolve UT memory leak problem #4406

morningman merged 3 commits into from
Aug 21, 2020

Conversation

@ZhangYu0123
Copy link
Contributor

@ZhangYu0123 ZhangYu0123 commented Aug 20, 2020 •
edited by morningman
Loading

Proposed changes

Fix ut memory leak on Fix #4164

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

@wuyunfeng wuyunfeng changed the title Fix ut memory leak [UT][Bug-Fix] Resolve UT memory leak problem Aug 20, 2020
morningman
morningman approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Aug 20, 2020
@morningman morningman self-assigned this Aug 20, 2020
@morningman morningman merged commit a7422ee into apache:master Aug 21, 2020
acelyc111 pushed a commit to acelyc111/incubator-doris that referenced this pull request Aug 21, 2020
@ZhangYu0123 @acelyc111
[UT][Bug-Fix] Resolve UT memory leak problem (apache#4406)
6d66e3d 
Fix ut memory leak on Fix apache#4164
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Nov 4, 2025
@wyxxxcat
Fix some cases (apache#4406)
989e6fa 
when creating mv, if the selected column has the same name as the table,
will report error
```
errCode = 2, detailMessage = Duplicate column name 'C_CUSTKEY'
errCode = 2, detailMessage = Duplicate column name 'lo_orderkey'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Proposal] Compaction rules optimization

3 participants

@ZhangYu0123 @morningman @wuyunfeng