Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thirdparty](patch) Fix brpc (1.4.0) security issue CVE-2023-31039 #44066

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

gavinchou
Copy link
Contributor

patch brpc apache/brpc#2218 (fixed in 1.5.0) to fix https://www.cve.org/CVERecord?id=CVE-2023-31039

What problem does this PR solve?

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.99% (9897/26053)
Line Coverage: 29.18% (82734/283511)
Region Coverage: 28.30% (42484/150097)
Branch Coverage: 24.89% (21553/86590)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3a4a2525234c45b1e2b149723895b8dd79e76b73_3a4a2525234c45b1e2b149723895b8dd79e76b73/report/index.html

@gavinchou gavinchou changed the title (update)(thirdparty) Fix brpc (1.4.0) security issue CVE-2023-31039 [chore](thirdparty) Fix brpc (1.4.0) security issue CVE-2023-31039 Nov 16, 2024
@gavinchou gavinchou changed the title [chore](thirdparty) Fix brpc (1.4.0) security issue CVE-2023-31039 [thirdparty](patch) Fix brpc (1.4.0) security issue CVE-2023-31039 Nov 16, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 17, 2024
@gavinchou gavinchou merged commit 79519fc into apache:master Nov 17, 2024
28 of 31 checks passed
dataroaring pushed a commit that referenced this pull request Nov 18, 2024
…023-31039 #44066 (#44090)

Cherry-picked from #44066

Co-authored-by: Gavin Chou <gavin@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged p0_c reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants