Skip to content

[Fix](ShortCircuit) fix open segments leading to bad performace #44073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eldenmoon merged 1 commit into from
Nov 16, 2024
Merged

[Fix](ShortCircuit) fix open segments leading to bad performace #44073

eldenmoon merged 1 commit into from
Nov 16, 2024

Conversation

@eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Nov 16, 2024 •
edited
Loading

No need need to open segments for all rowsets, only open in lookup_row_key stage.

Introduced by #42697

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@eldenmoon
[Fix](ShortCircuit) fix open segments leading to bad performace
d11fe39 
Need need to open segments for all rowsets, only open in `lookup_row_key` stage.

Introduced by apache#42697
@doris-robot
Copy link

doris-robot commented Nov 16, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
Copy link
Member Author

eldenmoon commented Nov 16, 2024

run buildall

@dataroaring dataroaring added dev/3.0.x usercase Important user case type label labels Nov 16, 2024
dataroaring
dataroaring approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 16, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2024

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2024

clang-tidy review says "All clean, LGTM! 👍"

xiaokang
xiaokang approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

doris-robot commented Nov 16, 2024

TeamCity be ut coverage result:
Function Coverage: 37.99% (9897/26053)
Line Coverage: 29.18% (82729/283501)
Region Coverage: 28.30% (42480/150090)
Branch Coverage: 24.88% (21544/86588)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d11fe3910042ed52aac29d142f18cdaf6d6c2414_d11fe3910042ed52aac29d142f18cdaf6d6c2414/report/index.html

@eldenmoon eldenmoon closed this Nov 16, 2024
@eldenmoon eldenmoon reopened this Nov 16, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2024

clang-tidy review says "All clean, LGTM! 👍"

@eldenmoon eldenmoon merged commit 893e05a into apache:master Nov 16, 2024
@eldenmoon eldenmoon deleted the fix-open-segment-pq branch November 16, 2024 14:31
github-actions bot pushed a commit that referenced this pull request Nov 16, 2024
@eldenmoon
[Fix](ShortCircuit) fix open segments leading to bad performace (#44073)
e6306c7 
No need need to open segments for all rowsets, only open in
`lookup_row_key` stage.

Introduced by #42697
@github-actions github-actions bot mentioned this pull request Nov 16, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 17, 2024
@github-actions @eldenmoon
branch-3.0: [Fix](ShortCircuit) fix open segments leading to bad perf…
502126a 
…ormace #44073 (#44077)

Cherry-picked from #44073

Co-authored-by: lihangyu <lihangyu@selectdb.com>
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Nov 18, 2024
@eldenmoon
[Fix](ShortCircuit) fix open segments leading to bad performace (apac…
af98f8d 
…he#44073)

No need need to open segments for all rowsets, only open in
`lookup_row_key` stage.

Introduced by apache#42697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokang xiaokang xiaokang approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eldenmoon @doris-robot @xiaokang @dataroaring