Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick](branch-30) pick prs (#41779) (#41623) #44406

Open
wants to merge 2 commits into
base: branch-3.0
Choose a base branch
from
Open

[cherry-pick](branch-30) pick prs (#41779) (#41623) #44406

wants to merge 2 commits into from

Conversation

zhangstar333
Copy link
Contributor

cherry-pick from master (#41779) (#41623)

@zhangstar333
[improve](profile) add timer for record udf execute time (apache#41779)
1a8da66 
## Proposed changes

<img width="314" alt="image"
src="https://github.com/user-attachments/assets/d4f4e2fc-6736-4660-a2c7-12e01eb1a4d1">


<!--Describe your changes.-->
@zhangstar333
[improve](column) implement insert_many_from function for all column (a…
a67cb30 
…pache#41623)

## Proposed changes

the cross join will call insert_many_from function to combine left table
column as result,
implement it's will reduce much virtual function call.
```
mysql [ssb]>select count(c_custkey) from (select customer.c_custkey from dates cross join customer)t;
+------------------+
| count(c_custkey) |
+------------------+
|       7668000000 |
+------------------+
1 row in set (5.56 sec)
```

```
mysql [ssb]>select count(c_custkey) from (select customer.c_custkey from dates cross join customer)t;
+------------------+
| count(c_custkey) |
+------------------+
|       7668000000 |
+------------------+
1 row in set (3.29 sec)
```

<!--Describe your changes.-->
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangstar333 @doris-robot