-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhance](catalog)External partition prune return partitionName instead of partitionId #44415
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 40189 ms
|
public class OneListPartitionEvaluator | ||
extends DefaultExpressionRewriter<Map<Slot, PartitionSlotInput>> implements OnePartitionEvaluator { | ||
private final long partitionId; | ||
public class OneListPartitionEvaluator<K> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add this , this seems not used by this pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ID used for partitioning the inner table, the name used for the external table, and the underlying clipping method are compatible with generics
TPC-DS: Total hot run time: 198249 ms
|
ClickBench: Total hot run time: 32.16 s
|
run p0 |
run cloud_p0 |
What problem does this PR solve?
The partition ID of external data sources is meaningless, and some data sources only have partition names, so the return result of partition pruning is replaced with name instead of ID
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
External partition prune return partitionName instead of partitionId
Release note
External partition prune return partitionName instead of partitionId
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)