Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance](table)Remove unnecessary locks #44416

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

zddr
Copy link
Contributor

@zddr zddr commented Nov 21, 2024

What problem does this PR solve?

OlapTable.getPartitionIds not need get readLock, Because it only returns the ID list without any traversal or other operations. If the caller needs to keep the partition of the table unchanged after obtaining the ID list, they should lock it themselves

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
Remove unnecessary locks

Release note

Remove unnecessary locks

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Nov 21, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 21, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@zddr
Copy link
Contributor Author

zddr commented Nov 22, 2024

run cloud_p0

@morrySnow morrySnow merged commit d8215d7 into apache:master Nov 22, 2024
34 of 35 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 22, 2024
`OlapTable`.`getPartitionIds` not need get readLock, Because it only
returns the ID list without any traversal or other operations. If the
caller needs to keep the partition of the table unchanged after
obtaining the ID list, they should lock it themselves
github-actions bot pushed a commit that referenced this pull request Nov 22, 2024
`OlapTable`.`getPartitionIds` not need get readLock, Because it only
returns the ID list without any traversal or other operations. If the
caller needs to keep the partition of the table unchanged after
obtaining the ID list, they should lock it themselves
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/3.0.x reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants