Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance](mtmv)Enable the MTMVRelatedTableIf interface to support mvcc #44419

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

zddr
Copy link
Contributor

@zddr zddr commented Nov 21, 2024

What problem does this PR solve?

When using the mvcc table to obtain partition snapshots and other operations, the snapshotId parameter needs to be included

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
Enable the MTMVRelatedTableIf interface to support mvcc

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Nov 21, 2024

run buildall

@zddr
Copy link
Contributor Author

zddr commented Nov 21, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39867 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 84cf2f893fad410acaab72a138bde4578f1ca12f, data reload: false

------ Round 1 ----------------------------------
q1	17579	7614	7330	7330
q2	2047	182	185	182
q3	10529	1133	1151	1133
q4	10222	733	787	733
q5	7602	2725	2665	2665
q6	239	152	155	152
q7	1002	629	640	629
q8	9238	1827	1894	1827
q9	6525	6403	6460	6403
q10	6967	2307	2327	2307
q11	462	266	268	266
q12	405	214	223	214
q13	17774	3030	2976	2976
q14	252	220	215	215
q15	576	544	525	525
q16	658	576	568	568
q17	972	621	474	474
q18	7458	6772	6822	6772
q19	1345	995	1007	995
q20	470	182	190	182
q21	3975	3313	3005	3005
q22	377	314	315	314
Total cold run time: 106674 ms
Total hot run time: 39867 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7294	7272	7302	7272
q2	329	230	231	230
q3	2885	2799	3049	2799
q4	2178	1855	1800	1800
q5	5629	5770	5623	5623
q6	225	147	149	147
q7	2196	1764	1865	1764
q8	3390	3579	3494	3494
q9	8862	8931	8972	8931
q10	3614	3540	3582	3540
q11	607	524	505	505
q12	799	572	621	572
q13	10756	3257	3207	3207
q14	318	281	274	274
q15	596	534	527	527
q16	694	648	636	636
q17	1802	1597	1576	1576
q18	8023	7618	7481	7481
q19	1658	1549	1361	1361
q20	2040	1802	1800	1800
q21	5309	5237	5221	5221
q22	615	568	537	537
Total cold run time: 69819 ms
Total hot run time: 59297 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192266 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 84cf2f893fad410acaab72a138bde4578f1ca12f, data reload: false

query1	971	371	384	371
query2	6512	2100	2066	2066
query3	6709	223	214	214
query4	34161	23573	23500	23500
query5	4373	454	437	437
query6	268	172	181	172
query7	4609	298	300	298
query8	293	238	228	228
query9	9665	2663	2667	2663
query10	485	267	252	252
query11	18068	15161	15327	15161
query12	161	105	103	103
query13	1665	428	417	417
query14	9481	7308	7369	7308
query15	282	182	195	182
query16	8153	470	476	470
query17	1828	582	585	582
query18	2128	302	301	301
query19	360	154	152	152
query20	122	121	117	117
query21	212	145	101	101
query22	4707	4457	4486	4457
query23	35270	34022	34189	34022
query24	11435	2443	2465	2443
query25	671	394	392	392
query26	1855	148	157	148
query27	2788	281	281	281
query28	8235	2415	2408	2408
query29	1026	400	417	400
query30	302	156	147	147
query31	1059	796	794	794
query32	96	60	61	60
query33	776	286	281	281
query34	1026	508	521	508
query35	861	711	720	711
query36	1088	975	956	956
query37	286	70	75	70
query38	4329	4325	4301	4301
query39	1491	1411	1416	1411
query40	285	103	104	103
query41	49	45	44	44
query42	108	97	95	95
query43	524	491	490	490
query44	1201	820	832	820
query45	183	166	168	166
query46	1150	698	697	697
query47	1980	1869	1908	1869
query48	394	320	322	320
query49	1292	389	390	389
query50	794	395	375	375
query51	7305	7169	7065	7065
query52	98	89	90	89
query53	253	177	175	175
query54	1242	412	405	405
query55	80	75	81	75
query56	263	244	241	241
query57	1318	1179	1200	1179
query58	228	215	211	211
query59	3203	3057	3185	3057
query60	281	248	254	248
query61	116	112	108	108
query62	891	669	683	669
query63	207	202	183	183
query64	5099	700	638	638
query65	3333	3249	3320	3249
query66	1426	312	327	312
query67	16359	15900	15833	15833
query68	5299	556	555	555
query69	412	257	249	249
query70	1194	1123	1136	1123
query71	328	251	245	245
query72	6379	4113	3990	3990
query73	765	358	367	358
query74	10570	9071	9097	9071
query75	3496	2659	2654	2654
query76	3197	1057	1110	1057
query77	564	272	272	272
query78	10406	9496	9467	9467
query79	2436	598	608	598
query80	1101	437	448	437
query81	542	232	236	232
query82	625	123	124	123
query83	245	156	149	149
query84	239	83	75	75
query85	1825	301	318	301
query86	502	284	289	284
query87	4862	4655	4593	4593
query88	4141	2237	2235	2235
query89	400	289	310	289
query90	2146	185	186	185
query91	132	103	103	103
query92	60	50	53	50
query93	1953	537	540	537
query94	1096	302	288	288
query95	356	252	252	252
query96	610	283	285	283
query97	2896	2717	2733	2717
query98	215	208	197	197
query99	1532	1307	1333	1307
Total cold run time: 307993 ms
Total hot run time: 192266 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.55 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 84cf2f893fad410acaab72a138bde4578f1ca12f, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.07	0.07
query4	1.61	0.11	0.10
query5	0.43	0.39	0.41
query6	1.15	0.66	0.66
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.59	0.51	0.49
query10	0.55	0.54	0.55
query11	0.14	0.10	0.10
query12	0.13	0.12	0.11
query13	0.60	0.60	0.59
query14	2.73	2.81	2.75
query15	0.90	0.83	0.81
query16	0.40	0.38	0.38
query17	1.07	1.02	1.06
query18	0.24	0.21	0.20
query19	1.94	2.01	1.86
query20	0.01	0.01	0.01
query21	15.36	0.61	0.59
query22	2.39	1.75	2.47
query23	16.95	1.13	0.75
query24	3.45	1.04	1.86
query25	0.26	0.05	0.12
query26	0.55	0.13	0.14
query27	0.05	0.05	0.04
query28	9.81	1.09	1.07
query29	12.55	3.32	3.31
query30	0.26	0.06	0.06
query31	2.87	0.37	0.38
query32	3.28	0.46	0.46
query33	3.07	3.05	3.02
query34	17.01	4.47	4.44
query35	4.48	4.53	4.51
query36	0.67	0.51	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.16	0.14	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.4 s
Total hot run time: 32.55 s

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 21, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 5edc7f9 into apache:master Nov 22, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants