Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [Fix](full compaction) Full compaction should not do ordered data compaction #44359 #44432

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Commits on Nov 21, 2024

  1. [Fix](full compaction) Full compaction should not do ordered data com…

    …paction (#44359)
    
    
    Problem: For a duplicate table with the following distribution, if it
    has already completed cumulative compaction and then undergoes full
    compaction, it will cause a BE core issue. Check failed: new_point ==
    Tablet::K_INVALID_CUMULATIVE_POINT || new_point >= _cumulative_point
    Unexpected cumulative point: 1087, origin: 2801.
    "rowsets": [
    "[0-386] 0 DATA NONOVERLAPPING
    02000000000198aabe4290f2b0f5f35610c08a233a061892 0",
    "[387-387] 0 DELETE OVERLAP_UNKNOWN
    0200000000541310ac4d76e7580a708a2823a4d7a4f06090 0",
    "[388-388] 0 DELETE OVERLAP_UNKNOWN
    0200000000541d76ac4d76e7580a708a2823a4d7a4f06090 0",
    "[389-389] 0 DELETE OVERLAP_UNKNOWN
    0200000000543b4dac4d76e7580a708a2823a4d7a4f06090 0",
    "[390-390] 0 DELETE OVERLAP_UNKNOWN
    02000000005453aeac4d76e7580a708a2823a4d7a4f06090 0",
    "[391-391] 0 DELETE OVERLAP_UNKNOWN
    0200000000546a44ac4d76e7580a708a2823a4d7a4f06090 0",
    "[392-392] 0 DELETE OVERLAP_UNKNOWN
    02000000005480dbac4d76e7580a708a2823a4d7a4f06090 0",
    "[393-393] 0 DELETE OVERLAP_UNKNOWN
    0200000000548cb3ac4d76e7580a708a2823a4d7a4f06090 0",
    "[394-394] 0 DELETE OVERLAP_UNKNOWN
    0200000000549a25ac4d76e7580a708a2823a4d7a4f06090 0",
    "[395-395] 0 DELETE OVERLAP_UNKNOWN
    020000000054b359ac4d76e7580a708a2823a4d7a4f06090 0",
    "[396-396] 0 DELETE OVERLAP_UNKNOWN
    020000000054c19dac4d76e7580a708a2823a4d7a4f06090 0",
    "[397-397] 0 DELETE OVERLAP_UNKNOWN
    020000000054d757ac4d76e7580a708a2823a4d7a4f06090 0",
            ...
    "[1085-1085] 0 DELETE OVERLAP_UNKNOWN
    02000000002a0b20bd4798638f237008ff42fbca276b52a2 0",
    "[1087-1506] 1 DATA NONOVERLAPPING
    020000000000047e3b452de14ceaad2e78a87526026d2290 326.10 KB",
    "[1087-1506] 1 DATA NONOVERLAPPING
    020000000000047e3b452de14ceaad2e78a87526026d2290 326.10 KB",
            ...
    "[2800-2800] 0 DELETE OVERLAP_UNKNOWN
    02000000002f12d6bd4798638f237008ff42fbca276b52a2 0"
    
    Reason: The duplicate table will go through ordered data compaction. Due
    to the special distribution of the table, the input rowset will be cut
    by the ordered data compaction, resulting in the full compaction only
    being performed on a part of the rowsets.
    
    Solution: For full compaction, prohibit ordered data compaction.
    Yukang-Lian authored and Your Name committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    92ec5bd View commit details
    Browse the repository at this point in the history