Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](file_cache) Add config to enable base compaction output to file cache (#44497) #44496

Conversation

gavinchou
Copy link
Contributor

@gavinchou gavinchou commented Nov 23, 2024

Previous implementation does not allow the output of base compaction write into file cache, which may have some performance penalty.

This commit add a config to make that policy configurable. be.conf enable_file_cache_keep_base_compaction_output it is false by default.

If your file cache is ample enough to accommodate all the data in your database, enable this option; otherwise, it is recommended to leave it disabled.

master branch PR #44497

… cache

Previous implementation does not allow the output of base compaction
write into file cache, which may have some performance penalty.

This commit add a config to make that policy configurable.
be.conf `enable_file_cache_keep_base_compaction_output` it is false by default.

If your file cache is ample enough to accommodate all the data in your database,
enable this option; otherwise, it is recommended to leave it disabled.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Contributor Author

run buildall

@gavinchou gavinchou changed the title [opt](file_cache) Add config to enable base compaction output to file cache [opt](file_cache) Add config to enable base compaction output to file cache (#44497) Nov 23, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 49d699c into apache:branch-3.0 Nov 24, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants