Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #44547

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Nov 27, 2024
@doris-robot
Copy link

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.74% (9608/26154)
Line Coverage: 28.13% (79033/280919)
Region Coverage: 26.83% (40637/151471)
Branch Coverage: 23.64% (20671/87440)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c9d8d521fa8790fbe423487547d73ca6ddd09845_c9d8d521fa8790fbe423487547d73ca6ddd09845/report/index.html

@zhiqiang-hhhh
Copy link
Contributor

run p0

* Core modification
When hyper scan failed, we should not set_error in FunctionContext.
Since set_error will try cancel query, but actually we want to fall back
to re2 in this case.

* Some refactor
Rename FunctionRegexp so that we can distinguish regexp match with
regexp_extract.

* Reproduce
```cpp
SELECT * FROM regexp_test_chinese WHERE city REGEXP "^上海|^北京" ORDER BY id;
```
Note, the `|` in above sql is a Chinese character.
@yiguolei yiguolei force-pushed the auto-pick-44547-branch-2.1 branch from c9d8d52 to 28109d0 Compare November 27, 2024 14:48
@yiguolei
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.74% (9608/26154)
Line Coverage: 28.13% (79031/280924)
Region Coverage: 26.82% (40629/151474)
Branch Coverage: 23.64% (20671/87442)
Coverage Report: http://coverage.selectdb-in.cc/coverage/28109d0d186f1612ce6f4f2a41abcc980c636241_28109d0d186f1612ce6f4f2a41abcc980c636241/report/index.html

@yiguolei yiguolei merged commit e7520ae into branch-2.1 Nov 28, 2024
12 of 15 checks passed
@github-actions github-actions bot deleted the auto-pick-44547-branch-2.1 branch November 28, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants