-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feat](nereids) add session variable disable_nereids_expression_rules #44831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat](nereids) add session variable disable_nereids_expression_rules #44831
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 40121 ms |
TPC-DS: Total hot run time: 198425 ms |
ClickBench: Total hot run time: 32.71 s |
|
run buildall |
TPC-H: Total hot run time: 40138 ms |
TPC-DS: Total hot run time: 197942 ms |
ClickBench: Total hot run time: 33.42 s |
|
some rules are directly invoked by other rules. For such case, this pr cannot disable them. |
| * Type of rewrite expression rules. | ||
| */ | ||
| public enum ExpressionRuleType { | ||
| SIMPLIFY_COMPARISON_PREDICATE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only this rule can be disabled?
how about other expression rewrite rules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only this rule can be disabled? how about other expression rewrite rules?
add rule type
|
run buildall |
|
run performance |
1 similar comment
|
run performance |
|
run buildall |
|
run performance |
1 similar comment
|
run performance |
|
run feut |
8a124cc to
0b20a91
Compare
|
run buildall |
TPC-H: Total hot run time: 40357 ms |
TPC-DS: Total hot run time: 192143 ms |
ClickBench: Total hot run time: 32.97 s |
|
run p0 |
e3b8548 to
6e235f9
Compare
|
run buildall |
TPC-H: Total hot run time: 39877 ms |
TPC-DS: Total hot run time: 197766 ms |
ClickBench: Total hot run time: 31.56 s |
|
run performance |
1 similar comment
|
run performance |
7287fd9 to
21b0b7c
Compare
|
run buildall |
TPC-H: Total hot run time: 32712 ms |
|
run buildall |
TPC-H: Total hot run time: 32626 ms |
TPC-DS: Total hot run time: 196056 ms |
ClickBench: Total hot run time: 31.23 s |
|
run feut |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
21b0b7c to
aeb3a2c
Compare
|
run buildall |
TPC-H: Total hot run time: 32538 ms |
|
PR approved by at least one committer and no changes requested. |
TPC-DS: Total hot run time: 197841 ms |
ClickBench: Total hot run time: 31.76 s |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Add session variable test_disable_nereids_expression_rule for disable expression rule, example:
for a expression rule
ExpressionPatternMatcher, its has default rule type: ANONYMOUS.when it calls
toRule(ruleTypeXX)will create a rule with type: ruleTypeXX.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)