[Fix](TPartitionVersionInfo) Fix duplicate TPartitionVersionInfo in PublishVersionTask.partitionVersionInfos
#44846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
bobhan1
force-pushed
the
fix-duplicate-TpartitionVersionInfo
branch
from
484a95e to
ab46481
Compare
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
… `PublishVersionTask.partitionVersionInfos` (#44846) ### What problem does this PR solve? Problem Summary: When FE handles BEs' tablet report and finds that there exists some expired txns on BE, it will generate publish version task. `TPartitionVersionInfo` with same values may be added to `transactionsToPublish` under same txn id many times when partitions involved in this failed txn involves many tablets on this BE. Because it uses `ArrayListMultimap`, these duplicate values may occupy a lot of memories when the number of tablets is large. ### Release note Fixed the issue of FE's memory occupation growing too fast in cases of persistent load and clone failures on merge-on-write tables. 修复了在merge-on-write表上有持续的导入失败和clone失败的情况下，FE使用内存增长过快的问题。
Closed
deardeng
pushed a commit
to deardeng/incubator-doris
that referenced
this pull request
Dec 19, 2025
…ublishVersionTask.partitionVersionInfos apache#44846 pick apache#44846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: When FE handles BEs' tablet report and finds that there exists some expired txns on BE, it will generate publish version task.
TPartitionVersionInfowith same values may be added totransactionsToPublishunder same txn id many times when partitions involved in this failed txn involves many tablets on this BE. Because it usesArrayListMultimap, these duplicate values may occupy a lot of memories when the number of tablets is large.Release note
Fixed the issue of FE's memory occupation growing too fast in cases of persistent load and clone failures on merge-on-write tables.
修复了在merge-on-write表上有持续的导入失败和clone失败的情况下，FE使用内存增长过快的问题。
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)