Skip to content

[fix](cloud) fix CHECK failed when transmit from non-TTL to normal #45057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gavinchou merged 1 commit into from
Dec 9, 2024
Merged

[fix](cloud) fix CHECK failed when transmit from non-TTL to normal #45057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions be/src/io/cache/block_file_cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,15 +1093,16 @@ bool BlockFileCache::remove_if_ttl_file_unlock(const UInt128Wrapper& file_key, b
_key_to_time.find(file_key) != _key_to_time.end()) {
if (!remove_directly) {
for (auto& [_, cell] : _files[file_key]) {
if (cell.file_block->cache_type() == FileCacheType::TTL) {
Status st = cell.file_block->update_expiration_time(0);
if (!st.ok()) {
LOG_WARNING("Failed to update expiration time to 0").error(st);
}
if (cell.file_block->cache_type() != FileCacheType::TTL) {
continue;
}
Status st = cell.file_block->update_expiration_time(0);
if (!st.ok()) {
LOG_WARNING("Failed to update expiration time to 0").error(st);
}

if (cell.file_block->cache_type() == FileCacheType::NORMAL) continue;
auto st = cell.file_block->change_cache_type_between_ttl_and_others(
st = cell.file_block->change_cache_type_between_ttl_and_others(
FileCacheType::NORMAL);
if (st.ok()) {
if (cell.queue_iterator) {
Expand Down
Loading