Skip to content

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Dec 6, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #39597

Problem Summary:
When authorization includes create, not check if resources exist

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Dec 6, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by anyone and no changes requested.

@morrySnow morrySnow added usercase Important user case type label p0_b dev/2.1.x dev/2.0.x labels Dec 6, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 40108 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7c2cbdf16b3641f30097309a62ecf9f62199e8cf, data reload: false

------ Round 1 ----------------------------------
q1	17600	7456	7325	7325
q2	2067	185	183	183
q3	10522	1145	1194	1145
q4	10229	791	735	735
q5	7587	2780	2727	2727
q6	231	148	150	148
q7	1005	621	643	621
q8	9271	1840	1903	1840
q9	6709	6524	6546	6524
q10	6991	2279	2309	2279
q11	459	259	265	259
q12	413	220	217	217
q13	17765	3057	2999	2999
q14	241	205	211	205
q15	579	530	557	530
q16	667	606	592	592
q17	976	604	545	545
q18	7368	6626	6704	6626
q19	1340	1083	955	955
q20	466	184	181	181
q21	4016	3152	3249	3152
q22	375	320	320	320
Total cold run time: 106877 ms
Total hot run time: 40108 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7287	7240	7312	7240
q2	341	234	236	234
q3	2892	2830	3127	2830
q4	2157	1846	1782	1782
q5	5608	5715	5637	5637
q6	226	140	146	140
q7	2231	1832	1804	1804
q8	3368	3584	3513	3513
q9	8953	8946	8973	8946
q10	3585	3552	3533	3533
q11	596	494	525	494
q12	828	616	604	604
q13	13709	3232	3127	3127
q14	293	269	288	269
q15	568	543	518	518
q16	675	647	631	631
q17	1799	1586	1579	1579
q18	7920	7427	7368	7368
q19	1664	1617	1482	1482
q20	2037	1805	1815	1805
q21	5377	5250	5164	5164
q22	636	587	590	587
Total cold run time: 72750 ms
Total hot run time: 59287 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191822 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7c2cbdf16b3641f30097309a62ecf9f62199e8cf, data reload: false

query1	1170	383	376	376
query2	6522	2118	2072	2072
query3	6708	214	219	214
query4	34066	23610	23668	23610
query5	4323	445	439	439
query6	290	181	182	181
query7	4622	301	297	297
query8	298	258	252	252
query9	9623	2746	2753	2746
query10	478	250	252	250
query11	18142	15351	15234	15234
query12	153	107	107	107
query13	1659	424	417	417
query14	9127	6724	7641	6724
query15	260	179	184	179
query16	8158	464	501	464
query17	1662	590	582	582
query18	2182	306	302	302
query19	378	159	151	151
query20	119	111	115	111
query21	210	104	104	104
query22	4475	4441	4401	4401
query23	35240	34662	34421	34421
query24	11569	2469	2487	2469
query25	680	405	370	370
query26	1830	154	152	152
query27	2899	279	280	279
query28	8364	2432	2458	2432
query29	1003	414	423	414
query30	304	153	147	147
query31	1034	783	817	783
query32	96	56	55	55
query33	785	325	285	285
query34	1008	523	534	523
query35	921	764	748	748
query36	1104	959	958	958
query37	282	75	73	73
query38	4381	4291	4215	4215
query39	1504	1417	1444	1417
query40	276	100	97	97
query41	46	45	46	45
query42	111	116	97	97
query43	540	514	496	496
query44	1277	803	801	801
query45	197	165	166	165
query46	1178	695	710	695
query47	1960	1858	1891	1858
query48	424	314	323	314
query49	1301	386	382	382
query50	808	390	393	390
query51	7145	7145	7089	7089
query52	102	90	90	90
query53	253	185	182	182
query54	1256	400	416	400
query55	80	75	76	75
query56	265	237	238	237
query57	1286	1117	1135	1117
query58	233	216	221	216
query59	3287	3069	3227	3069
query60	277	241	253	241
query61	117	114	129	114
query62	900	682	686	682
query63	216	191	192	191
query64	5054	655	628	628
query65	3288	3196	3277	3196
query66	1427	328	308	308
query67	15879	15574	15828	15574
query68	4496	571	569	569
query69	422	257	253	253
query70	1196	1165	1134	1134
query71	339	255	301	255
query72	6297	4143	3931	3931
query73	767	375	369	369
query74	10458	9087	9014	9014
query75	3444	2676	2649	2649
query76	2709	1101	1114	1101
query77	459	293	280	280
query78	10429	9589	9418	9418
query79	1280	613	599	599
query80	1027	435	432	432
query81	524	245	225	225
query82	1196	116	117	116
query83	241	160	143	143
query84	240	70	77	70
query85	1349	430	300	300
query86	364	300	269	269
query87	4727	4608	4643	4608
query88	3469	2251	2197	2197
query89	420	291	292	291
query90	2099	185	191	185
query91	135	107	103	103
query92	62	53	51	51
query93	1068	542	538	538
query94	1109	304	304	304
query95	423	252	251	251
query96	609	282	276	276
query97	2865	2686	2679	2679
query98	228	198	194	194
query99	1563	1342	1315	1315
Total cold run time: 302826 ms
Total hot run time: 191822 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.44 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7c2cbdf16b3641f30097309a62ecf9f62199e8cf, data reload: false

query1	0.04	0.03	0.02
query2	0.09	0.03	0.04
query3	0.24	0.07	0.07
query4	1.61	0.11	0.10
query5	0.42	0.41	0.40
query6	1.16	0.66	0.65
query7	0.02	0.01	0.02
query8	0.04	0.03	0.04
query9	0.58	0.51	0.50
query10	0.55	0.57	0.57
query11	0.14	0.11	0.11
query12	0.14	0.12	0.11
query13	0.61	0.60	0.60
query14	2.70	2.72	2.89
query15	0.91	0.83	0.82
query16	0.38	0.36	0.38
query17	1.06	1.05	1.06
query18	0.23	0.22	0.21
query19	1.95	1.89	2.02
query20	0.01	0.01	0.01
query21	15.36	0.61	0.55
query22	2.43	3.12	1.86
query23	17.19	0.93	0.88
query24	3.20	0.71	1.83
query25	0.20	0.28	0.06
query26	0.53	0.14	0.14
query27	0.05	0.05	0.04
query28	10.13	1.11	1.07
query29	12.53	3.27	3.21
query30	0.25	0.06	0.06
query31	2.87	0.39	0.38
query32	3.26	0.47	0.46
query33	3.03	2.97	3.03
query34	17.07	4.56	4.48
query35	4.53	4.51	4.51
query36	0.68	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.16	0.13	0.13
query41	0.07	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.67 s
Total hot run time: 32.44 s

@zddr
Copy link
Contributor Author

zddr commented Dec 6, 2024

run p0

@zddr
Copy link
Contributor Author

zddr commented Dec 6, 2024

run cloud_p0

@morningman morningman merged commit 9f31a39 into apache:master Dec 8, 2024
26 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 8, 2024
…rces exist (#45125)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #39597 

Problem Summary:
When authorization includes create, not check if resources exist
github-actions bot pushed a commit that referenced this pull request Dec 8, 2024
…rces exist (#45125)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #39597 

Problem Summary:
When authorization includes create, not check if resources exist
yiguolei pushed a commit that referenced this pull request Dec 10, 2024
…rces exist (#45125)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #39597 

Problem Summary:
When authorization includes create, not check if resources exist
yiguolei pushed a commit that referenced this pull request Dec 11, 2024
…eck if resources exist #45125 (#45166)

Cherry-picked from #45125

Co-authored-by: zhangdong <zhangdong@selectdb.com>
dataroaring pushed a commit that referenced this pull request Dec 11, 2024
…rces exist (#45125)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #39597 

Problem Summary:
When authorization includes create, not check if resources exist
zddr added a commit to zddr/incubator-doris that referenced this pull request Dec 19, 2024
…rces exist (apache#45125)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: apache#39597 

Problem Summary:
When authorization includes create, not check if resources exist
dataroaring pushed a commit that referenced this pull request Dec 19, 2024
…eck if resources exist #45125 (#45165)

Cherry-picked from #45125

Co-authored-by: zhangdong <zhangdong@selectdb.com>
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.x dev/2.1.8-merged dev/3.0.4-merged p0_b reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants