[enchement](mc)Optimize reading of maxcompute partition tables. #45148
+1,747
−266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
morningman
reviewed
Dec 7, 2024
| } | ||
|
|
||
| public void setException(UserException e) { | ||
| public synchronized void setException(UserException e) { |
Contributor
There was a problem hiding this comment.
Why using synchronized ? add comment in code
Contributor
Author
There was a problem hiding this comment.
It seems that there is no need to add synchronized.
| CompletableFuture.runAsync(() -> { | ||
| try { | ||
| TableBatchReadSession tableBatchReadSession = | ||
| createTableBatchReadSession(requiredBatchPartitionSpecs); |
Contributor
There was a problem hiding this comment.
Looks like in this new implementation, you create read session for each partition?
Is create read session a heavy operation?
Contributor
Author
There was a problem hiding this comment.
create read session for a batch of partition . createTableBatchReadSession have network io , and increasing the number of partitions will cause network io to be very slow. I tested 1500 partitions and it took about 13 seconds.
Contributor
Author
|
run buildall |
morningman
approved these changes
Dec 8, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
zy-kkk
approved these changes
Dec 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
### What problem does this PR solve? Problem Summary: Optimize reading of maxcompute partition tables: 1. Introduce batch mode to generate splits for Maxcompute partition tables to optimize scenarios with a large number of partitions. Control it through the variable `num_partitions_in_batch_mode`. 2. Introduce catalog parameter `mc.split_cross_partition`. The parameter is true, which is more friendly to reading partition tables, and false, which is more friendly to debug. 3. Add `-Darrow.enable_null_check_for_get=false` to be jvm to improve the efficiency of mc arrow data conversion.
hubgeter
added a commit
to hubgeter/doris
that referenced
this pull request
Dec 10, 2024
…he#45148) Problem Summary: Optimize reading of maxcompute partition tables: 1. Introduce batch mode to generate splits for Maxcompute partition tables to optimize scenarios with a large number of partitions. Control it through the variable `num_partitions_in_batch_mode`. 2. Introduce catalog parameter `mc.split_cross_partition`. The parameter is true, which is more friendly to reading partition tables, and false, which is more friendly to debug. 3. Add `-Darrow.enable_null_check_for_get=false` to be jvm to improve the efficiency of mc arrow data conversion.
16 tasks
yiguolei
pushed a commit
that referenced
this pull request
Dec 11, 2024
…) (#45246) bp #45148 ### What problem does this PR solve? Problem Summary: Optimize reading of maxcompute partition tables: 1. Introduce batch mode to generate splits for Maxcompute partition tables to optimize scenarios with a large number of partitions. Control it through the variable `num_partitions_in_batch_mode`. 2. Introduce catalog parameter `mc.split_cross_partition`. The parameter is true, which is more friendly to reading partition tables, and false, which is more friendly to debug. 3. Add `-Darrow.enable_null_check_for_get=false` to be jvm to improve the efficiency of mc arrow data conversion.
16 tasks
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Optimize reading of maxcompute partition tables:
num_partitions_in_batch_mode.mc.split_cross_partition. The parameter is true, which is more friendly to reading partition tables, and false, which is more friendly to debug.-Darrow.enable_null_check_for_get=falseto be jvm to improve the efficiency of mc arrow data conversion.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)