Skip to content

Conversation

@gavinchou
Copy link
Contributor

@gavinchou gavinchou commented Dec 18, 2024

What problem does this PR solve?

  1. Fix delete non-existed object, the original impl. does not handle correctly
  2. Add recycle lag indicators: bvars for index, partition, rowset and txn
    1. recycle_index_earlest_ts_${instance_id} dropped table/mv
    2. recycle_partition_earlest_ts_${instance_id} dropped partitions
    3. recycle_rowset_earlest_ts_${instance_id} compacted rowset
    4. recycle_tmp_rowset_earlest_ts_${instance_id} aborted transactions tmp data
    5. recycle_expired_txn_label_earlest_ts_${instance_id} expired labels and transactions
  3. Add retry for scan_and_recycle() to prevent KV error like "Request future version"
  4. Fix recycle delete instance may leak object data: we have to delete data first before delete KV
  5. Improve code readability: remove duplicated code and add more comments

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou
Copy link
Contributor Author

run buildall

@gavinchou gavinchou added the p0_c label Dec 18, 2024
@qidaye
Copy link
Contributor

qidaye commented Dec 19, 2024

run p1

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

run cloud_p1

@hello-stephen
Copy link
Contributor

run p1

@gavinchou
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 23, 2024
@gavinchou gavinchou merged commit c45d468 into apache:master Dec 24, 2024
24 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 24, 2024
1. Fix delete non-existed object, the original impl. does not handle
correctly
2. Add recycle lag indicators: bvars for index, partition, rowset and
txn
    1. `recycle_index_earlest_ts_${instance_id}` dropped table/mv 
    2. `recycle_partition_earlest_ts_${instance_id}` dropped partitions
    3. `recycle_rowset_earlest_ts_${instance_id}` compacted rowset
4. `recycle_tmp_rowset_earlest_ts_${instance_id}` aborted transactions
tmp data
5. `recycle_expired_txn_label_earlest_ts_${instance_id}` expired labels
and transactions
4. Add retry for scan_and_recycle() to prevent KV error like "Request
future version"
6. Fix recycle delete instance may leak object data: we have to delete
data first before delete KV
7. Improve code readability: remove duplicated code and add more
comments
dataroaring pushed a commit that referenced this pull request Dec 25, 2024
… (#45856)

Cherry-picked from #45617

Co-authored-by: Gavin Chou <gavin@selectdb.com>
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged p0_c reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants