-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](recycler) Improve robustness and observability #45617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](recycler) Improve robustness and observability #45617
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
run p1 |
|
PR approved by anyone and no changes requested. |
|
run cloud_p1 |
|
run p1 |
|
run buildall |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
1. Fix delete non-existed object, the original impl. does not handle
correctly
2. Add recycle lag indicators: bvars for index, partition, rowset and
txn
1. `recycle_index_earlest_ts_${instance_id}` dropped table/mv
2. `recycle_partition_earlest_ts_${instance_id}` dropped partitions
3. `recycle_rowset_earlest_ts_${instance_id}` compacted rowset
4. `recycle_tmp_rowset_earlest_ts_${instance_id}` aborted transactions
tmp data
5. `recycle_expired_txn_label_earlest_ts_${instance_id}` expired labels
and transactions
4. Add retry for scan_and_recycle() to prevent KV error like "Request
future version"
6. Fix recycle delete instance may leak object data: we have to delete
data first before delete KV
7. Improve code readability: remove duplicated code and add more
comments
What problem does this PR solve?
recycle_index_earlest_ts_${instance_id}dropped table/mvrecycle_partition_earlest_ts_${instance_id}dropped partitionsrecycle_rowset_earlest_ts_${instance_id}compacted rowsetrecycle_tmp_rowset_earlest_ts_${instance_id}aborted transactions tmp datarecycle_expired_txn_label_earlest_ts_${instance_id}expired labels and transactionsProblem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)