-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhancement](meta) Sync tablet meta even if local state is not running #45821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement](meta) Sync tablet meta even if local state is not running #45821
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 40005 ms |
TPC-DS: Total hot run time: 191463 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 32.57 s |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b780dd5 to
c3a5e9c
Compare
|
run buildall |
TPC-H: Total hot run time: 32574 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 196456 ms |
ClickBench: Total hot run time: 31.59 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ng (#45821) Avoid a running tablet keep not running state on single one BE with no query. Even if it is a tablet with high compaction score, compaction will fail on this BE since not running state. Before this PR, scheduled tablet meta sync will skip not running tablets. In this PR, we include those tablets in meta sync procedure to avoid long-term inaccurate tablet state.
…r committing sc job (apache#48219) After modification apache#45821, tablet state cloud have been updated before schema change job updating BE local tablet state.
…r committing sc job (apache#48219) After modification apache#45821, tablet state cloud have been updated before schema change job updating BE local tablet state.
…r committing sc job (apache#48219) After modification apache#45821, tablet state cloud have been updated before schema change job updating BE local tablet state.
What problem does this PR solve?
Problem Summary:
Avoid a running tablet keep not running state on single one BE with no query. Even if it is a tablet with high compaction score, compaction will fail on this BE since not running state.
Before this PR, scheduled tablet meta sync will skip not running tablets. In this PR, we include those tablets in meta sync procedure to avoid long-term inaccurate tablet state.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)