Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,13 @@ public void cancelMTMVTask(CancelMTMVTaskInfo info) throws DdlException, MetaNot

public void onCommit(MTMV mtmv) throws DdlException, JobException {
MTMVJob job = getJobByMTMV(mtmv);
if (!job.getJobStatus().equals(JobStatus.RUNNING)) {
if (LOG.isDebugEnabled()) {
LOG.debug("job status of async materialized view: [{}] is: [{}], ignore this event.", mtmv.getName(),
job.getJobStatus());
}
return;
}
MTMVTaskContext mtmvTaskContext = new MTMVTaskContext(MTMVTaskTriggerMode.COMMIT, Lists.newArrayList(),
false);
Env.getCurrentEnv().getJobManager().triggerJob(job.getJobId(), mtmvTaskContext);
Expand Down
25 changes: 24 additions & 1 deletion regression-test/data/mtmv_p0/test_commit_mtmv.out
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,39 @@
-- !task2 --
{"triggerMode":"COMMIT","partitions":[],"isComplete":false}

-- !mv1_2 --
-- !mv1_pause --
1 2017-01-15 1
2 2017-02-15 2
3 2017-03-15 3

-- !mv1_resume --
1 2017-01-15 1
2 2017-02-15 2
3 2017-03-15 3
4 2017-01-15 4
5 2017-01-15 5

-- !mv2_resume --
1 2017-01-15 1
2 2017-02-15 2
3 2017-03-15 3
4 2017-01-15 4
5 2017-01-15 5

-- !mv1_2 --
1 2017-01-15 1
2 2017-02-15 2
3 2017-03-15 3
4 2017-01-15 4
5 2017-01-15 5
6 2017-01-15 6

-- !mv2_2 --
1 2017-01-15 1
2 2017-02-15 2
3 2017-03-15 3
4 2017-01-15 4
5 2017-01-15 5

-- !mv1_init --
1 2017-01-15 1
Expand Down
24 changes: 23 additions & 1 deletion regression-test/suites/mtmv_p0/test_commit_mtmv.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,35 @@ suite("test_commit_mtmv") {
order_qt_mv2 "SELECT * FROM ${mvName2}"
order_qt_task2 "SELECT TaskContext from tasks('type'='mv') where MvName='${mvName2}' order by CreateTime desc limit 1"

// PAUSE MTMV should not refresh
sql """
PAUSE MATERIALIZED VIEW JOB ON ${mvName1};
"""
sql """
insert into ${tableName} values(4,"2017-01-15",4);
"""
waitingMTMVTaskFinished(jobName1)
order_qt_mv1_pause "SELECT * FROM ${mvName1}"

// resume MTMV should refresh
sql """
RESUME MATERIALIZED VIEW JOB ON ${mvName1};
"""
sql """
insert into ${tableName} values(5,"2017-01-15",5);
"""
waitingMTMVTaskFinished(jobName1)
order_qt_mv1_resume "SELECT * FROM ${mvName1}"
waitingMTMVTaskFinished(jobName2)
order_qt_mv2_resume "SELECT * FROM ${mvName2}"

// on manual can not trigger by commit
sql """
alter MATERIALIZED VIEW ${mvName2} REFRESH ON MANUAL;
"""

sql """
insert into ${tableName} values(1,"2017-01-15",1);;
insert into ${tableName} values(6,"2017-01-15",6);;
"""
waitingMTMVTaskFinished(jobName1)
order_qt_mv1_2 "SELECT * FROM ${mvName1}"
Expand Down
Loading