Skip to content

[fix](show)show tables should be case insensitive when lowerCaseTableNames is 1 or 2. #46030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jibing-Li merged 1 commit into from
Dec 26, 2024
Merged

[fix](show)show tables should be case insensitive when lowerCaseTableNames is 1 or 2. #46030

Jibing-Li merged 1 commit into from
Dec 26, 2024
+22 −4

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Dec 26, 2024 •
edited
Loading

What problem does this PR solve?

show tables should be case insensitive when lowerCaseTableNames is 1 or 2.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 26, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review December 26, 2024 09:26
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Dec 26, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 26, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Dec 26, 2024

TPC-H: Total hot run time: 32507 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1e83b7b5bdf35cc7a918aa5d723f6ad024fa3987, data reload: false

------ Round 1 ----------------------------------
q1	17600	6138	6009	6009
q2	2052	292	160	160
q3	10444	1220	736	736
q4	10201	856	423	423
q5	7507	2168	1927	1927
q6	210	179	144	144
q7	891	744	593	593
q8	9233	1356	1145	1145
q9	5165	5028	4936	4936
q10	6925	2299	1933	1933
q11	496	289	260	260
q12	356	367	228	228
q13	18899	3528	2988	2988
q14	239	227	210	210
q15	560	509	500	500
q16	626	612	574	574
q17	557	842	317	317
q18	6825	6524	6416	6416
q19	2233	967	560	560
q20	297	303	186	186
q21	2748	2135	1958	1958
q22	366	343	304	304
Total cold run time: 104430 ms
Total hot run time: 32507 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6268	6235	6496	6235
q2	229	327	227	227
q3	2261	2650	2317	2317
q4	1436	1802	1370	1370
q5	4325	4780	4796	4780
q6	182	182	143	143
q7	2053	1958	1797	1797
q8	2653	2767	2653	2653
q9	7281	7221	7305	7221
q10	3107	3346	2828	2828
q11	573	507	495	495
q12	636	766	652	652
q13	3372	3778	3178	3178
q14	299	314	283	283
q15	581	529	501	501
q16	645	690	656	656
q17	1228	1726	1230	1230
q18	7626	7349	7418	7349
q19	781	1151	1042	1042
q20	2006	2049	1956	1956
q21	5740	5353	4900	4900
q22	618	624	617	617
Total cold run time: 53900 ms
Total hot run time: 52430 ms

@doris-robot
Copy link

doris-robot commented Dec 26, 2024

TPC-DS: Total hot run time: 196258 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1e83b7b5bdf35cc7a918aa5d723f6ad024fa3987, data reload: false

query1	1296	936	910	910
query2	6346	2273	2238	2238
query3	11037	4749	4805	4749
query4	32617	23742	23451	23451
query5	3613	599	452	452
query6	270	195	188	188
query7	3979	498	310	310
query8	320	246	249	246
query9	9396	2759	2730	2730
query10	465	306	267	267
query11	17795	15251	15485	15251
query12	172	106	104	104
query13	1653	564	423	423
query14	11597	7330	6925	6925
query15	242	214	192	192
query16	7935	633	503	503
query17	1546	756	616	616
query18	2065	415	321	321
query19	213	208	163	163
query20	173	114	124	114
query21	203	130	106	106
query22	4576	4701	4641	4641
query23	35057	33659	33461	33461
query24	6306	2358	2320	2320
query25	473	452	383	383
query26	742	243	159	159
query27	2082	454	340	340
query28	5627	2555	2487	2487
query29	551	536	433	433
query30	215	188	151	151
query31	986	949	837	837
query32	93	61	57	57
query33	478	362	331	331
query34	819	858	514	514
query35	802	826	752	752
query36	1035	1047	972	972
query37	119	94	78	78
query38	4134	4209	4072	4072
query39	1533	1470	1441	1441
query40	203	119	103	103
query41	50	42	43	42
query42	112	101	104	101
query43	513	538	481	481
query44	1311	819	827	819
query45	188	180	174	174
query46	875	1055	676	676
query47	1982	2024	1947	1947
query48	383	420	327	327
query49	715	478	394	394
query50	632	666	401	401
query51	7187	7409	7140	7140
query52	106	101	99	99
query53	229	266	185	185
query54	488	501	445	445
query55	85	83	81	81
query56	259	278	261	261
query57	1223	1247	1173	1173
query58	242	220	223	220
query59	3263	3296	3021	3021
query60	264	256	248	248
query61	120	110	111	110
query62	864	819	759	759
query63	233	188	189	188
query64	3804	1050	664	664
query65	3341	3243	3263	3243
query66	788	480	308	308
query67	16105	15729	15634	15634
query68	10298	768	525	525
query69	486	289	244	244
query70	1245	1146	1156	1146
query71	451	294	248	248
query72	5088	3944	3835	3835
query73	912	745	367	367
query74	10252	8996	8804	8804
query75	4580	3156	2661	2661
query76	5617	1213	770	770
query77	1048	377	274	274
query78	10147	10273	9367	9367
query79	3566	921	571	571
query80	747	514	419	419
query81	503	262	232	232
query82	646	141	118	118
query83	207	161	200	161
query84	289	89	65	65
query85	783	414	302	302
query86	363	321	305	305
query87	4642	4524	4421	4421
query88	4406	2197	2196	2196
query89	416	391	293	293
query90	1912	183	181	181
query91	142	137	111	111
query92	62	54	51	51
query93	1494	951	538	538
query94	656	372	284	284
query95	338	262	248	248
query96	489	590	277	277
query97	2805	2806	2687	2687
query98	230	195	198	195
query99	1708	1541	1430	1430
Total cold run time: 300654 ms
Total hot run time: 196258 ms

@doris-robot
Copy link

doris-robot commented Dec 26, 2024

ClickBench: Total hot run time: 31.33 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1e83b7b5bdf35cc7a918aa5d723f6ad024fa3987, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.07
query4	1.62	0.10	0.11
query5	0.44	0.43	0.42
query6	1.15	0.66	0.64
query7	0.03	0.02	0.01
query8	0.04	0.04	0.03
query9	0.57	0.54	0.51
query10	0.55	0.61	0.57
query11	0.15	0.10	0.11
query12	0.13	0.11	0.11
query13	0.60	0.60	0.60
query14	2.72	2.70	2.87
query15	0.90	0.83	0.82
query16	0.38	0.39	0.38
query17	1.06	1.06	1.07
query18	0.23	0.20	0.19
query19	1.90	1.80	2.00
query20	0.01	0.01	0.01
query21	15.37	0.98	0.59
query22	0.75	0.75	0.62
query23	15.39	1.44	0.61
query24	2.94	1.48	0.88
query25	0.18	0.24	0.11
query26	0.30	0.14	0.13
query27	0.06	0.06	0.04
query28	13.93	1.54	1.04
query29	12.58	4.02	3.31
query30	0.25	0.10	0.06
query31	2.80	0.60	0.36
query32	3.23	0.53	0.45
query33	3.08	3.14	3.18
query34	16.60	5.13	4.50
query35	4.53	4.54	4.52
query36	0.63	0.50	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.02	0.03
query40	0.18	0.15	0.13
query41	0.07	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 105.94 s
Total hot run time: 31.33 s

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Dec 26, 2024

run p0

@Jibing-Li Jibing-Li merged commit c3a2edd into apache:master Dec 26, 2024
30 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 26, 2024
@Jibing-Li
[fix](show)show tables should be case insensitive when lowerCaseTable…
5c0e029 
…Names is 1 or 2. (#46030)

### What problem does this PR solve?

show tables should be case insensitive when lowerCaseTableNames is 1 or
2.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None
@github-actions github-actions bot mentioned this pull request Dec 26, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 26, 2024
@Jibing-Li
[fix](show)show tables should be case insensitive when lowerCaseTable…
0b08cb3 
…Names is 1 or 2. (#46030)

### What problem does this PR solve?

show tables should be case insensitive when lowerCaseTableNames is 1 or
2.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None
@github-actions github-actions bot mentioned this pull request Dec 26, 2024
Merged
Jibing-Li added a commit that referenced this pull request Dec 26, 2024
@github-actions @Jibing-Li
branch-3.0: [fix](show)show tables should be case insensitive when lo…
fc0078e 
…werCaseTableNames is 1 or 2. #46030 (#46057)

Cherry-picked from #46030

Co-authored-by: James <lijibing@selectdb.com>
Jibing-Li added a commit that referenced this pull request Dec 26, 2024
@github-actions @Jibing-Li
branch-2.1: [fix](show)show tables should be case insensitive when lo…
8d3e8fe 
…werCaseTableNames is 1 or 2. #46030 (#46058)

Cherry-picked from #46030

Co-authored-by: James <lijibing@selectdb.com>
@Jibing-Li Jibing-Li deleted the showtable branch December 27, 2024 02:14
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Jibing-Li @Thearas @doris-robot @morningman @morrySnow