Skip to content

[fix](cloud) fix routine load loss data when fe master node restart #46149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Jan 7, 2025
Merged

[fix](cloud) fix routine load loss data when fe master node restart #46149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,11 @@ protected RoutineLoadTaskInfo unprotectRenewTask(RoutineLoadTaskInfo routineLoad

@Override
protected void unprotectUpdateProgress() throws UserException {
// For cloud mode, should update cloud progress from meta service,
// then update progress with default offset from Kafka if necessary.
if (Config.isCloudMode()) {
updateCloudProgress();
}
updateNewPartitionProgress();
}

Expand Down
5 changes: 0 additions & 5 deletions fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
package org.apache.doris.load.routineload;

import org.apache.doris.catalog.Env;
import org.apache.doris.common.Config;
import org.apache.doris.common.FeConstants;
import org.apache.doris.common.LoadException;
import org.apache.doris.common.MetaNotFoundException;
Expand Down Expand Up @@ -79,10 +78,6 @@ private void process() throws UserException {
RoutineLoadJob.JobState errorJobState = null;
UserException userException = null;
try {
if (Config.isCloudMode()) {
routineLoadJob.updateCloudProgress();
}

routineLoadJob.prepare();
// judge nums of tasks more than max concurrent tasks of cluster
int desiredConcurrentTaskNum = routineLoadJob.calculateCurrentConcurrentTaskNum();
Expand Down
Loading