[Fix](multi-catalog) Fix column mutate() crash replace it by assume_mutable(). #46151

kaka11chen · 2024-12-30T06:40:21Z

What problem does this PR solve?

Problem Summary:

warning: Unable to find libthread_db matching inferior's thread library, thread debugging will not be available.
Core was generated by `/mnt/doris/be/lib/doris_be'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0000000000000000 in ?? ()
[Current thread is 1 (LWP 3923404)]
(gdb) bt
#0  0x0000000000000000 in ?? ()
#1  0x000055f44f97dda7 in COW<doris::vectorized::IColumn>::release_ref (this=0x7f6bf7d07cc8) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/common/cow.h:99
#2  COW<doris::vectorized::IColumn>::intrusive_ptr<doris::vectorized::IColumn>::~intrusive_ptr (this=0x7f6b792f9670) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/common/cow.h:133
#3  doris::vectorized::ScalarColumnReader::_read_nested_column (this=this@entry=0x7f6be31f8900, doris_column=..., type=
    std::shared_ptr<const doris::vectorized::IDataType> (use count 1, weak count 0) = {...}, select_vector=..., batch_size=<optimized out>, batch_size@entry=4064, read_rows=0x7f6b792f9ad8, 
    eof=0x7f6b792f9af0, is_dict_filter=<optimized out>, align_rows=<optimized out>) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:447
#4  0x000055f44f97e1fc in doris::vectorized::ScalarColumnReader::read_column_data (this=0x7f6be31f8900, doris_column=..., 
    type=std::shared_ptr<const doris::vectorized::IDataType> (use count 1, weak count 0) = {...}, select_vector=..., batch_size=4064, read_rows=0x7f6b792f9ad8, eof=0x7f6b792f9af0, 
    is_dict_filter=<optimized out>) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:504
#5  0x000055f44f97ecbe in doris::vectorized::ArrayColumnReader::read_column_data (this=0x7f69a922ce00, doris_column=..., type=..., select_vector=..., batch_size=4064, read_rows=0x7f6b792f9ad8, 
    eof=0x7f6b792f9af0, is_dict_filter=<optimized out>) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:616
#6  0x000055f44f975460 in doris::vectorized::RowGroupReader::_read_column_data (this=this@entry=0x7f6cf83dd180, block=block@entry=0x7f6bbcc66938, columns=..., batch_size=4064, 
    read_rows=read_rows@entry=0x7f6b792f9ee0, batch_eof=0x7f6cf83d71f0, select_vector=...) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:426
#7  0x000055f44f972682 in doris::vectorized::RowGroupReader::next_batch (this=0x7f6cf83dd180, block=0x7f6bbcc66938, batch_size=140099571418880, read_rows=0x7f6b792f9ee0, batch_eof=0x7f6f06724610)
    at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:321
#8  0x000055f44f9141f8 in doris::vectorized::ParquetReader::get_next_block (this=0x7f6cf83d7000, block=0x7f6bbcc66938, read_rows=0x7f6b792f9ee0, eof=0x7f6bbcc66f88)
    at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/parquet/vparquet_reader.cpp:576
#9  0x000055f450aba6f4 in doris::vectorized::IcebergTableReader::get_next_block (this=0x7f6bb5611180, block=0x7f6bbcc66938, read_rows=0x7f6b792f9ee0, eof=0x7f6bbcc66f88)
    at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/table/iceberg_reader.cpp:138
#10 0x000055f450aaa351 in doris::vectorized::VFileScanner::_get_block_wrapped (this=0x7f6bbcc66800, state=<optimized out>, block=0x7f6bbcc66938, eof=0x7f6b792fa2f7)
    at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/vfile_scanner.cpp:359
#11 0x000055f450aa9ecc in doris::vectorized::VFileScanner::_get_block_impl (this=0x0, state=0xffffffffffffa770, block=0x8c3de0, eof=0x7f6b79300700)
    at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/vfile_scanner.cpp:301
#12 0x000055f450b41e9c in doris::vectorized::VScanner::get_block (this=this@entry=0x7f6bbcc66800, state=state@entry=0x7f6f06724000, block=block@entry=0x7f6bbcc66938, eof=eof@entry=0x7f6b792fa2f7)
    at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/vscanner.cpp:133
#13 0x000055f450b41977 in doris::vectorized::VScanner::get_block_after_projects (this=0x7f6bbcc66800, state=0x7f6f06724000, block=0x7f6cf8394b80, eos=0x7f6b792fa2f7)
    at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/vscanner.cpp:96
#14 0x000055f450a941ff in doris::vectorized::ScannerScheduler::_scanner_scan (ctx=std::shared_ptr<doris::vectorized::ScannerContext> (use count 10, weak count 1) = {...}, 
    scan_task=std::shared_ptr<doris::vectorized::ScanTask> (use count 2, weak count 0) = {...}) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:289
#15 0x000055f450a94b73 in doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}::operator()() const::{lambda()#2}::operator()() const (this=<optimized out>) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:180
#16 doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}::operator()() const (this=0x7f70ccc56ee0) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:179
#17 std::__invoke_impl<void, doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}&>(std::__invoke_other, doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}&) (__f=...) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61
#18 std::__invoke_r<void, doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}&>(doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}&) (__fn=...)
    at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:111
#19 std::_Function_handler<void (), doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}>::_M_invoke(std::_Any_data const&) (__functor=...) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
#20 0x000055f44ca858c8 in doris::ThreadPool::dispatch_thread (this=0x7f70ba259200) at /home/zcp/repo_center/doris_enterprise/doris/be/src/util/threadpool.cpp:543
#21 0x000055f44ca7ad91 in std::function<void ()>::operator()() const (this=0x7f6bf7d07cc0)
    at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:560
#22 doris::Thread::supervise_thread (arg=0x7f6fa185a020) at /home/zcp/repo_center/doris_enterprise/doris/be/src/util/thread.cpp:498
#23 0x00007f70ebf78e25 in ?? ()
#24 0x0000000000000000 in ?? ()

Release note

Fix column mutate() crash replace it by assume_mutable().

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2024-12-30T06:40:26Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

kaka11chen · 2024-12-30T06:40:32Z

run buildall

…utable().

kaka11chen · 2024-12-30T12:17:08Z

run buildall

doris-robot · 2024-12-30T13:25:48Z

TPC-H: Total hot run time: 32627 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6453b3229c680e3290cf970f4c6bfca7ca61abd0, data reload: false

------ Round 1 ----------------------------------
q1	17557	6144	6091	6091
q2	2059	301	169	169
q3	10419	1228	746	746
q4	10250	874	450	450
q5	8316	2211	1980	1980
q6	207	180	149	149
q7	893	761	614	614
q8	9239	1362	1132	1132
q9	5201	4889	4985	4889
q10	6743	2318	1866	1866
q11	491	273	258	258
q12	351	360	214	214
q13	17786	3533	2962	2962
q14	223	235	215	215
q15	556	499	491	491
q16	635	604	588	588
q17	574	856	323	323
q18	6964	6465	6578	6465
q19	3330	955	559	559
q20	300	313	182	182
q21	2750	2182	1979	1979
q22	363	332	305	305
Total cold run time: 105207 ms
Total hot run time: 32627 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6326	6193	6223	6193
q2	240	322	231	231
q3	2258	2641	2309	2309
q4	1427	1834	1410	1410
q5	4351	4779	4897	4779
q6	190	176	145	145
q7	2018	1983	1819	1819
q8	2653	2805	2710	2710
q9	7344	7227	7271	7227
q10	3068	3355	2802	2802
q11	579	504	483	483
q12	655	771	631	631
q13	3334	3701	3128	3128
q14	281	290	288	288
q15	569	521	501	501
q16	654	665	643	643
q17	1239	1727	1294	1294
q18	7676	7410	7353	7353
q19	826	937	1169	937
q20	1992	2071	1924	1924
q21	5695	5426	4982	4982
q22	610	603	587	587
Total cold run time: 53985 ms
Total hot run time: 52376 ms

doris-robot · 2024-12-30T13:38:08Z

TPC-DS: Total hot run time: 197419 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6453b3229c680e3290cf970f4c6bfca7ca61abd0, data reload: false

query1	1300	992	909	909
query2	6506	2461	2437	2437
query3	11013	4569	4781	4569
query4	32922	23542	23438	23438
query5	3848	580	437	437
query6	285	185	169	169
query7	3995	498	312	312
query8	311	261	245	245
query9	9332	2785	2739	2739
query10	470	305	241	241
query11	17890	15437	15236	15236
query12	153	105	103	103
query13	1561	552	396	396
query14	9840	7647	7713	7647
query15	278	214	194	194
query16	7942	608	471	471
query17	1613	778	600	600
query18	2088	418	314	314
query19	222	187	162	162
query20	116	119	111	111
query21	214	121	132	121
query22	4711	4545	4504	4504
query23	34396	33741	34043	33741
query24	6492	2313	2352	2313
query25	466	456	375	375
query26	802	272	155	155
query27	2073	457	339	339
query28	5734	2548	2506	2506
query29	572	570	460	460
query30	224	196	156	156
query31	1014	942	861	861
query32	71	61	62	61
query33	512	369	317	317
query34	745	899	523	523
query35	829	862	779	779
query36	1015	1040	950	950
query37	119	107	75	75
query38	4211	4207	4230	4207
query39	1560	1459	1463	1459
query40	217	124	144	124
query41	51	46	45	45
query42	121	105	101	101
query43	528	560	502	502
query44	1360	830	819	819
query45	193	185	165	165
query46	901	1087	663	663
query47	2006	2039	1943	1943
query48	398	426	337	337
query49	726	527	394	394
query50	653	675	424	424
query51	7269	7074	7192	7074
query52	101	97	93	93
query53	234	258	193	193
query54	492	499	416	416
query55	87	80	83	80
query56	267	273	256	256
query57	1254	1213	1166	1166
query58	241	226	227	226
query59	3262	3265	3153	3153
query60	289	265	245	245
query61	109	110	115	110
query62	876	816	745	745
query63	240	200	200	200
query64	3077	1044	691	691
query65	3339	3240	3245	3240
query66	850	404	311	311
query67	16426	15982	15529	15529
query68	9457	770	525	525
query69	499	298	251	251
query70	1206	1165	1113	1113
query71	446	276	244	244
query72	5944	3887	3852	3852
query73	1710	763	358	358
query74	10148	9125	8820	8820
query75	4613	3140	2638	2638
query76	5581	1194	780	780
query77	975	370	282	282
query78	10027	10237	9383	9383
query79	2232	911	606	606
query80	711	511	428	428
query81	480	267	224	224
query82	212	156	119	119
query83	194	168	153	153
query84	279	98	69	69
query85	738	355	309	309
query86	346	325	296	296
query87	4667	4613	4544	4544
query88	3492	2239	2205	2205
query89	414	415	303	303
query90	1989	188	187	187
query91	130	140	103	103
query92	65	55	53	53
query93	1116	908	538	538
query94	650	397	294	294
query95	338	266	256	256
query96	482	611	282	282
query97	2736	2864	2693	2693
query98	222	206	198	198
query99	1665	1568	1436	1436
Total cold run time: 296776 ms
Total hot run time: 197419 ms

doris-robot · 2024-12-30T13:43:28Z

ClickBench: Total hot run time: 31.77 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6453b3229c680e3290cf970f4c6bfca7ca61abd0, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.06
query4	1.61	0.10	0.10
query5	0.41	0.40	0.40
query6	1.16	0.65	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.48	0.53
query10	0.55	0.60	0.55
query11	0.15	0.10	0.11
query12	0.14	0.12	0.11
query13	0.60	0.61	0.60
query14	2.91	2.74	2.74
query15	0.90	0.82	0.82
query16	0.37	0.38	0.38
query17	1.07	0.98	1.05
query18	0.22	0.21	0.22
query19	1.94	1.81	2.00
query20	0.02	0.01	0.01
query21	15.38	1.00	0.59
query22	0.74	0.93	0.73
query23	15.09	1.44	0.54
query24	3.07	1.78	1.48
query25	0.16	0.23	0.10
query26	0.34	0.15	0.13
query27	0.05	0.07	0.06
query28	14.01	1.48	1.05
query29	12.59	3.91	3.27
query30	0.26	0.11	0.06
query31	2.80	0.61	0.37
query32	3.22	0.55	0.47
query33	3.02	3.05	3.13
query34	16.54	5.11	4.52
query35	4.46	4.48	4.45
query36	0.64	0.50	0.48
query37	0.10	0.07	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.03
query40	0.18	0.14	0.12
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.93 s
Total hot run time: 31.77 s

doris-robot · 2024-12-30T14:27:32Z

TeamCity be ut coverage result:
Function Coverage: 38.89% (10122/26024)
Line Coverage: 29.89% (85531/286156)
Region Coverage: 29.01% (43712/150672)
Branch Coverage: 25.54% (22296/87300)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6453b3229c680e3290cf970f4c6bfca7ca61abd0_6453b3229c680e3290cf970f4c6bfca7ca61abd0/report/index.html

github-actions · 2024-12-31T07:49:53Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-12-31T07:49:55Z

PR approved by anyone and no changes requested.

…utable(). (#46151) ### What problem does this PR solve? Problem Summary: ``` warning: Unable to find libthread_db matching inferior's thread library, thread debugging will not be available. Core was generated by `/mnt/doris/be/lib/doris_be'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x0000000000000000 in ?? () [Current thread is 1 (LWP 3923404)] (gdb) bt #0 0x0000000000000000 in ?? () #1 0x000055f44f97dda7 in COW<doris::vectorized::IColumn>::release_ref (this=0x7f6bf7d07cc8) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/common/cow.h:99 #2 COW<doris::vectorized::IColumn>::intrusive_ptr<doris::vectorized::IColumn>::~intrusive_ptr (this=0x7f6b792f9670) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/common/cow.h:133 #3 doris::vectorized::ScalarColumnReader::_read_nested_column (this=this@entry=0x7f6be31f8900, doris_column=..., type= std::shared_ptr<const doris::vectorized::IDataType> (use count 1, weak count 0) = {...}, select_vector=..., batch_size=<optimized out>, batch_size@entry=4064, read_rows=0x7f6b792f9ad8, eof=0x7f6b792f9af0, is_dict_filter=<optimized out>, align_rows=<optimized out>) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:447 #4 0x000055f44f97e1fc in doris::vectorized::ScalarColumnReader::read_column_data (this=0x7f6be31f8900, doris_column=..., type=std::shared_ptr<const doris::vectorized::IDataType> (use count 1, weak count 0) = {...}, select_vector=..., batch_size=4064, read_rows=0x7f6b792f9ad8, eof=0x7f6b792f9af0, is_dict_filter=<optimized out>) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:504 #5 0x000055f44f97ecbe in doris::vectorized::ArrayColumnReader::read_column_data (this=0x7f69a922ce00, doris_column=..., type=..., select_vector=..., batch_size=4064, read_rows=0x7f6b792f9ad8, eof=0x7f6b792f9af0, is_dict_filter=<optimized out>) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:616 #6 0x000055f44f975460 in doris::vectorized::RowGroupReader::_read_column_data (this=this@entry=0x7f6cf83dd180, block=block@entry=0x7f6bbcc66938, columns=..., batch_size=4064, read_rows=read_rows@entry=0x7f6b792f9ee0, batch_eof=0x7f6cf83d71f0, select_vector=...) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:426 #7 0x000055f44f972682 in doris::vectorized::RowGroupReader::next_batch (this=0x7f6cf83dd180, block=0x7f6bbcc66938, batch_size=140099571418880, read_rows=0x7f6b792f9ee0, batch_eof=0x7f6f06724610) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:321 #8 0x000055f44f9141f8 in doris::vectorized::ParquetReader::get_next_block (this=0x7f6cf83d7000, block=0x7f6bbcc66938, read_rows=0x7f6b792f9ee0, eof=0x7f6bbcc66f88) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/parquet/vparquet_reader.cpp:576 #9 0x000055f450aba6f4 in doris::vectorized::IcebergTableReader::get_next_block (this=0x7f6bb5611180, block=0x7f6bbcc66938, read_rows=0x7f6b792f9ee0, eof=0x7f6bbcc66f88) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/format/table/iceberg_reader.cpp:138 #10 0x000055f450aaa351 in doris::vectorized::VFileScanner::_get_block_wrapped (this=0x7f6bbcc66800, state=<optimized out>, block=0x7f6bbcc66938, eof=0x7f6b792fa2f7) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/vfile_scanner.cpp:359 #11 0x000055f450aa9ecc in doris::vectorized::VFileScanner::_get_block_impl (this=0x0, state=0xffffffffffffa770, block=0x8c3de0, eof=0x7f6b79300700) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/vfile_scanner.cpp:301 #12 0x000055f450b41e9c in doris::vectorized::VScanner::get_block (this=this@entry=0x7f6bbcc66800, state=state@entry=0x7f6f06724000, block=block@entry=0x7f6bbcc66938, eof=eof@entry=0x7f6b792fa2f7) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/vscanner.cpp:133 #13 0x000055f450b41977 in doris::vectorized::VScanner::get_block_after_projects (this=0x7f6bbcc66800, state=0x7f6f06724000, block=0x7f6cf8394b80, eos=0x7f6b792fa2f7) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/vscanner.cpp:96 #14 0x000055f450a941ff in doris::vectorized::ScannerScheduler::_scanner_scan (ctx=std::shared_ptr<doris::vectorized::ScannerContext> (use count 10, weak count 1) = {...}, scan_task=std::shared_ptr<doris::vectorized::ScanTask> (use count 2, weak count 0) = {...}) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:289 #15 0x000055f450a94b73 in doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}::operator()() const::{lambda()#2}::operator()() const (this=<optimized out>) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:180 #16 doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}::operator()() const (this=0x7f70ccc56ee0) at /home/zcp/repo_center/doris_enterprise/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:179 #17 std::__invoke_impl<void, doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}&>(std::__invoke_other, doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}&) (__f=...) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61 #18 std::__invoke_r<void, doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}&>(doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}&) (__fn=...) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:111 #19 std::_Function_handler<void (), doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}>::_M_invoke(std::_Any_data const&) (__functor=...) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291 #20 0x000055f44ca858c8 in doris::ThreadPool::dispatch_thread (this=0x7f70ba259200) at /home/zcp/repo_center/doris_enterprise/doris/be/src/util/threadpool.cpp:543 #21 0x000055f44ca7ad91 in std::function<void ()>::operator()() const (this=0x7f6bf7d07cc0) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:560 #22 doris::Thread::supervise_thread (arg=0x7f6fa185a020) at /home/zcp/repo_center/doris_enterprise/doris/be/src/util/thread.cpp:498 #23 0x00007f70ebf78e25 in ?? () #24 0x0000000000000000 in ?? () ```

… by assume_mutable(). #46151 (#46198) Cherry-picked from #46151 Co-authored-by: Qi Chen <chenqi@selectdb.com>

… by assume_mutable(). #46151 (#46197) Cherry-picked from #46151 Co-authored-by: Qi Chen <chenqi@selectdb.com>

[Fix](multi-catalog) Fix column mutate() crash replace it by assume_m…

6453b32

…utable().

kaka11chen force-pushed the fix_column_mutate_crash branch from 95c9af1 to 6453b32 Compare December 30, 2024 07:15

kaka11chen marked this pull request as ready for review December 31, 2024 02:08

zddr approved these changes Dec 31, 2024

View reviewed changes

CalvinKirs approved these changes Dec 31, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 31, 2024

morningman added dev/2.1.x dev/3.0.x labels Dec 31, 2024

github-actions bot added the reviewed label Dec 31, 2024

morningman merged commit ed61d66 into apache:master Dec 31, 2024
27 of 28 checks passed

github-actions bot mentioned this pull request Dec 31, 2024

branch-3.0: [Fix](multi-catalog) Fix column mutate() crash replace it by assume_mutable(). #46151 #46197

Merged

github-actions bot mentioned this pull request Dec 31, 2024

branch-2.1: [Fix](multi-catalog) Fix column mutate() crash replace it by assume_mutable(). #46151 #46198

Merged

morningman pushed a commit that referenced this pull request Dec 31, 2024

branch-2.1: [Fix](multi-catalog) Fix column mutate() crash replace it…

9390c74

… by assume_mutable(). #46151 (#46198) Cherry-picked from #46151 Co-authored-by: Qi Chen <chenqi@selectdb.com>

morningman added dev/2.1.8-merged and removed dev/2.1.x labels Dec 31, 2024

morningman pushed a commit that referenced this pull request Jan 1, 2025

branch-3.0: [Fix](multi-catalog) Fix column mutate() crash replace it…

5c68b77

… by assume_mutable(). #46151 (#46197) Cherry-picked from #46151 Co-authored-by: Qi Chen <chenqi@selectdb.com>

morningman added dev/3.0.4-merged and removed dev/3.0.x labels Jan 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix](multi-catalog) Fix column mutate() crash replace it by assume_mutable(). #46151

[Fix](multi-catalog) Fix column mutate() crash replace it by assume_mutable(). #46151

kaka11chen commented Dec 30, 2024 •

edited

Loading

Thearas commented Dec 30, 2024

kaka11chen commented Dec 30, 2024

kaka11chen commented Dec 30, 2024

doris-robot commented Dec 30, 2024

doris-robot commented Dec 30, 2024

doris-robot commented Dec 30, 2024

doris-robot commented Dec 30, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

[Fix](multi-catalog) Fix column mutate() crash replace it by assume_mutable(). #46151

[Fix](multi-catalog) Fix column mutate() crash replace it by assume_mutable(). #46151

Conversation

kaka11chen commented Dec 30, 2024 • edited Loading

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Thearas commented Dec 30, 2024

kaka11chen commented Dec 30, 2024

kaka11chen commented Dec 30, 2024

doris-robot commented Dec 30, 2024

doris-robot commented Dec 30, 2024

doris-robot commented Dec 30, 2024

doris-robot commented Dec 30, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

kaka11chen commented Dec 30, 2024 •

edited

Loading